Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: PR marked as approved even when there has never been an approval #17

Closed
twk3 opened this issue Jul 9, 2024 · 2 comments
Closed

bug: PR marked as approved even when there has never been an approval #17

twk3 opened this issue Jul 9, 2024 · 2 comments

Comments

@twk3
Copy link
Contributor

twk3 commented Jul 9, 2024

See the label history of : actualbudget/docs#395 for an example.

It's not clear to me yet what is happening here. As far as the UI, we can't see any visible approved reviews. But perhaps there is a hidden one related to the security bot?
@twk3
Copy link
Contributor Author

twk3 commented Jul 9, 2024

For now maybe we also need to filter to review users who are type: "User", rather than "type: Bot"

Though from the current review data from that PR, all the reviews (including the bot reviews right now), are state "COMMENTED". Not approved.

@twk3
Copy link
Contributor Author

twk3 commented Jul 9, 2024

Nevermind, this was fixed yesterday with #15

@twk3 twk3 closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twk3