Skip to content

Commit c5c21a3

Browse files
committed
all non-push reviews are ignored by labels
1 parent b26a1a1 commit c5c21a3

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/classes/PullRequest.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export default class PullRequest {
133133
).data.map(u => u.id);
134134

135135
const latestReviewsObj: {
136-
[key: number]: { state: string; time: number; user: number };
136+
[key: number]: { state: string; time: number };
137137
} = {};
138138

139139
for (const r of reviews) {
@@ -142,10 +142,11 @@ export default class PullRequest {
142142
const user = r.user.id;
143143
const time = new Date(r.submitted_at).getTime();
144144

145+
if (!pushUsers.includes(user)) continue;
146+
145147
const review = {
146148
state: r.state,
147149
time,
148-
user,
149150
};
150151

151152
if (!latestReviewsObj[user]) {
@@ -167,7 +168,7 @@ export default class PullRequest {
167168
}
168169

169170
const approvingReviews = latestReviews.filter(
170-
r => r.state === 'APPROVED' && pushUsers.includes(r.user),
171+
r => r.state === 'APPROVED',
171172
).length;
172173
const requiredReviews = await this.getRequiredReviews();
173174

0 commit comments

Comments
 (0)