Skip to content

Commit

Permalink
Bump the github_actions group with 2 updates (#567)
Browse files Browse the repository at this point in the history
* Bump the github_actions group with 2 updates

Bumps the github_actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact).

Updates `actions/upload-artifact` from 3 to 4
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

Updates `actions/download-artifact` from 3 to 4
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix breaking changes with artifact actions

* Delete dependabot-review.yml

With grouped PRs this is less useful now since most we'd have is 4 PRs. Also they could contain different versions being updated. We'd rather review and merge. We use an auto approve workflow due to the individual PRs that would be created.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Javier Julio <jjfutbol@gmail.com>
  • Loading branch information
dependabot[bot] and javierjulio authored Dec 24, 2023
1 parent 55cb6d3 commit dc22012
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 43 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ jobs:
run: |
bundle exec rspec
mv coverage/coverage.xml coverage/coverage-ruby-${{ matrix.ruby }}-${{ matrix.deps }}.xml
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-ruby-${{ matrix.ruby }}-${{ matrix.deps }}
path: coverage
if-no-files-found: error

Expand All @@ -54,10 +54,11 @@ jobs:
- test
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: coverage
pattern: coverage-ruby-*
path: coverage
merge-multiple: true
- uses: codecov/codecov-action@v3
with:
directory: coverage
Expand Down
39 changes: 0 additions & 39 deletions .github/workflows/dependabot-review.yml

This file was deleted.

0 comments on commit dc22012

Please sign in to comment.