Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Artifacts are not expiring #670

Open
CDTR-MattConroy opened this issue Feb 4, 2025 · 5 comments
Open

[bug] Artifacts are not expiring #670

CDTR-MattConroy opened this issue Feb 4, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@CDTR-MattConroy
Copy link

What happened?

1 of 2 artifacts did not expire properly.
This below workflow completed yesterday, and has correctly expired artifact themes-deploy, but not release-deploy. Both are set to a retention-days of 1 and have been working correctly until recently.
Image

See also, the following snippets to upload artifacts from 2 different jobs in the same workflow:

      - name: Upload artifacts to GitHub
        uses: actions/upload-artifact@v4.3.1
        with:
          name: themes-deploy
          path: .deploy/**/*.zip
          if-no-files-found: error
          retention-days: 1
      - name: Upload artifacts to GitHub
        uses: actions/upload-artifact@v4.3.1
        with:
          name: release-deploy
          path: .deploy/*.zip
          if-no-files-found: error
          retention-days: 1

What did you expect to happen?

Uploading an artifact with retention-days set should expire the artifact after the set time.

How can we reproduce it?

Presumably creating a job with the same snippets, but as they are practically identical, exact repro step are unknown

Anything else we need to know?

No response

What version of the action are you using?

v4.3.1

What are your runner environments?

self-hosted

Are you on GitHub Enterprise Server? If so, what version?

No response

@CDTR-MattConroy CDTR-MattConroy added the bug Something isn't working label Feb 4, 2025
@yacaovsnc
Copy link
Contributor

👋🏼 @CDTR-MattConroy could you please share the workflow run url so I can take a look?

@CDTR-MattConroy
Copy link
Author

Hi, it's on my company's private repository unfortunately. And I've since manually deleted the artifacts to avoid using too much storage.

@yacaovsnc
Copy link
Contributor

Okay, thanks. Please let me know if this happens again. It would be great if you could let me know the id of the artifact when it happens, you can find out the id if from the artifact link:

Image

@CDTR-MattConroy
Copy link
Author

I've had this happen again, here is the artifact ID pulled from the URL 2564623117.

Image

@yacaovsnc
Copy link
Contributor

It looks like theme-deploy is created by a workflow job run that completed on 2025-02-10T13:10:06Z and release-deploy is created by another workflow job run that is completed on 2025-02-10T13:28:31Z.

The screenshot is posted on

Image

so it seems release-deploy should expire in about 15 minutes or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants