Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner Template does not support pod resources (k8s 1.32+) #3943

Open
4 tasks done
AngellusMortis opened this issue Feb 21, 2025 · 1 comment
Open
4 tasks done

Runner Template does not support pod resources (k8s 1.32+) #3943

AngellusMortis opened this issue Feb 21, 2025 · 1 comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@AngellusMortis
Copy link

Checks

Controller Version

0.10.1

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Add values for `template.spec.resources` in the gha-runner-scale-set Helm chart values

Describe the bug

Kubernetes 1.32 adds the ability to set resource limits on the pod level, the CRD definition for AutoscalingRunnerSet does not allow this. Doing so results in

failed to create typed patch object (arc-runners/cicd-pipelines-dev; actions.github.com/v1alpha1, Kind=AutoscalingRunnerSet): .spec.template.spec.resources: field not declared in schema

Describe the expected behavior

AutoscalingRunnerSet should support pod level resource limits

Additional Context

template:
  spec:
    resources:
      requests:
        cpu: "2000m"
        memory: "1000Mi"
      limits:
        cpu: "2000m"
        memory: "8000Mi"

Controller Logs

failed to create typed patch object (arc-runners/cicd-pipelines-dev; actions.github.com/v1alpha1, Kind=AutoscalingRunnerSet): .spec.template.spec.resources: field not declared in schema

Runner Pod Logs

failed to create typed patch object (arc-runners/cicd-pipelines-dev; actions.github.com/v1alpha1, Kind=AutoscalingRunnerSet): .spec.template.spec.resources: field not declared in schema
@AngellusMortis AngellusMortis added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Feb 21, 2025
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

1 participant