Skip to content

Commit 35a89b9

Browse files
authored
Support for OpenTelemetry 0.22 (#35)
* Support for OpenTelemetry 0.22 * Fixed clippy warning * Tracing open telemetry update
1 parent 87b9e84 commit 35a89b9

File tree

3 files changed

+14
-17
lines changed

3 files changed

+14
-17
lines changed

Cargo.toml

+5-5
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ path = "src/lib.rs"
2222

2323
[dependencies]
2424
tracing = "0.1"
25-
opentelemetry = { version = "0.21" }
26-
opentelemetry_sdk = { version = "0.21", features = ["rt-tokio"] }
27-
opentelemetry-semantic-conventions = { version = "0.13" }
25+
opentelemetry = { version = "0.22" }
26+
opentelemetry_sdk = { version = "0.22", features = ["rt-tokio"] }
27+
opentelemetry-semantic-conventions = { version = "0.14" }
2828
gcloud-sdk = { version = "0.24", features = ["google-devtools-cloudtrace-v2"] }
2929
rvstruct = "0.3"
3030
rsb_derive = "0.5"
@@ -36,8 +36,8 @@ async-trait = "0.1"
3636

3737
[dev-dependencies]
3838
tokio = { version = "1", features = ["full"] }
39-
opentelemetry = { version = "0.21" }
39+
opentelemetry = { version = "0.22" }
4040
tracing = "0.1"
4141
tracing-subscriber = { version = "0.3", features = ["env-filter","registry"] }
42-
tracing-opentelemetry = { version = "0.22" }
42+
tracing-opentelemetry = { version = "0.23" }
4343
cargo-husky = { version = "1.5", default-features = false, features = ["run-for-all", "prepush-hook", "run-cargo-fmt"] }

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ opentelemetry-gcloud-trace = "0.8"
1616

1717
| opentelemetry-gcloud-trace version | opentelemetry version | tracing-opentelemetry | gcloud-sdk |
1818
|------------------------------------|-----------------------|-----------------------|------------|
19+
| 0.9 | 0.22 | 0.23 | 0.24 |
1920
| 0.8 | 0.21 | 0.22 | 0.23 |
2021
| 0.7 | 0.20 | 0.21 | 0.21 |
2122
| 0.6 | 0.20 | 0.20 | 0.20 |

src/google_trace_exporter_client.rs

+8-12
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ impl GcpCloudTraceExporterClient {
9696
}
9797
}
9898

99-
fn convert_span_attrs(attrs: &Vec<KeyValue>) -> gspan::Attributes {
99+
fn convert_span_attrs(attrs: &[KeyValue]) -> gspan::Attributes {
100100
const MAX_ATTRS: usize = 32;
101101
gspan::Attributes {
102102
attribute_map: attrs
@@ -140,9 +140,7 @@ impl GcpCloudTraceExporterClient {
140140
}
141141
}
142142

143-
fn convert_time_events(
144-
events: &opentelemetry_sdk::trace::EvictedQueue<opentelemetry::trace::Event>,
145-
) -> gspan::TimeEvents {
143+
fn convert_time_events(events: &opentelemetry_sdk::trace::SpanEvents) -> gspan::TimeEvents {
146144
const MAX_EVENTS: usize = 128;
147145

148146
gspan::TimeEvents {
@@ -151,10 +149,10 @@ impl GcpCloudTraceExporterClient {
151149
.take(MAX_EVENTS)
152150
.map(Self::convert_time_event)
153151
.collect(),
154-
dropped_annotations_count: if events.len() > MAX_EVENTS {
155-
(events.dropped_count() as usize + events.len() - MAX_EVENTS) as i32
152+
dropped_message_events_count: if events.len() > MAX_EVENTS {
153+
(events.dropped_count as usize + events.len() - MAX_EVENTS) as i32
156154
} else {
157-
events.dropped_count() as i32
155+
events.dropped_count as i32
158156
},
159157
..gspan::TimeEvents::default()
160158
}
@@ -191,9 +189,7 @@ impl GcpCloudTraceExporterClient {
191189
})
192190
}
193191

194-
fn convert_links(
195-
links: &opentelemetry_sdk::trace::EvictedQueue<opentelemetry::trace::Link>,
196-
) -> gspan::Links {
192+
fn convert_links(links: &opentelemetry_sdk::trace::SpanLinks) -> gspan::Links {
197193
const MAX_LINKS: usize = 128;
198194

199195
gspan::Links {
@@ -203,9 +199,9 @@ impl GcpCloudTraceExporterClient {
203199
.map(Self::convert_link)
204200
.collect(),
205201
dropped_links_count: if links.len() > MAX_LINKS {
206-
(links.dropped_count() as usize + links.len() - MAX_LINKS) as i32
202+
(links.dropped_count as usize + links.len() - MAX_LINKS) as i32
207203
} else {
208-
links.dropped_count() as i32
204+
links.dropped_count as i32
209205
},
210206
..gspan::Links::default()
211207
}

0 commit comments

Comments
 (0)