Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second arguement as date #4

Open
aashutoshrathi opened this issue Jun 1, 2018 · 6 comments
Open

Add second arguement as date #4

aashutoshrathi opened this issue Jun 1, 2018 · 6 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@aashutoshrathi
Copy link
Owner

No description provided.

@aashutoshrathi aashutoshrathi added the enhancement New feature or request label Jun 1, 2018
@silveiraluiza
Copy link

Can you give more details on this?

@aashutoshrathi
Copy link
Owner Author

Like org, add an argument after --date, which will filter the events.

@anarute
Copy link
Contributor

anarute commented Oct 6, 2018

Working on this

anarute added a commit to anarute/git-stalk-cli that referenced this issue Oct 6, 2018
@anarute
Add --date argument - closes aashutoshrathi#4
c645d13 
If `--date` argument is passed, the script will filter from all
events the ones that were created in the selected date.

If no --date argument is passes, only today events are showned.

Also add a pagination logic to fecth all results from Github API.
anarute added a commit to anarute/git-stalk-cli that referenced this issue Oct 6, 2018
@anarute
Add --date argument - closes aashutoshrathi#4
0453a86 
If `--date` argument is passed, the script will filter from all
events the ones that were created in the selected date.

If no --date argument is passes, only today events are shown.

Also add a pagination logic to fetch all results from Github API.
@aashutoshrathi
Copy link
Owner Author

Check all features before adding more, we have until and from already

@anarute
Copy link
Contributor

anarute commented Oct 6, 2018

@aashutoshrathi I'm sorry, I started from master branch, I checked all features and I see no until and from arguments. Are they upstream already?
Also, I just started because the issue was opened. It should be closed, then.

@anarute
Copy link
Contributor

anarute commented Oct 6, 2018

Btw, I also added a for loop to fetch all pages from the Github API. The way it's done currently only fetches the first page, do you want me to close this one and send a new pull request with only that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anarute @silveiraluiza @aashutoshrathi