fix issues after backport in 2.11

Signed-off-by: Xun Zhang <xunzh@amazon.com>

Author: Zhangxunmt

ml-algorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java

@@ -34,7 +34,7 @@ public void test_validateIp_validIp_noException() throws UnknownHostException {
     @Test
     public void test_validateIp_invalidIp_throwException() throws UnknownHostException {
         expectedException.expect(UnknownHostException.class);
-        MLHttpClientFactory.validateIp("www.zaniu.com");
+        MLHttpClientFactory.validateIp("www.zanniu.com");
     }
 
     @Test

plugin/src/main/java/org/opensearch/ml/breaker/MemoryCircuitBreaker.java

@@ -20,7 +20,6 @@ public class MemoryCircuitBreaker extends ThresholdCircuitBreaker<Short> {
     public static final short DEFAULT_JVM_HEAP_USAGE_THRESHOLD = 85;
     public static final short JVM_HEAP_MAX_THRESHOLD = 100; // when threshold is 100, this CB check is ignored
     private final JvmService jvmService;
-    private volatile Integer jvmHeapMemThreshold = 85;
 
     public MemoryCircuitBreaker(JvmService jvmService) {
         super(DEFAULT_JVM_HEAP_USAGE_THRESHOLD);
@@ -35,8 +34,9 @@ public MemoryCircuitBreaker(short threshold, JvmService jvmService) {
     public MemoryCircuitBreaker(Settings settings, ClusterService clusterService, JvmService jvmService) {
         super(DEFAULT_JVM_HEAP_USAGE_THRESHOLD);
         this.jvmService = jvmService;
-        this.jvmHeapMemThreshold = ML_COMMONS_JVM_HEAP_MEM_THRESHOLD.get(settings);
-        clusterService.getClusterSettings().addSettingsUpdateConsumer(ML_COMMONS_JVM_HEAP_MEM_THRESHOLD, it -> jvmHeapMemThreshold = it);
+        clusterService
+            .getClusterSettings()
+            .addSettingsUpdateConsumer(ML_COMMONS_JVM_HEAP_MEM_THRESHOLD, it -> super.setThreshold(it.shortValue()));
     }
 
     @Override

plugin/src/main/java/org/opensearch/ml/breaker/ThresholdCircuitBreaker.java

@@ -5,10 +5,13 @@
 
 package org.opensearch.ml.breaker;
 
+import lombok.Data;
+
 /**
  * An abstract class for all breakers with threshold.
  * @param <T> data type of threshold
  */
+@Data
 public abstract class ThresholdCircuitBreaker<T> implements CircuitBreaker {
 
     private T threshold;
@@ -17,10 +20,6 @@ public ThresholdCircuitBreaker(T threshold) {
         this.threshold = threshold;
     }
 
-    public T getThreshold() {
-        return threshold;
-    }
-
     @Override
     public abstract boolean isOpen();
 }