Skip to content

Commit b4f47f8

Browse files
committed
Fix vmware_guest idempotency when using dvswitch (fixes ansible-collections#498)
1 parent 322f0c2 commit b4f47f8

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
minor_changes:
2+
- vmware_guest - Fix vmware_guest always reporting change when using dvswitch.
3+
(https://github.com/ansible-collections/community.vmware/pull/2000).

plugins/modules/vmware_guest.py

+9-2
Original file line numberDiff line numberDiff line change
@@ -1951,8 +1951,15 @@ def configure_network(self, vm_obj):
19511951
nic_change_detected = True
19521952

19531953
if nic.device.deviceInfo.summary != network_name:
1954-
nic.device.deviceInfo.summary = network_name
1955-
nic_change_detected = True
1954+
if 'DVSwitch' not in nic.device.deviceInfo.summary:
1955+
nic.device.deviceInfo.summary = network_name
1956+
nic_change_detected = True
1957+
else:
1958+
pg = find_obj(self.content, [vim.DistributedVirtualPortgroup], network_name)
1959+
if pg is not None and nic.device.backing.port.portgroupKey != pg.key:
1960+
nic.device.deviceInfo.summary = network_name
1961+
nic_change_detected = True
1962+
19561963
if 'device_type' in network_devices[key]:
19571964
device = self.device_helper.nic_device_type.get(network_devices[key]['device_type'])
19581965
if not isinstance(nic.device, device):

0 commit comments

Comments
 (0)