Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The booking places information is not correclty overriden by config setting bookingplacesinfotexts #868

Open
2 tasks
georgmaisser opened this issue Mar 6, 2025 · 1 comment
Assignees

Comments

@georgmaisser
Copy link
Contributor

  • make sure override works as intended
  • make further setting to hide setting all together when places are unlimited
@georgmaisser
Copy link
Contributor Author

Explanation:

here ist the setting 'bookingplacesinfotexts'
https://10.111.0.2/admin/category.php?category=modbookingfolder

In the code, it's used in the booking_answers class in the method add_availability_info_texts_to_booking_information.

Apparently, this is not working correctly. as a student (not Admin!) we should see short texts about the booking status In combination with the setting "bookingplaceslowpercentage" below (instead of seeing 3 of 10 places left, we should see "only a few places left" or sth like that.

Check out why it's not behaving correctly. You need to purge caches a lot, changes might not appear right away. Use a student user in an incognito window.

Test if you can make it work at all. if not, make a breakpoint and look in the code step for step to see why it's not working.

ideally, fix functionality and write a unit test.

alabaer pushed a commit that referenced this issue Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants