Skip to content

Commit ebb027e

Browse files
committed
remove leftovers
1 parent ca6f897 commit ebb027e

File tree

4 files changed

+23
-34
lines changed

4 files changed

+23
-34
lines changed

src/cpp/CMakeLists.txt

+15-28
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ file(GLOB SOURCE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp")
4646

4747
set(TARGET_NAME genai)
4848
add_library(${TARGET_NAME} SHARED ${SOURCE_FILES})
49-
add_library(openvino::genai ALIAS genai)
49+
add_library(openvino::${TARGET_NAME} ALIAS ${TARGET_NAME})
5050

5151
target_include_directories(${TARGET_NAME}
5252
# TODO: remove it, because beam_search algo should not be exposed to end users
@@ -59,26 +59,15 @@ target_compile_definitions(${TARGET_NAME} PRIVATE OPENVINO_TOKENIZERS_PATH=\"$<T
5959

6060
target_compile_features(${TARGET_NAME} PUBLIC cxx_std_17)
6161

62-
install(TARGETS ${TARGET_NAME} LIBRARY DESTINATION . COMPONENT core_genai RUNTIME DESTINATION . COMPONENT core_genai)
63-
64-
# Populate python with the libraries to allow skipping wheel installation
65-
add_custom_command(TARGET genai POST_BUILD
62+
# Copy the library to python to allow skipping wheel installation
63+
add_custom_command(TARGET ${TARGET_NAME} POST_BUILD
6664
COMMAND "${CMAKE_COMMAND}" -E copy
67-
"$<TARGET_FILE:genai>"
68-
"${CMAKE_CURRENT_SOURCE_DIR}/../python/openvino_genai/$<TARGET_FILE_NAME:genai>"
69-
COMMENT "Copy genai to src/python/openvino_genai")
65+
"$<TARGET_FILE:${TARGET_NAME}>"
66+
"${CMAKE_CURRENT_SOURCE_DIR}/../python/openvino_genai/$<TARGET_FILE_NAME:${TARGET_NAME}>"
67+
COMMENT "Copy ${TARGET_NAME} to src/python/openvino_genai")
7068

71-
export(TARGETS genai NAMESPACE openvino:: FILE "${CMAKE_BINARY_DIR}/openvino_genaiConfig.cmake") # TODO: try to merge
7269
install(TARGETS ${TARGET_NAME} LIBRARY DESTINATION . COMPONENT core_genai RUNTIME DESTINATION . COMPONENT core_genai)
7370

74-
include(GenerateExportHeader)
75-
76-
generate_export_header(genai)
77-
# set_property(TARGET genai PROPERTY VERSION ${openvino_genai_VERSION})
78-
# set_property(TARGET genai PROPERTY SOVERSION 3)
79-
# set_property(TARGET genai PROPERTY INTERFACE_genai_MAJOR_VERSION 3)
80-
# set_property(TARGET genai APPEND PROPERTY COMPATIBLE_INTERFACE_STRING genai_MAJOR_VERSION)
81-
8271
string(TOLOWER "${CMAKE_SYSTEM_PROCESSOR}" ARCH_FOLDER)
8372
if(X86_64)
8473
set(ARCH_FOLDER intel64)
@@ -90,23 +79,21 @@ elseif((MSVC OR APPLE) AND AARCH64)
9079
set(ARCH_FOLDER arm64)
9180
elseif(UNIVERSAL2)
9281
set(ARCH_FOLDER universal2)
93-
elseif(ARCH_FOLDER STREQUAL "x86_64" OR ARCH_FOLDER STREQUAL "amd64" # Windows detects Intel's 64-bit CPU as AMD64
82+
elseif(ARCH_FOLDER STREQUAL "x86_64" OR ARCH_FOLDER STREQUAL "amd64" # Windows detects Intel's 64-bit CPU as AMD64
9483
OR CMAKE_OSX_ARCHITECTURES STREQUAL "x86_64")
9584
set(ARCH_FOLDER intel64)
9685
endif()
97-
install(TARGETS genai EXPORT openvino_genaiTargets
86+
install(TARGETS ${TARGET_NAME} EXPORT openvino_genaiTargets
9887
LIBRARY DESTINATION runtime/lib/${ARCH_FOLDER}/${CMAKE_BUILD_TYPE} COMPONENT core_genai_dev
9988
ARCHIVE DESTINATION runtime/lib/${ARCH_FOLDER}/${CMAKE_BUILD_TYPE} COMPONENT core_genai_dev
10089
RUNTIME DESTINATION runtime/bin/${ARCH_FOLDER}/${CMAKE_BUILD_TYPE} COMPONENT core_genai_dev
10190
INCLUDES DESTINATION runtime/include)
102-
install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/include/" DESTINATION runtime/include COMPONENT core_genai_dev)
103-
91+
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/ DESTINATION runtime/include COMPONENT core_genai_dev)
92+
install(EXPORT openvino_genaiTargets FILE openvino_genaiTargets.cmake NAMESPACE openvino:: DESTINATION runtime/cmake)
10493
include(CMakePackageConfigHelpers)
105-
write_basic_package_version_file("${CMAKE_BINARY_DIR}/openvino_genaiConfigVersion.cmake" VERSION ${openvino_genai_VERSION} COMPATIBILITY AnyNewerVersion)
106-
94+
configure_package_config_file(openvino_genaiConfig.cmake.in "${CMAKE_BINARY_DIR}/openvino_genaiConfig.cmake" INSTALL_DESTINATION runtime/cmake)
95+
install(FILES "${CMAKE_BINARY_DIR}/openvino_genaiConfig.cmake" "${CMAKE_BINARY_DIR}/openvino_genaiConfigVersion.cmake" DESTINATION runtime/cmake COMPONENT core_genai_dev)
96+
include(CMakePackageConfigHelpers)
97+
write_basic_package_version_file("${CMAKE_BINARY_DIR}/openvino_genaiConfigVersion.cmake" VERSION ${CMAKE_PROJECT_VERSION} COMPATIBILITY AnyNewerVersion)
10798
export(EXPORT openvino_genaiTargets FILE "${CMAKE_BINARY_DIR}/openvino_genaiTargets.cmake" NAMESPACE openvino::)
108-
configure_file(cmake/openvino_genaiConfig.cmake "${CMAKE_BINARY_DIR}/openvino_genaiConfig.cmake" COPYONLY)
109-
110-
install(EXPORT openvino_genaiTargets FILE openvino_genaiTargets.cmake NAMESPACE openvino:: DESTINATION runtime/cmake)
111-
install(FILES cmake/openvino_genaiConfig.cmake "${CMAKE_BINARY_DIR}/openvino_genaiConfigVersion.cmake"
112-
DESTINATION runtime/cmake COMPONENT core_genai_dev)
99+
# export(TARGETS ${TARGET_NAME} NAMESPACE openvino:: FILE "${CMAKE_BINARY_DIR}/openvino_genaiConfig.cmake") TODO
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
@PACKAGE_INIT@
2+
13
include(CMakeFindDependencyMacro)
24
find_dependency(OpenVINO COMPONENTS Runtime)
35

46
if(NOT TARGET genai)
57
include("${CMAKE_CURRENT_LIST_DIR}/openvino_genaiTargets.cmake")
68
endif()
9+
10+
check_required_components(openvino_genai)

src/python/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ if(rpaths)
3737
set_target_properties(py_generate_pipeline PROPERTIES INSTALL_RPATH "${rpaths}")
3838
endif()
3939

40-
# Populate python with the libraries to allow skipping wheel installation
40+
# Copy the library to python to allow skipping wheel installation
4141
add_custom_command(TARGET py_generate_pipeline POST_BUILD
4242
COMMAND "${CMAKE_COMMAND}" -E copy
4343
"$<TARGET_FILE:py_generate_pipeline>"

text_generation/causal_lm/cpp/CMakeLists.txt

+3-5
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ else()
1010
set(OPENVINO_TOKENIZERS_PATH ${CMAKE_CURRENT_SOURCE_DIR}/../../bin/openvino_tokenizers.dll) # TODO: I'll go away after the generate() gets a way to find openvino_tokenizers
1111
endif()
1212

13-
if(openvino_genai_SOURCE_DIR)
14-
set(openvino_genai_DIR "${CMAKE_BINARY_DIR}")
15-
endif()
16-
17-
find_package(openvino_genai REQUIRED)
13+
find_package(openvino_genai REQUIRED
14+
PATHS "${CMAKE_BINARY_DIR}" # Reuse the package from the build. The lowest priority.
15+
)
1816

1917
add_executable(greedy_causal_lm greedy_causal_lm.cpp)
2018
target_compile_definitions(greedy_causal_lm PRIVATE OPENVINO_TOKENIZERS_PATH="${OPENVINO_TOKENIZERS_PATH}")

0 commit comments

Comments
 (0)