mock-pop-mining: get rid of package-private members

Author: eu321

mock-pop-mining/src/main/java/org/veriblock/sdk/mock/AltChainPopMiner.java

@@ -44,7 +44,7 @@ public VeriBlockBlockchain getVeriBlockBlockchain() {
     }
 
     // retrieve the blocks between lastKnownBlock and getChainHead()
-    List<VeriBlockBlock> createVeriBlockContext(VeriBlockBlock lastKnownBlock) throws SQLException {
+    private List<VeriBlockBlock> createVeriBlockContext(VeriBlockBlock lastKnownBlock) throws SQLException {
         List<VeriBlockBlock> context = new ArrayList<>();
 
         VeriBlockBlock prevBlock = veriblockBlockchain.get(veriblockBlockchain.getChainHead().getPreviousBlock());
@@ -84,7 +84,7 @@ private Address deriveAddress(PublicKey key) {
         return new Address(data + checksum);
     }
 
-    AltPublication mine(PublicationData publicationData, VeriBlockBlock lastKnownVBKBlock, KeyPair key) throws SQLException, SignatureException, InvalidKeyException, NoSuchAlgorithmException {
+    public AltPublication mine(PublicationData publicationData, VeriBlockBlock lastKnownVBKBlock, KeyPair key) throws SQLException, SignatureException, InvalidKeyException, NoSuchAlgorithmException {
 
         Address address = deriveAddress(key.getPublic());
 

mock-pop-mining/src/main/java/org/veriblock/sdk/mock/BitcoinBlockchain.java

@@ -24,7 +24,7 @@
 public class BitcoinBlockchain extends org.veriblock.sdk.blockchain.BitcoinBlockchain {
     private final Map<Sha256Hash, BitcoinBlockData> blockDataStore = new HashMap<>();
 
-    BitcoinBlockchain(BitcoinNetworkParameters networkParameters,
+    public BitcoinBlockchain(BitcoinNetworkParameters networkParameters,
                       BlockStore<StoredBitcoinBlock, Sha256Hash> store) {
         super(networkParameters, store);
     }

mock-pop-mining/src/main/java/org/veriblock/sdk/mock/VeriBlockBlockData.java

@@ -77,10 +77,10 @@ public Sha256Hash getSubject(int index) {
         }
     }
 
-    RegularSubtree txs = new RegularSubtree();
-    PoPSubtree popTxs = new PoPSubtree();
+    private RegularSubtree txs = new RegularSubtree();
+    private PoPSubtree popTxs = new PoPSubtree();
 
-    byte[] blockContentMetapackage = new byte[0];
+    private byte[] blockContentMetapackage = new byte[0];
 
     public Sha256Hash getMerkleRoot() {
         return Sha256Hash.of(

mock-pop-mining/src/main/java/org/veriblock/sdk/mock/VeriBlockBlockchain.java

@@ -30,7 +30,7 @@ public class VeriBlockBlockchain extends org.veriblock.sdk.blockchain.VeriBlockB
     private final Map<VBlakeHash, VeriBlockBlockData> blockDataStore = new HashMap<>();
     private final BlockStore<StoredVeriBlockBlock, VBlakeHash> store;
 
-    VeriBlockBlockchain(VeriBlockNetworkParameters networkParameters,
+    public VeriBlockBlockchain(VeriBlockNetworkParameters networkParameters,
                         BlockStore<StoredVeriBlockBlock, VBlakeHash> store,
                         BlockStore<StoredBitcoinBlock, Sha256Hash> bitcoinStore) {
         super(networkParameters, store, bitcoinStore);

mock-pop-mining/src/main/java/org/veriblock/sdk/mock/VeriBlockPopMiner.java

@@ -61,13 +61,13 @@ private byte[] createPublicationData(VeriBlockBlock publishedBlock, Address addr
         return payoutInfo;
     }
 
-    BitcoinTransaction createBitcoinTx(VeriBlockBlock publishedBlock, Address address) {
+    private BitcoinTransaction createBitcoinTx(VeriBlockBlock publishedBlock, Address address) {
         byte[] publicationData = createPublicationData(publishedBlock, address);
         return new BitcoinTransaction(publicationData);
     }
 
     // retrieve the blocks between lastKnownBlock and getChainHead()
-    List<BitcoinBlock> createBitcoinContext(BitcoinBlock lastKnownBlock) throws SQLException {
+    private List<BitcoinBlock> createBitcoinContext(BitcoinBlock lastKnownBlock) throws SQLException {
         List<BitcoinBlock> context = new ArrayList<>();
 
         BitcoinBlock prevBlock = bitcoinBlockchain.get(bitcoinBlockchain.getChainHead().getPreviousBlock());
@@ -81,7 +81,7 @@ List<BitcoinBlock> createBitcoinContext(BitcoinBlock lastKnownBlock) throws SQLE
     }
 
     // retrieve the blocks between lastKnownBlock and getChainHead()
-    List<VeriBlockBlock> createVeriBlockContext(VeriBlockBlock lastKnownBlock) throws SQLException {
+    private List<VeriBlockBlock> createVeriBlockContext(VeriBlockBlock lastKnownBlock) throws SQLException {
         List<VeriBlockBlock> context = new ArrayList<>();
 
         VeriBlockBlock prevBlock = veriblockBlockchain.get(veriblockBlockchain.getChainHead().getPreviousBlock());
@@ -94,7 +94,7 @@ List<VeriBlockBlock> createVeriBlockContext(VeriBlockBlock lastKnownBlock) throw
         return context;
     }
 
-    Address deriveAddress(PublicKey key) {
+    private Address deriveAddress(PublicKey key) {
         String data = "V" + Base58.encode(Sha256Hash.of(key.getEncoded()).getBytes()).substring(0, 24);
 
         Sha256Hash hash = Sha256Hash.of(data.getBytes(StandardCharsets.UTF_8));
@@ -104,7 +104,7 @@ Address deriveAddress(PublicKey key) {
 
     }
 
-    VeriBlockPoPTransaction signTransaction(VeriBlockPoPTransaction tx, PrivateKey privateKey) throws SignatureException, InvalidKeyException, NoSuchAlgorithmException {        
+    private VeriBlockPoPTransaction signTransaction(VeriBlockPoPTransaction tx, PrivateKey privateKey) throws SignatureException, InvalidKeyException, NoSuchAlgorithmException {        
         byte[] signature = Utils.signMessageWithPrivateKey(SerializeDeserializeService.getId(tx).getBytes(),
                                                            privateKey);