Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache Common Lang3 Module should not be included in ValkyrienSkies => Compatibility Issue Source Found #617

Closed
FirstMegaGame4 opened this issue Nov 3, 2023 · 4 comments
Closed

Apache Common Lang3 Module should not be included in ValkyrienSkies => Compatibility Issue Source Found #617

FirstMegaGame4 opened this issue Nov 3, 2023 · 4 comments

Comments

@FirstMegaGame4
Copy link

FirstMegaGame4 commented Nov 3, 2023 •
edited
Loading

Hello Valkyrien Skies developers!

I got the same issue as bv7dev and after some deep research on the Quilt Discord Server, we found that the issue is coming from the ArrayUtils class in a old apache-common-lang3 module that is packed into ValkyrienSkies! This weird ArrayUtils class replaces the classic one, causing crash with CompleteConfig that uses the class. (CompleteConfig is used by RegionsUnexploredFabric).

There is actually a workaround to fix it, we can just remove the apache-common-lang3 package in the mod jar, but you should remove it directly from the mod source.
@Snownee
Copy link

Snownee commented Jan 21, 2024 •
edited
Loading

Any progress on this issue? This also causes a crash with Kiwi

@FirstMegaGame4
Copy link
Author

FirstMegaGame4 commented Jan 21, 2024 •
edited
Loading

Any progress on this issue? This also causes a crash with Kiwi

wait ValkyrienSkies is also doing that weird thing on NeoForge / LexForge?

@Snownee
Copy link

Snownee commented Jan 21, 2024

Any progress on this issue? This also causes a crash with Kiwi

wait ValkyrienSkies is also doing that weird thing on NeoForge / LexForge?

Wrong link, sorry. It was Kiwi for Fabric. Fixed now

@Snownee Snownee mentioned this issue Jan 24, 2024
Closed
1 task
fionera added a commit to fionera/Valkyrien-Skies-2 that referenced this issue Apr 2, 2024
@fionera
Prevent shading of commons-lang3
0da8861 
commons-lang3 is always provided at runtime,
don't shade it to prevent incompatibilities.

Closes ValkyrienSkies#617, ValkyrienSkies#616
@fionera fionera mentioned this issue Apr 2, 2024
Merged
ewoudje pushed a commit that referenced this issue May 3, 2024
@fionera
Prevent shading of commons-lang3 (#798)
682a6e8 
commons-lang3 is always provided at runtime,
don't shade it to prevent incompatibilities.

Closes #617, #616
@Poopooracoocoo Poopooracoocoo mentioned this issue May 11, 2024
Closed
@FirstMegaGame4
Copy link
Author

Closed in #798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Snownee @FirstMegaGame4