Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit / Svelte 5 ??????? #77

Open
yongrenjie opened this issue Feb 23, 2024 · 0 comments
Open

SvelteKit / Svelte 5 ??????? #77

yongrenjie opened this issue Feb 23, 2024 · 0 comments

Comments

@yongrenjie
Copy link
Contributor

yongrenjie commented Feb 23, 2024

i think demoland-web has grown beyond what we originally envisioned it would be a year ago, and it might make sense to upgrade the tech stack a little bit. In particular SvelteKit represents the easiest 'upgrade path' because the entirety of the components can essentially be reused (although we might have to fiddle with imports)

Pros:

  • (SvelteKit) cleaner management of multiple areas. Right now we are essentially building a different site for each area and then sticking thte files together, which is quite ugly, and also doesn't aid discoverability (if you're on tyne_and_wear, you can't get to isle_of_wight easily). Also this leads to a lot of duplication of static assets (e.g. the demoland-engine wheel) in the built files because the same wheel is being bundled with every area.
  • (Svelte 5) hopefully cleaner state management, especially in custom scenario creation UI

Cons:

  • no HMR in Svelte 5 (yet). This isn't a huge deal for me because website loading is quite fast. also, testing custom scenario stuff has often required a hard refresh anyway.
  • I don't have time to do this for another month 😅
@yongrenjie yongrenjie changed the title Svelte 5 ??????? SvelteKit / Svelte 5 ??????? Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant