Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some evaluated locations are not found #92

Open
Tritlo opened this issue Aug 12, 2021 · 2 comments
Open

Some evaluated locations are not found #92

Tritlo opened this issue Aug 12, 2021 · 2 comments
Labels
Enhancement New feature or request

Comments

@Tritlo
Copy link
Owner

Tritlo commented Aug 12, 2021

It can sometimes happen that something that was evaluated is not found in the traceCorrel. We should investigate.
@Tritlo
Copy link
Owner Author

Tritlo commented Aug 13, 2021

This is weird: a lot of locations are showing up as evaluated in the invokes in findEvaluatedHoles, but we're missing out on these locations due to them not being in the trace-correlation. One good example is cherry-pie/lab05/entry009 with random search: we find no fixes!

Tritlo added a commit that referenced this issue Aug 13, 2021
@Tritlo
[Tests] Add test for issue #92
b28331d
Tritlo added a commit that referenced this issue Aug 13, 2021
@Tritlo
[Minor] Trace correlations now parsed from trace module. Fixes #92
375e6aa
@Tritlo
Copy link
Owner Author

Tritlo commented Aug 13, 2021 •
edited
Loading

Sadly, #95 doesn't quite cut it: we don't actually get precedence information until after renaming, so we can't find locations that are "parenthesized" by precedence. See the note on the toExprHole function for more details.

@Tritlo Tritlo closed this as completed in 9fe95b1 Aug 14, 2021
@Tritlo Tritlo reopened this Aug 14, 2021
@Tritlo Tritlo added the Enhancement New feature or request label Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tritlo