Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] major changes between https://github.com/TorchDSP/torchsig/tree/v0.6.1/examples and https://github.com/TorchDSP/torchsig/tree/v1.0.0-beta/examples #285

Open
agm-eratosth opened this issue Feb 21, 2025 · 1 comment
Labels
type: bug Something isn't working

Comments

@agm-eratosth
Copy link

Version

1.0.0 (Default)

System Information

No response

Description

Not sure if this was intended, seems significantly different and likely something older was pulled in.

How to Reproduce the Bug

Compare
https://github.com/TorchDSP/torchsig/tree/v0.6.1/examples
https://github.com/TorchDSP/torchsig/tree/v1.0.0-beta/examples

@agm-eratosth agm-eratosth added the type: bug Something isn't working label Feb 21, 2025
@MattCarrickPL
Copy link
Collaborator

Are you seeing errors when running the notebooks or just concerned about the changes? With 1.0 we did a huge rewrite of the code and as such the notebooks also changed significantly. We have not yet recreated all of them that were in 0.6.1 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants