From 26252d4588883a66dbb477edf6df6aca69c4b567 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Sun, 30 Dec 2018 12:45:05 -0500
Subject: [PATCH 01/29] interim checkin

replacing the time.cc file with

- time_napi.cc
- time_napi.h

files

also using the object wrapper methodology from the workshop at Node Summit.
---
 binding.gyp      | 38 ++++++++++-----------------
 package.json     | 11 +++++---
 src/time_napi.cc | 67 ++++++++++++++++++++++++++++++++++++++++++++++++
 src/time_napi.h  | 19 ++++++++++++++
 4 files changed, 108 insertions(+), 27 deletions(-)
 create mode 100644 src/time_napi.cc
 create mode 100644 src/time_napi.h

diff --git a/binding.gyp b/binding.gyp
index 0b42e4b..b0c88dc 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -2,29 +2,19 @@
   'targets': [
     {
       'target_name': 'time',
-      'include_dirs': [
-        '<!(node -e "require(\'nan\')")'
-      ],
-      'sources': [ 'src/time.cc' ],
-      'conditions': [
-        ['OS=="mac"', {
-          'defines': [
-            '__DARWIN_UNIX03', # For char* timezone
-            'HAVE_TM_GMTOFF'
-          ]
-        }],
-        ['OS=="linux"', {
-          'defines': [
-            'HAVE_TM_GMTOFF'
-          ]
-        }],
-        ['OS=="solaris"', {
-          'defines': [
-            'HAVE_ALTZONE',
-            'HAVE_TIMEZONE'
-          ]
-        }]
-      ]
+      'sources': [ 'src/time_napi.cc' ],
+      'include_dirs': ["<!@(node -p \"require('node-addon-api').include\")"],
+      'dependencies': ["<!(node -p \"require('node-addon-api').gyp\")"],
+      'cflags!': [ '-fno-exceptions' ],
+      'cflags_cc!': [ '-fno-exceptions' ],
+      'xcode_settings': {
+        'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
+        'CLANG_CXX_LIBRARY': 'libc++',
+        'MACOSX_DEPLOYMENT_TARGET': '10.7'
+      },
+      'msvs_settings': {
+        'VCCLCompilerTool': { 'ExceptionHandling': 1 },
+      }
     }
   ]
-}
+}
\ No newline at end of file
diff --git a/package.json b/package.json
index 7cb5fd9..879eede 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
     "setTimezone",
     "getTimezone"
   ],
-  "version": "0.12.0",
+  "version": "0.2.0",
   "repository": {
     "type": "git",
     "url": "git://github.com/TooTallNate/node-time.git"
@@ -20,6 +20,10 @@
     {
       "name": "Diogo Resende",
       "email": "dresende@thinkdigital.pt"
+    },
+    {
+      "name": "Glenn Hinks",
+      "email": "ghinks@yahoo.com"
     }
   ],
   "main": "./index.js",
@@ -29,9 +33,10 @@
   "dependencies": {
     "bindings": "^1.2.0",
     "debug": "^2.2.0",
-    "nan": "^2.2.0"
+    "node-addon-api": "^1.6.2"
   },
   "devDependencies": {
     "mocha": "*"
-  }
+  },
+  "gypfile": true
 }
diff --git a/src/time_napi.cc b/src/time_napi.cc
new file mode 100644
index 0000000..086884e
--- /dev/null
+++ b/src/time_napi.cc
@@ -0,0 +1,67 @@
+#include <napi.h>
+#include "time_napi.h"
+
+Napi::FunctionReference Time::constructor;
+
+Napi::Object Time::Init(Napi::Env env, Napi::Object exports) {
+    Napi::HandleScope scope(env);
+
+    Napi::Function func = DefineClass(env, "Time", {
+            InstanceMethod("time", &Time::time),
+            InstanceMethod("tzset", &Time::tzset),
+            InstanceMethod("localtime", &Time::localtime),
+            InstanceMethod("mktime", &Time::mktime),
+    });
+
+    constructor = Napi::Persistent(func);
+    constructor.SuppressDestruct();
+
+    exports.Set("Time", func);
+    return exports;
+}
+
+Time::Time(const Napi::CallbackInfo& info) : Napi::ObjectWrap<Time>(info)  {
+    Napi::Env env = info.Env();
+    Napi::HandleScope scope(env);
+}
+
+Napi::Value Time::time(const Napi::CallbackInfo& info) {
+    return Napi::String::New(info.Env(), "hello world");
+}
+
+Napi::Value Time::tzset(const Napi::CallbackInfo& info) {
+    return Napi::String::New(info.Env(), "hello world");
+}
+
+Napi::Value Time::localtime(const Napi::CallbackInfo& info) {
+    return Napi::String::New(info.Env(), "hello world");
+}
+
+Napi::Value Time::mktime(const Napi::CallbackInfo& info) {
+    return Napi::String::New(info.Env(), "hello world");
+}
+
+Napi::Object InitAll(Napi::Env env, Napi::Object exports) {
+    return Time::Init(env, exports);
+}
+
+NODE_API_MODULE(addon, InitAll)
+
+/*Napi::String Method(const Napi::CallbackInfo& info) {
+    Napi::Env env = info.Env();
+    return Napi::String::New(env, "world");
+}
+
+Napi::Object Init(Napi::Env env, Napi::Object exports) {
+    exports.Set(Napi::String::New(env, "time"),
+                Napi::Function::New(env, Method));
+    exports.Set(Napi::String::New(env, "tzset"),
+                Napi::Function::New(env, Method));
+    exports.Set(Napi::String::New(env, "localtime"),
+                Napi::Function::New(env, Method));
+    exports.Set(Napi::String::New(env, "mktime"),
+                Napi::Function::New(env, Method));
+    return exports;
+}
+
+NODE_API_MODULE(hello, Init)*/
diff --git a/src/time_napi.h b/src/time_napi.h
new file mode 100644
index 0000000..13fbe12
--- /dev/null
+++ b/src/time_napi.h
@@ -0,0 +1,19 @@
+//
+// Created by Glenn Hinks on 12/30/18.
+//
+
+#ifndef NODE_TIME_TIME_NAPI_H
+#define NODE_TIME_TIME_NAPI_H
+class Time : public Napi::ObjectWrap<Time> {
+public:
+    static Napi::Object Init(Napi::Env env, Napi::Object exports);
+    Time(const Napi::CallbackInfo& info);
+private:
+    static Napi::FunctionReference constructor;
+
+    Napi::Value time(const Napi::CallbackInfo& info);
+    Napi::Value tzset(const Napi::CallbackInfo& info);
+    Napi::Value localtime(const Napi::CallbackInfo& info);
+    Napi::Value mktime(const Napi::CallbackInfo& info);
+};
+#endif //NODE_TIME_TIME_NAPI_H

From 4acee45f81f02b9a8d49d9888d8f2e08d0d8e3c0 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 16:42:50 -0500
Subject: [PATCH 02/29] partial working code with the napi somewhat working in
 place of the nan.

---
 index.js         |  25 ++++++--
 src/time.cc      |   2 +
 src/time_napi.cc | 147 ++++++++++++++++++++++++++++++++++++++---------
 test/date.js     |  15 ++---
 4 files changed, 149 insertions(+), 40 deletions(-)

diff --git a/index.js b/index.js
index da12ef0..d0af571 100644
--- a/index.js
+++ b/index.js
@@ -5,12 +5,15 @@
 var debug = require('debug')('time')
   , fs = require('fs')
   , path = require('path')
-  , bindings = require('bindings')('time.node')
+  // , bindings = require('bindings')('time')
   , MILLIS_PER_SECOND = 1000
   , DAYS_OF_WEEK = ['Sunday','Monday','Tuesday','Wednesday','Thursday','Friday','Saturday']
   , MONTHS = ['January','February','March','April','May','June','July','August','September','October','November','December']
   , TZ_BLACKLIST = [ 'SystemV', 'Etc' ];
 
+var time =  require('bindings')('time');
+// ok, it has no state
+var bindings = new time.Time();
 /**
  * Extends a "Date" constructor with node-time's extensions.
  * By default, `time.Date` is extended with this function.
@@ -38,9 +41,18 @@ exports.currentTimezone = process.env.TZ;
  * Export the raw functions from the bindings.
  */
 
-exports.time = bindings.time;
-exports.localtime = bindings.localtime;
-exports.mktime = bindings.mktime;
+exports.time = () => {
+  debug("local time call in js to time")
+  return bindings.time();
+}
+exports.localtime = (t) => {
+  debug('localtime binding in js')
+  return bindings.localtime(t);
+}
+exports.mktime = (o) => {
+  debug('local mktime binding in js calling with %s', JSON.stringify(o,null, 2))
+  return bindings.mktime(o);
+}
 
 /**
  * A "hack" of sorts to force getting our own Date instance.
@@ -263,7 +275,8 @@ function setTimezone (timezone, relative) {
   }
 
   // Get the zoneinfo for this Date instance's time value
-  var zoneInfo = exports.localtime(this.getTime() / 1000);
+  var myTime = this.getTime() / 1000;
+  var zoneInfo = exports.localtime(myTime);
 
   // Change the timezone back if we changed it originally
   if (oldTz != timezone) {
@@ -521,6 +534,7 @@ function setTimezone (timezone, relative) {
   }
   // 'mktime' calls 'reset' implicitly through 'setTime()'
   function mktime () {
+    debug("mktime js side");
     var oldTz = process.env.TZ;
     exports.tzset(this.getTimezone());
     zoneInfo.isDaylightSavings = -1; // Auto-detect the timezone
@@ -555,6 +569,7 @@ function getTimezoneAbbr () {
 // argument, in order to specify the initial timezone the Date instance should
 // be created with.
 function Date (year, month, day, hour, minute, second, millisecond, timezone) {
+  debug("Date JS side")
   if (!(this instanceof Date)) {
     return new Date(year, month, day, hour, minute, second, millisecond, timezone).toString();
   }
diff --git a/src/time.cc b/src/time.cc
index 8f11acc..3b4f4bb 100644
--- a/src/time.cc
+++ b/src/time.cc
@@ -55,6 +55,8 @@ class Time {
 
 	// The 'timezone' long is the "seconds West of UTC"
 	long timezone;
+	// MS C++ specific
+	// https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-timezone?view=vs-2017
 	_get_timezone(&timezone);
 	Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::Number>(timezone));
 
diff --git a/src/time_napi.cc b/src/time_napi.cc
index 086884e..2c3595c 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -1,9 +1,12 @@
 #include <napi.h>
 #include "time_napi.h"
+#include <time.h>
+#include <iostream>
 
 Napi::FunctionReference Time::constructor;
 
 Napi::Object Time::Init(Napi::Env env, Napi::Object exports) {
+    std::cout << "================= native init ========================" << std::endl;
     Napi::HandleScope scope(env);
 
     Napi::Function func = DefineClass(env, "Time", {
@@ -20,48 +23,136 @@ Napi::Object Time::Init(Napi::Env env, Napi::Object exports) {
     return exports;
 }
 
-Time::Time(const Napi::CallbackInfo& info) : Napi::ObjectWrap<Time>(info)  {
+Time::Time(const Napi::CallbackInfo &info) : Napi::ObjectWrap<Time>(info) {
+    std::cout << "================= native ctor ========================" << std::endl;
     Napi::Env env = info.Env();
     Napi::HandleScope scope(env);
 }
 
-Napi::Value Time::time(const Napi::CallbackInfo& info) {
-    return Napi::String::New(info.Env(), "hello world");
+Napi::Value Time::time(const Napi::CallbackInfo &info) {
+    std::cout << "================= native time ========================" << std::endl;
+    return Napi::String::New(info.Env(), "hello world 1");
 }
 
-Napi::Value Time::tzset(const Napi::CallbackInfo& info) {
-    return Napi::String::New(info.Env(), "hello world");
-}
+// MSVC++ 14.0  _MSC_VER == 1900 (Visual Studio 2015 version 14.0)
 
-Napi::Value Time::localtime(const Napi::CallbackInfo& info) {
-    return Napi::String::New(info.Env(), "hello world");
-}
+Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
+    std::cout << "================= native tzset ========================" << std::endl;
+    // Nan::EscapableHandleScope scope;
+    // Napi::EscapableHandleScope scope = Napi::EscapableHandleScope::New(info.Env());
+    // Set up the timezone info from the current TZ environ variable
+    // tzset(); this really looks odd calling it twice ?
 
-Napi::Value Time::mktime(const Napi::CallbackInfo& info) {
-    return Napi::String::New(info.Env(), "hello world");
-}
+    // Set up a return object that will hold the results of the timezone change
+    // Local<Object> obj = Nan::New<v8::Object>();
+    Napi::Object obj = Napi::Object::New(info.Env());
 
-Napi::Object InitAll(Napi::Env env, Napi::Object exports) {
-    return Time::Init(env, exports);
+    // The 'tzname' char * [] gets put into a JS Array
+    size_t tznameLength = 2;
+    // Local<Array> tznameArray = Nan::New<v8::Array>( tznameLength );
+    Napi::Array tznameArray = Napi::Array::New(info.Env(), tznameLength);
+    for (size_t i = 0; i < tznameLength; i++) {
+        // Nan::Set(tznameArray, i, Nan::New<v8::String>(tzname[i]).ToLocalChecked());
+        std::cout << "time zone name from ? " << i << " " << tzname[i] << std::endl;
+        // tzname is from environment variable TZ
+        // http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
+        tznameArray[i] = Napi::String::New(info.Env(), tzname[i]);
+    }
+
+    // Nan::Set(obj, Nan::New("tzname").ToLocalChecked(), tznameArray);
+    obj.Set("tzname", tznameArray);
+
+    // The 'timezone' long is the "seconds West of UTC"
+    // Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::Number>( timezone ));
+    obj.Set("timezone", timezone);
+
+    // The 'daylight' int is obselete actually, but I'll include it here for
+    // curiosity's sake. See the "Notes" section of "man tzset"
+    //Nan::Set(obj, Nan::New("daylight").ToLocalChecked(), Nan::New<v8::Number>( daylight ));
+    obj.Set("daylight", daylight);
+
+    // info.GetReturnValue().Set(scope.Escape(obj));
+
+    obj.Set("funkyChicken", "the funky chicken");
+
+    return obj;
 }
 
-NODE_API_MODULE(addon, InitAll)
+Napi::Value Time::localtime(const Napi::CallbackInfo &info) {
+    std::cout << "================= native localtime ========================"
+    << info.Length()
+    << std::endl;
+    Napi::Env env = info.Env();
+    // Nan::EscapableHandleScope scope;
+
+    // Construct the 'tm' struct
+    // time_t rawtime = static_cast<time_t>(info[0]->IntegerValue());
+    // struct tm *timeinfo = localtime(&rawtime);
+
+    if (info.Length() < 1) {
+         Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
+            return env.Null();
+    }
 
-/*Napi::String Method(const Napi::CallbackInfo& info) {
+    if (!info[0].IsNumber() ) {
+        Napi::TypeError::New(env, "Wrong arguments").ThrowAsJavaScriptException();
+        return env.Null();
+    }
+
+    time_t rawtime = static_cast<time_t>(info[0].As<Napi::Number>().Int64Value());
+    struct tm *timeinfo = ::localtime(&rawtime);
+    // Create the return "Object"
+    // Local <Object> obj = Nan::New<v8::Object>();
+    Napi::Object obj = Napi::Object::New(env);
+
+    if (timeinfo) {
+        obj.Set("seconds", timeinfo->tm_sec);
+        obj.Set("minutes", timeinfo->tm_min);
+        obj.Set("hours", timeinfo->tm_hour);
+        obj.Set("dayOfMonth", timeinfo->tm_mday);
+        obj.Set("month", timeinfo->tm_mon);
+        obj.Set("year", timeinfo->tm_year);
+        obj.Set("dayOfWeek", timeinfo->tm_wday);
+        obj.Set("dayOfYear", timeinfo->tm_yday);
+        obj.Set("isDaylightSavings", (timeinfo->tm_isdst > 0));
+    }
+    return obj;
+}
+
+Napi::Value Time::mktime(const Napi::CallbackInfo &info) {
+    std::cout << "================= native mktime ========================" << std::endl;
     Napi::Env env = info.Env();
-    return Napi::String::New(env, "world");
+    if (info.Length() < 1) {
+         Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
+            return env.Null();
+    }
+    std::cout << "================= args count checked ========================" << std::endl;
+    if (!info[0].IsObject() ) {
+        Napi::TypeError::New(env, "Wrong arguments").ThrowAsJavaScriptException();
+        return env.Null();
+    }
+    std::cout << "================= arg value is an object ========================" << std::endl;
+    Napi::Object obj = info[0].As<Napi::Object>();
+    std::cout << "================= tm struct manipulate ========================" << std::endl;
+    struct tm tmstr;
+    tmstr.tm_sec = obj.Get("seconds").As<Napi::Number>().Uint32Value();
+    tmstr.tm_min = obj.Get("minutes").As<Napi::Number>().Uint32Value();
+    tmstr.tm_hour = obj.Get("hours").As<Napi::Number>().Uint32Value();
+    tmstr.tm_mday = obj.Get("dayOfMonth").As<Napi::Number>().Uint32Value();
+    tmstr.tm_mon = obj.Get("month").As<Napi::Number>().Uint32Value();
+    tmstr.tm_year = obj.Get("year").As<Napi::Number>().Uint32Value();
+    tmstr.tm_isdst = obj.Get("isDaylightSavings").As<Napi::Number>().Uint32Value();
+    std::cout << "================= tm struct manipulated ========================" << std::endl;
+    std::cout << "tm_mday=" << tmstr.tm_mday << std::endl;
+    double myMakeTmVal = ::mktime(&tmstr);
+    std::cout << "myMakeTmVal = " << myMakeTmVal << std::endl;
+    Napi::Number myMakeTm = Napi::Number::New(env, myMakeTmVal);
+    return myMakeTm;
 }
 
-Napi::Object Init(Napi::Env env, Napi::Object exports) {
-    exports.Set(Napi::String::New(env, "time"),
-                Napi::Function::New(env, Method));
-    exports.Set(Napi::String::New(env, "tzset"),
-                Napi::Function::New(env, Method));
-    exports.Set(Napi::String::New(env, "localtime"),
-                Napi::Function::New(env, Method));
-    exports.Set(Napi::String::New(env, "mktime"),
-                Napi::Function::New(env, Method));
-    return exports;
+Napi::Object InitAll(Napi::Env env, Napi::Object exports) {
+    return Time::Init(env, exports);
 }
 
-NODE_API_MODULE(hello, Init)*/
+NODE_API_MODULE(time, InitAll)
+
diff --git a/test/date.js b/test/date.js
index 751406b..cee4e98 100644
--- a/test/date.js
+++ b/test/date.js
@@ -12,13 +12,14 @@ describe('Date', function () {
 
     it('should parse strings relative to TZ', function() {
 
-      var d = new time.Date('2012-1-12 02:00 PM', 'America/New_York')
-      assert.equal(d.getTime(), 1326394800000)
-      assert.equal(d.getTimezone(), 'America/New_York')
-
-      d = new time.Date('2012-1-12 02:00 PM', 'America/Los_Angeles')
-      assert.equal(d.getTime(), 1326405600000)
-      assert.equal(d.getTimezone(), 'America/Los_Angeles')
+      var d = new time.Date('2012-1-12 02:00 PM', 'America/New_York');
+/*      var t = d.getTime();
+      assert.equal(t, 1326394800000);
+      assert.equal(d.getTimezone(), 'America/New_York');
+
+      d = new time.Date('2012-1-12 02:00 PM', 'America/Los_Angeles');
+      assert.equal(d.getTime(), 1326405600000);
+      assert.equal(d.getTimezone(), 'America/Los_Angeles');*/
     })
 
     it('should interpret date parts relative to TZ', function() {

From 5f65bb68a22ca56abb5d7fd031aea468060fdae5 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 20:42:14 -0500
Subject: [PATCH 03/29] fixing unit tests, 1 outstanding unit test failing.

binding.gyp changed to handle the gmtOffset in localtime
---
 binding.gyp      | 23 +++++++++++++++++++++--
 index.js         |  9 ++++++++-
 src/time_napi.cc | 47 ++++++++++++++++++++++++++++++++++++-----------
 test/date.js     |  7 ++++---
 4 files changed, 69 insertions(+), 17 deletions(-)

diff --git a/binding.gyp b/binding.gyp
index b0c88dc..7593be6 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -14,7 +14,26 @@
       },
       'msvs_settings': {
         'VCCLCompilerTool': { 'ExceptionHandling': 1 },
-      }
+      },
+    'conditions': [
+      ['OS=="mac"', {
+        'defines': [
+          '__DARWIN_UNIX03', # For char* timezone
+          'HAVE_TM_GMTOFF'
+        ]
+      }],
+      ['OS=="linux"', {
+        'defines': [
+          'HAVE_TM_GMTOFF'
+        ]
+      }],
+      ['OS=="solaris"', {
+        'defines': [
+          'HAVE_ALTZONE',
+          'HAVE_TIMEZONE'
+        ]
+      }]
+    ]
     }
   ]
-}
\ No newline at end of file
+}
diff --git a/index.js b/index.js
index d0af571..f34c0ee 100644
--- a/index.js
+++ b/index.js
@@ -150,6 +150,7 @@ if (!exports.currentTimezone) {
   }
 }
 
+
 /**
  * The user-facing 'tzset' function is a thin wrapper around the native binding to
  * 'tzset()'. This function accepts a timezone String to set the process' timezone
@@ -328,7 +329,8 @@ function setTimezone (timezone, relative) {
   // Returns the timezone offset from GMT the Date instance currently is in,
   // in minutes. Also, left of GMT is positive, right of GMT is negative.
   this.getTimezoneOffset = function getTimezoneOffset() {
-    return -zoneInfo.gmtOffset / 60;
+    var value = -zoneInfo.gmtOffset / 60;
+    return value;
   }
   // NON-STANDARD: Returns the abbreviation (e.g. EST, EDT) for the specified time zone.
   this.getTimezoneAbbr = function getTimezoneAbbr() {
@@ -519,10 +521,15 @@ function setTimezone (timezone, relative) {
   this.toLocaleString = this.toString;
 
   if (relative) {
+    debug("setAllDateFields");
     this.setAllDateFields(y,mo,d)
+    debug("setHours")
     this.setHours(h)
+    debug("setMinutes")
     this.setMinutes(m)
+    debug("setSeconds")
     this.setSeconds(s)
+    debug("setMilliseconds")
     this.setMilliseconds(ms)
     ms = s = m = h = d = mo = y = null
   }
diff --git a/src/time_napi.cc b/src/time_napi.cc
index 2c3595c..064d9fa 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -41,7 +41,7 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
     // Nan::EscapableHandleScope scope;
     // Napi::EscapableHandleScope scope = Napi::EscapableHandleScope::New(info.Env());
     // Set up the timezone info from the current TZ environ variable
-    // tzset(); this really looks odd calling it twice ?
+    ::tzset();
 
     // Set up a return object that will hold the results of the timezone change
     // Local<Object> obj = Nan::New<v8::Object>();
@@ -53,7 +53,7 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
     Napi::Array tznameArray = Napi::Array::New(info.Env(), tznameLength);
     for (size_t i = 0; i < tznameLength; i++) {
         // Nan::Set(tznameArray, i, Nan::New<v8::String>(tzname[i]).ToLocalChecked());
-        std::cout << "time zone name from ? " << i << " " << tzname[i] << std::endl;
+        // std::cout << "time zone name from ? " << i << " " << tzname[i] << std::endl;
         // tzname is from environment variable TZ
         // http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
         tznameArray[i] = Napi::String::New(info.Env(), tzname[i]);
@@ -79,9 +79,7 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
 }
 
 Napi::Value Time::localtime(const Napi::CallbackInfo &info) {
-    std::cout << "================= native localtime ========================"
-    << info.Length()
-    << std::endl;
+    std::cout << "================= native localtime ========================" << std::endl;
     Napi::Env env = info.Env();
     // Nan::EscapableHandleScope scope;
 
@@ -115,7 +113,40 @@ Napi::Value Time::localtime(const Napi::CallbackInfo &info) {
         obj.Set("dayOfWeek", timeinfo->tm_wday);
         obj.Set("dayOfYear", timeinfo->tm_yday);
         obj.Set("isDaylightSavings", (timeinfo->tm_isdst > 0));
+        obj.Set("xyz", "xyz");
+#if defined HAVE_TM_GMTOFF
+      // Only available with glibc's "tm" struct. Most Linuxes, Mac OS X...
+      // Nan::Set(obj, Nan::New("gmtOffset").ToLocalChecked(), Nan::New<v8::Number>(timeinfo->tm_gmtoff) );
+      // Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New(timeinfo->tm_zone).ToLocalChecked() );
+    std::cout << "have tm" << std::endl;
+    obj.Set("gmtOffset", timeinfo->tm_gmtoff);
+    obj.Set("timezone", timeinfo->tm_zone);
+    obj.Set("monkey1", 1);
+#elif defined HAVE_TIMEZONE
+    std::cout << "have not tm" << std::endl;
+      // Compatibility for Cygwin, Solaris, probably others...
+      long scd;
+      if (timeinfo->tm_isdst > 0) {
+  #ifdef HAVE_ALTZONE
+        scd = -altzone;
+  #else
+        scd = -timezone + 3600;
+  #endif // HAVE_ALTZONE
+      } else {
+        scd = -timezone;
+      }
+      // Nan::Set(obj, Nan::New("gmtOffset").ToLocalChecked(), Nan::New<v8::Integer>(scd));
+      // Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::String>(tzname[timeinfo->tm_isdst]));
+      obj.Set("gmtOffset", scd);
+      obj.Set('timezone', tzname[timeinfo->tm_isdst]);
+      // obj.Set("monkey2", 2);
+#endif // HAVE_TM_GMTOFF
+    } else {
+      // Nan::Set(obj, Nan::New("invalid").ToLocalChecked(), Nan::New<v8::Boolean>(true));
+      std::cout << "have error in tm" << std::endl;
+      obj.Set("invalid", true);
     }
+
     return obj;
 }
 
@@ -126,14 +157,11 @@ Napi::Value Time::mktime(const Napi::CallbackInfo &info) {
          Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
             return env.Null();
     }
-    std::cout << "================= args count checked ========================" << std::endl;
     if (!info[0].IsObject() ) {
         Napi::TypeError::New(env, "Wrong arguments").ThrowAsJavaScriptException();
         return env.Null();
     }
-    std::cout << "================= arg value is an object ========================" << std::endl;
     Napi::Object obj = info[0].As<Napi::Object>();
-    std::cout << "================= tm struct manipulate ========================" << std::endl;
     struct tm tmstr;
     tmstr.tm_sec = obj.Get("seconds").As<Napi::Number>().Uint32Value();
     tmstr.tm_min = obj.Get("minutes").As<Napi::Number>().Uint32Value();
@@ -142,10 +170,7 @@ Napi::Value Time::mktime(const Napi::CallbackInfo &info) {
     tmstr.tm_mon = obj.Get("month").As<Napi::Number>().Uint32Value();
     tmstr.tm_year = obj.Get("year").As<Napi::Number>().Uint32Value();
     tmstr.tm_isdst = obj.Get("isDaylightSavings").As<Napi::Number>().Uint32Value();
-    std::cout << "================= tm struct manipulated ========================" << std::endl;
-    std::cout << "tm_mday=" << tmstr.tm_mday << std::endl;
     double myMakeTmVal = ::mktime(&tmstr);
-    std::cout << "myMakeTmVal = " << myMakeTmVal << std::endl;
     Napi::Number myMakeTm = Napi::Number::New(env, myMakeTmVal);
     return myMakeTm;
 }
diff --git a/test/date.js b/test/date.js
index cee4e98..98d8712 100644
--- a/test/date.js
+++ b/test/date.js
@@ -13,13 +13,13 @@ describe('Date', function () {
     it('should parse strings relative to TZ', function() {
 
       var d = new time.Date('2012-1-12 02:00 PM', 'America/New_York');
-/*      var t = d.getTime();
+      var t = d.getTime();
       assert.equal(t, 1326394800000);
       assert.equal(d.getTimezone(), 'America/New_York');
 
       d = new time.Date('2012-1-12 02:00 PM', 'America/Los_Angeles');
       assert.equal(d.getTime(), 1326405600000);
-      assert.equal(d.getTimezone(), 'America/Los_Angeles');*/
+      assert.equal(d.getTimezone(), 'America/Los_Angeles');
     })
 
     it('should interpret date parts relative to TZ', function() {
@@ -148,7 +148,8 @@ describe('Date', function () {
       assert.equal(d.getUTCMinutes(), d.getMinutes())
       assert.equal(d.getUTCMonth(), d.getMonth())
       assert.equal(d.getUTCSeconds(), d.getSeconds())
-      assert.equal(d.getTimezoneOffset(), 0)
+      var tmo = d.getTimezoneOffset();
+      assert.equal(tmo, 0);
     })
 
     it('should especially change the "hours" value', function () {

From 14928719e88c34e24b82c9d093bb95d35624cb8f Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 22:03:43 -0500
Subject: [PATCH 04/29] remove logging and commented out nan code from previous
 api

---
 src/time_napi.cc | 85 +++++++++++++++---------------------------------
 1 file changed, 26 insertions(+), 59 deletions(-)

diff --git a/src/time_napi.cc b/src/time_napi.cc
index 064d9fa..c7b7ad9 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -1,12 +1,10 @@
 #include <napi.h>
 #include "time_napi.h"
 #include <time.h>
-#include <iostream>
 
 Napi::FunctionReference Time::constructor;
 
 Napi::Object Time::Init(Napi::Env env, Napi::Object exports) {
-    std::cout << "================= native init ========================" << std::endl;
     Napi::HandleScope scope(env);
 
     Napi::Function func = DefineClass(env, "Time", {
@@ -24,36 +22,25 @@ Napi::Object Time::Init(Napi::Env env, Napi::Object exports) {
 }
 
 Time::Time(const Napi::CallbackInfo &info) : Napi::ObjectWrap<Time>(info) {
-    std::cout << "================= native ctor ========================" << std::endl;
     Napi::Env env = info.Env();
     Napi::HandleScope scope(env);
 }
 
 Napi::Value Time::time(const Napi::CallbackInfo &info) {
-    std::cout << "================= native time ========================" << std::endl;
     return Napi::String::New(info.Env(), "hello world 1");
 }
 
-// MSVC++ 14.0  _MSC_VER == 1900 (Visual Studio 2015 version 14.0)
 
 Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
-    std::cout << "================= native tzset ========================" << std::endl;
-    // Nan::EscapableHandleScope scope;
-    // Napi::EscapableHandleScope scope = Napi::EscapableHandleScope::New(info.Env());
-    // Set up the timezone info from the current TZ environ variable
     ::tzset();
 
     // Set up a return object that will hold the results of the timezone change
-    // Local<Object> obj = Nan::New<v8::Object>();
     Napi::Object obj = Napi::Object::New(info.Env());
 
     // The 'tzname' char * [] gets put into a JS Array
     size_t tznameLength = 2;
-    // Local<Array> tznameArray = Nan::New<v8::Array>( tznameLength );
     Napi::Array tznameArray = Napi::Array::New(info.Env(), tznameLength);
     for (size_t i = 0; i < tznameLength; i++) {
-        // Nan::Set(tznameArray, i, Nan::New<v8::String>(tzname[i]).ToLocalChecked());
-        // std::cout << "time zone name from ? " << i << " " << tzname[i] << std::endl;
         // tzname is from environment variable TZ
         // http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
         tznameArray[i] = Napi::String::New(info.Env(), tzname[i]);
@@ -63,44 +50,34 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
     obj.Set("tzname", tznameArray);
 
     // The 'timezone' long is the "seconds West of UTC"
-    // Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::Number>( timezone ));
     obj.Set("timezone", timezone);
 
     // The 'daylight' int is obselete actually, but I'll include it here for
     // curiosity's sake. See the "Notes" section of "man tzset"
-    //Nan::Set(obj, Nan::New("daylight").ToLocalChecked(), Nan::New<v8::Number>( daylight ));
     obj.Set("daylight", daylight);
 
-    // info.GetReturnValue().Set(scope.Escape(obj));
-
     obj.Set("funkyChicken", "the funky chicken");
 
     return obj;
 }
 
 Napi::Value Time::localtime(const Napi::CallbackInfo &info) {
-    std::cout << "================= native localtime ========================" << std::endl;
     Napi::Env env = info.Env();
-    // Nan::EscapableHandleScope scope;
-
-    // Construct the 'tm' struct
-    // time_t rawtime = static_cast<time_t>(info[0]->IntegerValue());
-    // struct tm *timeinfo = localtime(&rawtime);
 
     if (info.Length() < 1) {
-         Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
-            return env.Null();
+        Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
+        return env.Null();
     }
 
-    if (!info[0].IsNumber() ) {
+    if (!info[0].IsNumber()) {
         Napi::TypeError::New(env, "Wrong arguments").ThrowAsJavaScriptException();
         return env.Null();
     }
 
-    time_t rawtime = static_cast<time_t>(info[0].As<Napi::Number>().Int64Value());
+    // Construct the 'tm' struct
+    time_t rawtime = static_cast<time_t>(info[0].As<Napi::Number>().DoubleValue());
     struct tm *timeinfo = ::localtime(&rawtime);
     // Create the return "Object"
-    // Local <Object> obj = Nan::New<v8::Object>();
     Napi::Object obj = Napi::Object::New(env);
 
     if (timeinfo) {
@@ -115,49 +92,39 @@ Napi::Value Time::localtime(const Napi::CallbackInfo &info) {
         obj.Set("isDaylightSavings", (timeinfo->tm_isdst > 0));
         obj.Set("xyz", "xyz");
 #if defined HAVE_TM_GMTOFF
-      // Only available with glibc's "tm" struct. Most Linuxes, Mac OS X...
-      // Nan::Set(obj, Nan::New("gmtOffset").ToLocalChecked(), Nan::New<v8::Number>(timeinfo->tm_gmtoff) );
-      // Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New(timeinfo->tm_zone).ToLocalChecked() );
-    std::cout << "have tm" << std::endl;
-    obj.Set("gmtOffset", timeinfo->tm_gmtoff);
-    obj.Set("timezone", timeinfo->tm_zone);
-    obj.Set("monkey1", 1);
+        // Only available with glibc's "tm" struct. Most Linuxes, Mac OS X...
+        obj.Set("gmtOffset", timeinfo->tm_gmtoff);
+        obj.Set("timezone", timeinfo->tm_zone);
 #elif defined HAVE_TIMEZONE
-    std::cout << "have not tm" << std::endl;
-      // Compatibility for Cygwin, Solaris, probably others...
-      long scd;
-      if (timeinfo->tm_isdst > 0) {
-  #ifdef HAVE_ALTZONE
-        scd = -altzone;
-  #else
-        scd = -timezone + 3600;
-  #endif // HAVE_ALTZONE
-      } else {
-        scd = -timezone;
-      }
-      // Nan::Set(obj, Nan::New("gmtOffset").ToLocalChecked(), Nan::New<v8::Integer>(scd));
-      // Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::String>(tzname[timeinfo->tm_isdst]));
-      obj.Set("gmtOffset", scd);
-      obj.Set('timezone', tzname[timeinfo->tm_isdst]);
-      // obj.Set("monkey2", 2);
+        // Compatibility for Cygwin, Solaris, probably others...
+        long scd;
+        if (timeinfo->tm_isdst > 0) {
+#ifdef HAVE_ALTZONE
+          scd = -altzone;
+#else
+          scd = -timezone + 3600;
+#endif // HAVE_ALTZONE
+        } else {
+          scd = -timezone;
+        }
+        obj.Set("gmtOffset", scd);
+        obj.Set('timezone', tzname[timeinfo->tm_isdst]);
 #endif // HAVE_TM_GMTOFF
     } else {
-      // Nan::Set(obj, Nan::New("invalid").ToLocalChecked(), Nan::New<v8::Boolean>(true));
-      std::cout << "have error in tm" << std::endl;
-      obj.Set("invalid", true);
+        obj.Set("invalid", true);
     }
 
     return obj;
 }
 
 Napi::Value Time::mktime(const Napi::CallbackInfo &info) {
-    std::cout << "================= native mktime ========================" << std::endl;
+
     Napi::Env env = info.Env();
     if (info.Length() < 1) {
-         Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
-            return env.Null();
+        Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException();
+        return env.Null();
     }
-    if (!info[0].IsObject() ) {
+    if (!info[0].IsObject()) {
         Napi::TypeError::New(env, "Wrong arguments").ThrowAsJavaScriptException();
         return env.Null();
     }

From b148855786f09d1dd61b88ed46d45fd5ed5b056f Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 22:09:06 -0500
Subject: [PATCH 05/29] indentation for binding.gyp, did not find a standard so
 4 spaces is adopted

---
 binding.gyp | 64 ++++++++++++++++++++++++++---------------------------
 1 file changed, 31 insertions(+), 33 deletions(-)

diff --git a/binding.gyp b/binding.gyp
index 7593be6..1c80226 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -1,39 +1,37 @@
 {
-  'targets': [
-    {
-      'target_name': 'time',
-      'sources': [ 'src/time_napi.cc' ],
-      'include_dirs': ["<!@(node -p \"require('node-addon-api').include\")"],
-      'dependencies': ["<!(node -p \"require('node-addon-api').gyp\")"],
-      'cflags!': [ '-fno-exceptions' ],
-      'cflags_cc!': [ '-fno-exceptions' ],
-      'xcode_settings': {
+    'targets': [{
+        'target_name': 'time',
+        'sources': [ 'src/time_napi.cc' ],
+        'include_dirs': ["<!@(node -p \"require('node-addon-api').include\")"],
+        'dependencies': ["<!(node -p \"require('node-addon-api').gyp\")"],
+        'cflags!': [ '-fno-exceptions' ],
+        'cflags_cc!': [ '-fno-exceptions' ],
+        'xcode_settings': {
         'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
         'CLANG_CXX_LIBRARY': 'libc++',
         'MACOSX_DEPLOYMENT_TARGET': '10.7'
-      },
-      'msvs_settings': {
+        },
+        'msvs_settings': {
         'VCCLCompilerTool': { 'ExceptionHandling': 1 },
-      },
-    'conditions': [
-      ['OS=="mac"', {
-        'defines': [
-          '__DARWIN_UNIX03', # For char* timezone
-          'HAVE_TM_GMTOFF'
-        ]
-      }],
-      ['OS=="linux"', {
-        'defines': [
-          'HAVE_TM_GMTOFF'
-        ]
-      }],
-      ['OS=="solaris"', {
-        'defines': [
-          'HAVE_ALTZONE',
-          'HAVE_TIMEZONE'
-        ]
-      }]
-    ]
-    }
-  ]
+        },
+        'conditions': [
+                   ['OS=="mac"', {
+                     'defines': [
+                       '__DARWIN_UNIX03', # For char* timezone
+                       'HAVE_TM_GMTOFF'
+                     ]
+                   }],
+                   ['OS=="linux"', {
+                     'defines': [
+                       'HAVE_TM_GMTOFF'
+                     ]
+                   }],
+                   ['OS=="solaris"', {
+                     'defines': [
+                       'HAVE_ALTZONE',
+                       'HAVE_TIMEZONE'
+                     ]
+                   }]
+                 ]
+     }]
 }

From 05a9dc1550752d39d396972ee8184798b3f08f4f Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 22:17:50 -0500
Subject: [PATCH 06/29] remove unused code

the Time::time method was not used.
---
 index.js         | 30 +++++++-----------------------
 src/time_napi.cc |  6 ------
 src/time_napi.h  |  1 -
 3 files changed, 7 insertions(+), 30 deletions(-)

diff --git a/index.js b/index.js
index f34c0ee..0b8f396 100644
--- a/index.js
+++ b/index.js
@@ -5,14 +5,12 @@
 var debug = require('debug')('time')
   , fs = require('fs')
   , path = require('path')
-  // , bindings = require('bindings')('time')
+  , time =  require('bindings')('time')
   , MILLIS_PER_SECOND = 1000
   , DAYS_OF_WEEK = ['Sunday','Monday','Tuesday','Wednesday','Thursday','Friday','Saturday']
   , MONTHS = ['January','February','March','April','May','June','July','August','September','October','November','December']
   , TZ_BLACKLIST = [ 'SystemV', 'Etc' ];
 
-var time =  require('bindings')('time');
-// ok, it has no state
 var bindings = new time.Time();
 /**
  * Extends a "Date" constructor with node-time's extensions.
@@ -41,16 +39,12 @@ exports.currentTimezone = process.env.TZ;
  * Export the raw functions from the bindings.
  */
 
-exports.time = () => {
-  debug("local time call in js to time")
-  return bindings.time();
-}
-exports.localtime = (t) => {
-  debug('localtime binding in js')
+exports.localtime = function(t) {
+  debug('calling native localtime');
   return bindings.localtime(t);
 }
-exports.mktime = (o) => {
-  debug('local mktime binding in js calling with %s', JSON.stringify(o,null, 2))
+exports.mktime = function(o) {
+  debug('calling native mktime');
   return bindings.mktime(o);
 }
 
@@ -150,7 +144,6 @@ if (!exports.currentTimezone) {
   }
 }
 
-
 /**
  * The user-facing 'tzset' function is a thin wrapper around the native binding to
  * 'tzset()'. This function accepts a timezone String to set the process' timezone
@@ -276,8 +269,7 @@ function setTimezone (timezone, relative) {
   }
 
   // Get the zoneinfo for this Date instance's time value
-  var myTime = this.getTime() / 1000;
-  var zoneInfo = exports.localtime(myTime);
+  var zoneInfo = exports.localtime(this.getTime() / 1000);
 
   // Change the timezone back if we changed it originally
   if (oldTz != timezone) {
@@ -329,8 +321,7 @@ function setTimezone (timezone, relative) {
   // Returns the timezone offset from GMT the Date instance currently is in,
   // in minutes. Also, left of GMT is positive, right of GMT is negative.
   this.getTimezoneOffset = function getTimezoneOffset() {
-    var value = -zoneInfo.gmtOffset / 60;
-    return value;
+    return -zoneInfo.gmtOffset / 60;
   }
   // NON-STANDARD: Returns the abbreviation (e.g. EST, EDT) for the specified time zone.
   this.getTimezoneAbbr = function getTimezoneAbbr() {
@@ -521,15 +512,10 @@ function setTimezone (timezone, relative) {
   this.toLocaleString = this.toString;
 
   if (relative) {
-    debug("setAllDateFields");
     this.setAllDateFields(y,mo,d)
-    debug("setHours")
     this.setHours(h)
-    debug("setMinutes")
     this.setMinutes(m)
-    debug("setSeconds")
     this.setSeconds(s)
-    debug("setMilliseconds")
     this.setMilliseconds(ms)
     ms = s = m = h = d = mo = y = null
   }
@@ -541,7 +527,6 @@ function setTimezone (timezone, relative) {
   }
   // 'mktime' calls 'reset' implicitly through 'setTime()'
   function mktime () {
-    debug("mktime js side");
     var oldTz = process.env.TZ;
     exports.tzset(this.getTimezone());
     zoneInfo.isDaylightSavings = -1; // Auto-detect the timezone
@@ -576,7 +561,6 @@ function getTimezoneAbbr () {
 // argument, in order to specify the initial timezone the Date instance should
 // be created with.
 function Date (year, month, day, hour, minute, second, millisecond, timezone) {
-  debug("Date JS side")
   if (!(this instanceof Date)) {
     return new Date(year, month, day, hour, minute, second, millisecond, timezone).toString();
   }
diff --git a/src/time_napi.cc b/src/time_napi.cc
index c7b7ad9..e4d9286 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -8,7 +8,6 @@ Napi::Object Time::Init(Napi::Env env, Napi::Object exports) {
     Napi::HandleScope scope(env);
 
     Napi::Function func = DefineClass(env, "Time", {
-            InstanceMethod("time", &Time::time),
             InstanceMethod("tzset", &Time::tzset),
             InstanceMethod("localtime", &Time::localtime),
             InstanceMethod("mktime", &Time::mktime),
@@ -26,11 +25,6 @@ Time::Time(const Napi::CallbackInfo &info) : Napi::ObjectWrap<Time>(info) {
     Napi::HandleScope scope(env);
 }
 
-Napi::Value Time::time(const Napi::CallbackInfo &info) {
-    return Napi::String::New(info.Env(), "hello world 1");
-}
-
-
 Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
     ::tzset();
 
diff --git a/src/time_napi.h b/src/time_napi.h
index 13fbe12..35ac72a 100644
--- a/src/time_napi.h
+++ b/src/time_napi.h
@@ -11,7 +11,6 @@ class Time : public Napi::ObjectWrap<Time> {
 private:
     static Napi::FunctionReference constructor;
 
-    Napi::Value time(const Napi::CallbackInfo& info);
     Napi::Value tzset(const Napi::CallbackInfo& info);
     Napi::Value localtime(const Napi::CallbackInfo& info);
     Napi::Value mktime(const Napi::CallbackInfo& info);

From 9d7499914ee5e8a1a6c4073beaf495893c13ea63 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 22:19:29 -0500
Subject: [PATCH 07/29] add package-lock to change control

---
 package-lock.json | 215 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 215 insertions(+)
 create mode 100644 package-lock.json

diff --git a/package-lock.json b/package-lock.json
new file mode 100644
index 0000000..f7a3f6d
--- /dev/null
+++ b/package-lock.json
@@ -0,0 +1,215 @@
+{
+  "name": "time",
+  "version": "0.2.0",
+  "lockfileVersion": 1,
+  "requires": true,
+  "dependencies": {
+    "balanced-match": {
+      "version": "1.0.0",
+      "resolved": "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.0.tgz",
+      "integrity": "sha1-ibTRmasr7kneFk6gK4nORi1xt2c=",
+      "dev": true
+    },
+    "bindings": {
+      "version": "1.3.1",
+      "resolved": "https://registry.npmjs.org/bindings/-/bindings-1.3.1.tgz",
+      "integrity": "sha512-i47mqjF9UbjxJhxGf+pZ6kSxrnI3wBLlnGI2ArWJ4r0VrvDS7ZYXkprq/pLaBWYq4GM0r4zdHY+NNRqEMU7uew=="
+    },
+    "brace-expansion": {
+      "version": "1.1.11",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
+      "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==",
+      "dev": true,
+      "requires": {
+        "balanced-match": "^1.0.0",
+        "concat-map": "0.0.1"
+      }
+    },
+    "browser-stdout": {
+      "version": "1.3.1",
+      "resolved": "https://registry.npmjs.org/browser-stdout/-/browser-stdout-1.3.1.tgz",
+      "integrity": "sha512-qhAVI1+Av2X7qelOfAIYwXONood6XlZE/fXaBSmW/T5SzLAmCgzi+eiWE7fUvbHaeNBQH13UftjpXxsfLkMpgw==",
+      "dev": true
+    },
+    "commander": {
+      "version": "2.15.1",
+      "resolved": "http://registry.npmjs.org/commander/-/commander-2.15.1.tgz",
+      "integrity": "sha512-VlfT9F3V0v+jr4yxPc5gg9s62/fIVWsd2Bk2iD435um1NlGMYdVCq+MjcXnhYq2icNOizHr1kK+5TI6H0Hy0ag==",
+      "dev": true
+    },
+    "concat-map": {
+      "version": "0.0.1",
+      "resolved": "https://registry.npmjs.org/concat-map/-/concat-map-0.0.1.tgz",
+      "integrity": "sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=",
+      "dev": true
+    },
+    "debug": {
+      "version": "2.6.9",
+      "resolved": "https://registry.npmjs.org/debug/-/debug-2.6.9.tgz",
+      "integrity": "sha512-bC7ElrdJaJnPbAP+1EotYvqZsb3ecl5wi6Bfi6BJTUcNowp6cvspg0jXznRTKDjm/E7AdgFBVeAPVMNcKGsHMA==",
+      "requires": {
+        "ms": "2.0.0"
+      }
+    },
+    "diff": {
+      "version": "3.5.0",
+      "resolved": "https://registry.npmjs.org/diff/-/diff-3.5.0.tgz",
+      "integrity": "sha512-A46qtFgd+g7pDZinpnwiRJtxbC1hpgf0uzP3iG89scHk0AUC7A1TGxf5OiiOUv/JMZR8GOt8hL900hV0bOy5xA==",
+      "dev": true
+    },
+    "escape-string-regexp": {
+      "version": "1.0.5",
+      "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz",
+      "integrity": "sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ=",
+      "dev": true
+    },
+    "fs.realpath": {
+      "version": "1.0.0",
+      "resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz",
+      "integrity": "sha1-FQStJSMVjKpA20onh8sBQRmU6k8=",
+      "dev": true
+    },
+    "glob": {
+      "version": "7.1.2",
+      "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.2.tgz",
+      "integrity": "sha512-MJTUg1kjuLeQCJ+ccE4Vpa6kKVXkPYJ2mOCQyUuKLcLQsdrMCpBPUi8qVE6+YuaJkozeA9NusTAw3hLr8Xe5EQ==",
+      "dev": true,
+      "requires": {
+        "fs.realpath": "^1.0.0",
+        "inflight": "^1.0.4",
+        "inherits": "2",
+        "minimatch": "^3.0.4",
+        "once": "^1.3.0",
+        "path-is-absolute": "^1.0.0"
+      }
+    },
+    "growl": {
+      "version": "1.10.5",
+      "resolved": "https://registry.npmjs.org/growl/-/growl-1.10.5.tgz",
+      "integrity": "sha512-qBr4OuELkhPenW6goKVXiv47US3clb3/IbuWF9KNKEijAy9oeHxU9IgzjvJhHkUzhaj7rOUD7+YGWqUjLp5oSA==",
+      "dev": true
+    },
+    "has-flag": {
+      "version": "3.0.0",
+      "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz",
+      "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=",
+      "dev": true
+    },
+    "he": {
+      "version": "1.1.1",
+      "resolved": "https://registry.npmjs.org/he/-/he-1.1.1.tgz",
+      "integrity": "sha1-k0EP0hsAlzUVH4howvJx80J+I/0=",
+      "dev": true
+    },
+    "inflight": {
+      "version": "1.0.6",
+      "resolved": "https://registry.npmjs.org/inflight/-/inflight-1.0.6.tgz",
+      "integrity": "sha1-Sb1jMdfQLQwJvJEKEHW6gWW1bfk=",
+      "dev": true,
+      "requires": {
+        "once": "^1.3.0",
+        "wrappy": "1"
+      }
+    },
+    "inherits": {
+      "version": "2.0.3",
+      "resolved": "https://registry.npmjs.org/inherits/-/inherits-2.0.3.tgz",
+      "integrity": "sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4=",
+      "dev": true
+    },
+    "minimatch": {
+      "version": "3.0.4",
+      "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz",
+      "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==",
+      "dev": true,
+      "requires": {
+        "brace-expansion": "^1.1.7"
+      }
+    },
+    "minimist": {
+      "version": "0.0.8",
+      "resolved": "http://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz",
+      "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=",
+      "dev": true
+    },
+    "mkdirp": {
+      "version": "0.5.1",
+      "resolved": "http://registry.npmjs.org/mkdirp/-/mkdirp-0.5.1.tgz",
+      "integrity": "sha1-MAV0OOrGz3+MR2fzhkjWaX11yQM=",
+      "dev": true,
+      "requires": {
+        "minimist": "0.0.8"
+      }
+    },
+    "mocha": {
+      "version": "5.2.0",
+      "resolved": "https://registry.npmjs.org/mocha/-/mocha-5.2.0.tgz",
+      "integrity": "sha512-2IUgKDhc3J7Uug+FxMXuqIyYzH7gJjXECKe/w43IGgQHTSj3InJi+yAA7T24L9bQMRKiUEHxEX37G5JpVUGLcQ==",
+      "dev": true,
+      "requires": {
+        "browser-stdout": "1.3.1",
+        "commander": "2.15.1",
+        "debug": "3.1.0",
+        "diff": "3.5.0",
+        "escape-string-regexp": "1.0.5",
+        "glob": "7.1.2",
+        "growl": "1.10.5",
+        "he": "1.1.1",
+        "minimatch": "3.0.4",
+        "mkdirp": "0.5.1",
+        "supports-color": "5.4.0"
+      },
+      "dependencies": {
+        "debug": {
+          "version": "3.1.0",
+          "resolved": "https://registry.npmjs.org/debug/-/debug-3.1.0.tgz",
+          "integrity": "sha512-OX8XqP7/1a9cqkxYw2yXss15f26NKWBpDXQd0/uK/KPqdQhxbPa994hnzjcE2VqQpDslf55723cKPUOGSmMY3g==",
+          "dev": true,
+          "requires": {
+            "ms": "2.0.0"
+          }
+        }
+      }
+    },
+    "ms": {
+      "version": "2.0.0",
+      "resolved": "https://registry.npmjs.org/ms/-/ms-2.0.0.tgz",
+      "integrity": "sha1-VgiurfwAvmwpAd9fmGF4jeDVl8g="
+    },
+    "node-addon-api": {
+      "version": "1.6.2",
+      "resolved": "https://registry.npmjs.org/node-addon-api/-/node-addon-api-1.6.2.tgz",
+      "integrity": "sha512-479Bjw9nTE5DdBSZZWprFryHGjUaQC31y1wHo19We/k0BZlrmhqQitWoUL0cD8+scljCbIUL+E58oRDEakdGGA=="
+    },
+    "once": {
+      "version": "1.4.0",
+      "resolved": "https://registry.npmjs.org/once/-/once-1.4.0.tgz",
+      "integrity": "sha1-WDsap3WWHUsROsF9nFC6753Xa9E=",
+      "dev": true,
+      "requires": {
+        "wrappy": "1"
+      }
+    },
+    "path-is-absolute": {
+      "version": "1.0.1",
+      "resolved": "http://registry.npmjs.org/path-is-absolute/-/path-is-absolute-1.0.1.tgz",
+      "integrity": "sha1-F0uSaHNVNP+8es5r9TpanhtcX18=",
+      "dev": true
+    },
+    "supports-color": {
+      "version": "5.4.0",
+      "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.4.0.tgz",
+      "integrity": "sha512-zjaXglF5nnWpsq470jSv6P9DwPvgLkuapYmfDm3JWOm0vkNTVF2tI4UrN2r6jH1qM/uc/WtxYY1hYoA2dOKj5w==",
+      "dev": true,
+      "requires": {
+        "has-flag": "^3.0.0"
+      }
+    },
+    "wrappy": {
+      "version": "1.0.2",
+      "resolved": "https://registry.npmjs.org/wrappy/-/wrappy-1.0.2.tgz",
+      "integrity": "sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8=",
+      "dev": true
+    }
+  }
+}

From 010da54cac068a630533e993c75f93597aa9cb20 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 22:27:10 -0500
Subject: [PATCH 08/29] update the travis.yml file

---
 .travis.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 07da7a3..3b9dc62 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -22,6 +22,10 @@ node_js:
   - "5"
   - "6"
   - "7"
+  - "8"
+  - "9"
+  - "10"
+  - "11"
 
 install:
   - PATH="`npm bin`:`npm bin -g`:$PATH"

From 6d82d7f95ccd30b06a1d20d6694abe87e8a880fc Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Mon, 31 Dec 2018 22:56:25 -0500
Subject: [PATCH 09/29] update travis, attempt node 4 onwards set version to
 1.0.0

---
 .travis.yml  | 6 ------
 package.json | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 3b9dc62..06a3793 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -12,12 +12,6 @@ addons:
 language: node_js
 
 node_js:
-  - "0.8"
-  - "0.10"
-  - "0.12"
-  - "1"
-  - "2"
-  - "3"
   - "4"
   - "5"
   - "6"
diff --git a/package.json b/package.json
index 879eede..75d8066 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
     "setTimezone",
     "getTimezone"
   ],
-  "version": "0.2.0",
+  "version": "1.0.0",
   "repository": {
     "type": "git",
     "url": "git://github.com/TooTallNate/node-time.git"

From 3e0273c793e85f3c4d1fd160fff1094097400a45 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 13:12:27 -0500
Subject: [PATCH 10/29] add osx to the build os

---
 .travis.yml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 06a3793..f19ef1e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,3 +1,7 @@
+os:
+  - linux
+  - osx
+
 sudo: false
 
 env:
@@ -23,14 +27,9 @@ node_js:
 
 install:
   - PATH="`npm bin`:`npm bin -g`:$PATH"
-  # Node 0.8 comes with a too obsolete npm
-  - if [[ "`node --version`" =~ ^v0\.8\. ]]; then npm install -g npm@1.4.28 ; fi
-  # Install dependencies and build
   - npm install
 
 script:
-  # Output useful info for debugging
   - node --version
   - npm --version
-  # Run tests
   - npm test

From 9eba57978017fb1b88f09787ca24afbbb516f6f5 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 13:32:28 -0500
Subject: [PATCH 11/29] remove specifics for g++

---
 .travis.yml | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index f19ef1e..f878828 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,26 +4,10 @@ os:
 
 sudo: false
 
-env:
-  - CXX=g++-4.8
-addons:
-  apt:
-    sources:
-      - ubuntu-toolchain-r-test
-    packages:
-      - g++-4.8
-
 language: node_js
 
 node_js:
-  - "4"
-  - "5"
-  - "6"
-  - "7"
-  - "8"
-  - "9"
   - "10"
-  - "11"
 
 install:
   - PATH="`npm bin`:`npm bin -g`:$PATH"

From b3ef31db53cba4b100458992e7c65950a2f9e0a9 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 13:35:08 -0500
Subject: [PATCH 12/29] add all node versions for both osx and linux

---
 .travis.yml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index f878828..c4fde15 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,7 +7,14 @@ sudo: false
 language: node_js
 
 node_js:
+  - "4"
+  - "5"
+  - "6"
+  - "7"
+  - "8"
+  - "9"
   - "10"
+  - "11"
 
 install:
   - PATH="`npm bin`:`npm bin -g`:$PATH"

From a817a24894bde60c35d602b77247af3195247ad7 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 13:42:37 -0500
Subject: [PATCH 13/29] add windows os

---
 .travis.yml | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index c4fde15..8356d00 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,20 +1,14 @@
 os:
   - linux
   - osx
+  - windows
 
 sudo: false
 
 language: node_js
 
 node_js:
-  - "4"
-  - "5"
-  - "6"
-  - "7"
-  - "8"
-  - "9"
   - "10"
-  - "11"
 
 install:
   - PATH="`npm bin`:`npm bin -g`:$PATH"

From f201e0964c8f0da50425af70d07be911b14a0ade Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 15:06:19 -0500
Subject: [PATCH 14/29] test of windows and linux as canary

---
 .travis.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 8356d00..1b743a7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,5 @@
 os:
   - linux
-  - osx
   - windows
 
 sudo: false
@@ -11,7 +10,6 @@ node_js:
   - "10"
 
 install:
-  - PATH="`npm bin`:`npm bin -g`:$PATH"
   - npm install
 
 script:

From 59aefa99ff73868bc658b90f1fab7775ac203bf4 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 17:12:05 -0500
Subject: [PATCH 15/29] add windows section of the build back in again ready
 for travis ci testing.

---
 package-lock.json |  2 +-
 src/time_napi.cc  | 29 ++++++++++++++++++++++++-----
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index f7a3f6d..674dabe 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "time",
-  "version": "0.2.0",
+  "version": "1.0.0",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/src/time_napi.cc b/src/time_napi.cc
index e4d9286..92c86e1 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -30,17 +30,38 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
 
     // Set up a return object that will hold the results of the timezone change
     Napi::Object obj = Napi::Object::New(info.Env());
-
     // The 'tzname' char * [] gets put into a JS Array
     size_t tznameLength = 2;
     Napi::Array tznameArray = Napi::Array::New(info.Env(), tznameLength);
+#if _MSC_VER >= 1900
+    char szTzName[128];
+
+	for (int i = 0; i < tznameLength; i++) {
+		size_t strLength;
+		_get_tzname(&strLength, szTzName, 128, i);
+		tznameArray[i] = Napi::String::New(info.Env(), szTzName);
+	}
+
+    obj.Set("tzname", tznameArray);
+	// The 'timezone' long is the "seconds West of UTC"
+	long timezone;
+	// MS C++ specific
+	// https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-timezone?view=vs-2017
+	_get_timezone(&timezone);
+	obj.Set("timezone", timezone);
+
+	// The 'daylight' int is obselete actually, but I'll include it here for
+	// curiosity's sake. See the "Notes" section of "man tzset"
+	int daylight;
+	_get_daylight(&daylight);
+	obj.Set("daylight", daylight);
+#else
     for (size_t i = 0; i < tznameLength; i++) {
         // tzname is from environment variable TZ
         // http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
         tznameArray[i] = Napi::String::New(info.Env(), tzname[i]);
     }
 
-    // Nan::Set(obj, Nan::New("tzname").ToLocalChecked(), tznameArray);
     obj.Set("tzname", tznameArray);
 
     // The 'timezone' long is the "seconds West of UTC"
@@ -49,9 +70,7 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
     // The 'daylight' int is obselete actually, but I'll include it here for
     // curiosity's sake. See the "Notes" section of "man tzset"
     obj.Set("daylight", daylight);
-
-    obj.Set("funkyChicken", "the funky chicken");
-
+#endif
     return obj;
 }
 

From 63d9df7cd5614a0d41651a2ef63b1e66f59601fd Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 17:45:52 -0500
Subject: [PATCH 16/29] log out the windows tzname

---
 src/time_napi.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/time_napi.cc b/src/time_napi.cc
index 92c86e1..d59e7dd 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -1,6 +1,7 @@
 #include <napi.h>
 #include "time_napi.h"
 #include <time.h>
+#include <iostream>
 
 Napi::FunctionReference Time::constructor;
 
@@ -40,6 +41,7 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
 		size_t strLength;
 		_get_tzname(&strLength, szTzName, 128, i);
 		tznameArray[i] = Napi::String::New(info.Env(), szTzName);
+		std::cout << "timezone array[" << i << "] = " << szTzName << std::endl;
 	}
 
     obj.Set("tzname", tznameArray);

From d7eaf238d4612c69e6b93269326e6f1a651cad28 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 17:49:29 -0500
Subject: [PATCH 17/29] add in non windows debug

---
 src/time_napi.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/time_napi.cc b/src/time_napi.cc
index d59e7dd..e9033d6 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -62,6 +62,7 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
         // tzname is from environment variable TZ
         // http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
         tznameArray[i] = Napi::String::New(info.Env(), tzname[i]);
+        std::cout << "timezone array[" << i << "] = " << tzname[i] << std::endl;
     }
 
     obj.Set("tzname", tznameArray);

From cc71db3428d7690fb416ecc5d071513d239e9da2 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 18:00:08 -0500
Subject: [PATCH 18/29] take out the debug that shows how unix type systems and
 windows systems differed.

do not unit test on windows as the original nan code had issues.
---
 .travis.yml      | 6 +++++-
 src/time_napi.cc | 2 --
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 1b743a7..52264e5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -12,7 +12,11 @@ node_js:
 install:
   - npm install
 
+# note, the original master branch using nan did not have a travis
+# job on windows and when unit tested was found to have breaking
+# tests. If these were fixed existing work arounds would be broken
+# on windows.
 script:
   - node --version
   - npm --version
-  - npm test
+  - if [[ "$TRAVIS_OS_NAME" != "windows" ]]; npm test ; fi
diff --git a/src/time_napi.cc b/src/time_napi.cc
index e9033d6..bc30bfd 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -41,7 +41,6 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
 		size_t strLength;
 		_get_tzname(&strLength, szTzName, 128, i);
 		tznameArray[i] = Napi::String::New(info.Env(), szTzName);
-		std::cout << "timezone array[" << i << "] = " << szTzName << std::endl;
 	}
 
     obj.Set("tzname", tznameArray);
@@ -62,7 +61,6 @@ Napi::Value Time::tzset(const Napi::CallbackInfo &info) {
         // tzname is from environment variable TZ
         // http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
         tznameArray[i] = Napi::String::New(info.Env(), tzname[i]);
-        std::cout << "timezone array[" << i << "] = " << tzname[i] << std::endl;
     }
 
     obj.Set("tzname", tznameArray);

From 14b2cc6791f36a00fabaf805f3a03d0d71e9de3c Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 1 Jan 2019 18:04:01 -0500
Subject: [PATCH 19/29] fix then statement in yml file.

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 52264e5..0f89753 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,4 +19,4 @@ install:
 script:
   - node --version
   - npm --version
-  - if [[ "$TRAVIS_OS_NAME" != "windows" ]]; npm test ; fi
+  - if [[ "$TRAVIS_OS_NAME" != "windows" ]]; then npm test ; fi

From 88e475bafe415b791404dc737854e70d160d4732 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Wed, 2 Jan 2019 19:06:33 -0500
Subject: [PATCH 20/29] remove the xyz obj test dead code.

---
 src/time_napi.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/time_napi.cc b/src/time_napi.cc
index bc30bfd..b24e705 100644
--- a/src/time_napi.cc
+++ b/src/time_napi.cc
@@ -104,7 +104,6 @@ Napi::Value Time::localtime(const Napi::CallbackInfo &info) {
         obj.Set("dayOfWeek", timeinfo->tm_wday);
         obj.Set("dayOfYear", timeinfo->tm_yday);
         obj.Set("isDaylightSavings", (timeinfo->tm_isdst > 0));
-        obj.Set("xyz", "xyz");
 #if defined HAVE_TM_GMTOFF
         // Only available with glibc's "tm" struct. Most Linuxes, Mac OS X...
         obj.Set("gmtOffset", timeinfo->tm_gmtoff);

From a53b8f48efe718538cdb5be1f432ab38c679bc3b Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Wed, 2 Jan 2019 19:11:39 -0500
Subject: [PATCH 21/29] add node 6 and osx to unit tests

---
 .travis.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 0f89753..0a1fb98 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,12 +1,14 @@
 os:
   - linux
   - windows
+  - osx
 
 sudo: false
 
 language: node_js
 
 node_js:
+  - "6.14.3"
   - "10"
 
 install:

From 074897ef170e3c6db575e662411c7f26e7fc7320 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Wed, 2 Jan 2019 21:19:09 -0500
Subject: [PATCH 22/29] change to versions 8,10, lastest

---
 .travis.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 0a1fb98..7e91203 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,8 +8,9 @@ sudo: false
 language: node_js
 
 node_js:
-  - "6.14.3"
+  - "8"
   - "10"
+  - "latest"
 
 install:
   - npm install

From 400af562e43c1b64abee372bc6f713b9f68f87d2 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Wed, 2 Jan 2019 21:22:54 -0500
Subject: [PATCH 23/29] change from "latest" to "node" as described by

https://github.com/dwyl/learn-travis
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 7e91203..5257f5a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -10,7 +10,7 @@ language: node_js
 node_js:
   - "8"
   - "10"
-  - "latest"
+  - "node"
 
 install:
   - npm install

From bb15d49b12375bc819b5806ad75062ec72e46b0c Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Fri, 4 Jan 2019 15:48:41 -0500
Subject: [PATCH 24/29] remove older time.cc file

---
 src/time.cc | 162 ----------------------------------------------------
 1 file changed, 162 deletions(-)
 delete mode 100644 src/time.cc

diff --git a/src/time.cc b/src/time.cc
deleted file mode 100644
index 3b4f4bb..0000000
--- a/src/time.cc
+++ /dev/null
@@ -1,162 +0,0 @@
-#include <stdio.h>
-#include <stdint.h>
-#include <time.h>
-
-#include "nan.h"
-
-using namespace node;
-using namespace v8;
-
-class Time {
-  public:
-  static void Init(Handle<Object> target) {
-    Nan::HandleScope scope;
-
-    // time(3)
-    Nan::SetMethod(target, "time", Time_);
-
-    // tzset(3)
-    Nan::SetMethod(target, "tzset", Tzset);
-
-    // localtime
-    Nan::SetMethod(target, "localtime", Localtime);
-
-    // mktime
-    Nan::SetMethod(target, "mktime", Mktime);
-  }
-
-  static NAN_METHOD(Time_) {
-    Nan::EscapableHandleScope scope;
-    info.GetReturnValue().Set(scope.Escape(Nan::New<v8::Number>(time(NULL))));
-  }
-
-  static NAN_METHOD(Tzset) {
-    Nan::EscapableHandleScope scope;
-
-    // Set up the timezone info from the current TZ environ variable
-    tzset();
-
-    // Set up a return object that will hold the results of the timezone change
-    Local<Object> obj = Nan::New<v8::Object>();
-
-    // The 'tzname' char * [] gets put into a JS Array
-    int tznameLength = 2;
-    Local<Array> tznameArray = Nan::New<v8::Array>( tznameLength );
-#if _MSC_VER >= 1900
-	char szTzName[128];
-
-	for (int i = 0; i < tznameLength; i++) {
-		size_t strLength;
-		_get_tzname(&strLength, szTzName, 128, i);
-		Nan::Set(tznameArray, i, Nan::New<v8::String>(szTzName).ToLocalChecked());
-	}
-
-	Nan::Set(obj, Nan::New("tzname").ToLocalChecked(), tznameArray);
-
-	// The 'timezone' long is the "seconds West of UTC"
-	long timezone;
-	// MS C++ specific
-	// https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-timezone?view=vs-2017
-	_get_timezone(&timezone);
-	Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::Number>(timezone));
-
-	// The 'daylight' int is obselete actually, but I'll include it here for
-	// curiosity's sake. See the "Notes" section of "man tzset"
-	int daylight;
-	_get_daylight(&daylight);
-	Nan::Set(obj, Nan::New("daylight").ToLocalChecked(), Nan::New<v8::Number>(daylight));
-#else
-    for (int i=0; i < tznameLength; i++) {
-      Nan::Set(tznameArray, i, Nan::New<v8::String>(tzname[i]).ToLocalChecked());
-    }
-
-    Nan::Set(obj, Nan::New("tzname").ToLocalChecked(), tznameArray);
-
-    // The 'timezone' long is the "seconds West of UTC"
-    Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::Number>( timezone ));
-
-    // The 'daylight' int is obselete actually, but I'll include it here for
-    // curiosity's sake. See the "Notes" section of "man tzset"
-    Nan::Set(obj, Nan::New("daylight").ToLocalChecked(), Nan::New<v8::Number>( daylight ));
-#endif
-    info.GetReturnValue().Set(scope.Escape(obj));
-  }
-
-  static NAN_METHOD(Localtime) {
-    Nan::EscapableHandleScope scope;
-
-    // Construct the 'tm' struct
-    time_t rawtime = static_cast<time_t>(info[0]->IntegerValue());
-    struct tm *timeinfo = localtime( &rawtime );
-
-    // Create the return "Object"
-    Local<Object> obj = Nan::New<v8::Object>();
-
-    if (timeinfo) {
-      Nan::Set(obj, Nan::New("seconds").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_sec) );
-      Nan::Set(obj, Nan::New("minutes").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_min) );
-      Nan::Set(obj, Nan::New("hours").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_hour) );
-      Nan::Set(obj, Nan::New("dayOfMonth").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_mday) );
-      Nan::Set(obj, Nan::New("month").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_mon) );
-      Nan::Set(obj, Nan::New("year").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_year) );
-      Nan::Set(obj, Nan::New("dayOfWeek").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_wday) );
-      Nan::Set(obj, Nan::New("dayOfYear").ToLocalChecked(), Nan::New<v8::Integer>(timeinfo->tm_yday) );
-      Nan::Set(obj, Nan::New("isDaylightSavings").ToLocalChecked(), Nan::New<v8::Boolean>(timeinfo->tm_isdst > 0) );
-
-#if defined HAVE_TM_GMTOFF
-      // Only available with glibc's "tm" struct. Most Linuxes, Mac OS X...
-      Nan::Set(obj, Nan::New("gmtOffset").ToLocalChecked(), Nan::New<v8::Number>(timeinfo->tm_gmtoff) );
-      Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New(timeinfo->tm_zone).ToLocalChecked() );
-
-#elif defined HAVE_TIMEZONE
-      // Compatibility for Cygwin, Solaris, probably others...
-      long scd;
-      if (timeinfo->tm_isdst > 0) {
-  #ifdef HAVE_ALTZONE
-        scd = -altzone;
-  #else
-        scd = -timezone + 3600;
-  #endif // HAVE_ALTZONE
-      } else {
-        scd = -timezone;
-      }
-      Nan::Set(obj, Nan::New("gmtOffset").ToLocalChecked(), Nan::New<v8::Integer>(scd));
-      Nan::Set(obj, Nan::New("timezone").ToLocalChecked(), Nan::New<v8::String>(tzname[timeinfo->tm_isdst]));
-#endif // HAVE_TM_GMTOFF
-    } else {
-      Nan::Set(obj, Nan::New("invalid").ToLocalChecked(), Nan::New<v8::Boolean>(true));
-    }
-
-    info.GetReturnValue().Set(scope.Escape(obj));
-  }
-
-  static NAN_METHOD(Mktime) {
-    Nan::EscapableHandleScope scope;
-
-    if (info.Length() < 1) {
-      return Nan::ThrowTypeError("localtime() Object expected");
-    }
-
-    Local<Object> arg = info[0].As<v8::Object>();
-
-    struct tm tmstr;
-    tmstr.tm_sec   = Nan::Get(arg, Nan::New("seconds").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    tmstr.tm_min   = Nan::Get(arg, Nan::New("minutes").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    tmstr.tm_hour  = Nan::Get(arg, Nan::New("hours").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    tmstr.tm_mday  = Nan::Get(arg, Nan::New("dayOfMonth").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    tmstr.tm_mon   = Nan::Get(arg, Nan::New("month").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    tmstr.tm_year  = Nan::Get(arg, Nan::New("year").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    tmstr.tm_isdst = Nan::Get(arg, Nan::New("isDaylightSavings").ToLocalChecked()).ToLocalChecked()->Int32Value();
-    // tm_wday and tm_yday are ignored for input, but properly set after 'mktime' is called
-
-    info.GetReturnValue().Set(scope.Escape(Nan::New<v8::Number>(static_cast<double>(mktime( &tmstr )))));
-  }
-
-};
-
-extern "C" {
-  static void init (Handle<Object> target) {
-    Time::Init(target);
-  }
-  NODE_MODULE(time, init)
-}

From 4b8d16a2aeaf9c9c87fcfca73b80ed807c3cea57 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Fri, 4 Jan 2019 16:06:28 -0500
Subject: [PATCH 25/29] revert unit test changes that were used for break
 points in the debugger

---
 test/date.js | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/test/date.js b/test/date.js
index 98d8712..751406b 100644
--- a/test/date.js
+++ b/test/date.js
@@ -12,14 +12,13 @@ describe('Date', function () {
 
     it('should parse strings relative to TZ', function() {
 
-      var d = new time.Date('2012-1-12 02:00 PM', 'America/New_York');
-      var t = d.getTime();
-      assert.equal(t, 1326394800000);
-      assert.equal(d.getTimezone(), 'America/New_York');
-
-      d = new time.Date('2012-1-12 02:00 PM', 'America/Los_Angeles');
-      assert.equal(d.getTime(), 1326405600000);
-      assert.equal(d.getTimezone(), 'America/Los_Angeles');
+      var d = new time.Date('2012-1-12 02:00 PM', 'America/New_York')
+      assert.equal(d.getTime(), 1326394800000)
+      assert.equal(d.getTimezone(), 'America/New_York')
+
+      d = new time.Date('2012-1-12 02:00 PM', 'America/Los_Angeles')
+      assert.equal(d.getTime(), 1326405600000)
+      assert.equal(d.getTimezone(), 'America/Los_Angeles')
     })
 
     it('should interpret date parts relative to TZ', function() {
@@ -148,8 +147,7 @@ describe('Date', function () {
       assert.equal(d.getUTCMinutes(), d.getMinutes())
       assert.equal(d.getUTCMonth(), d.getMonth())
       assert.equal(d.getUTCSeconds(), d.getSeconds())
-      var tmo = d.getTimezoneOffset();
-      assert.equal(tmo, 0);
+      assert.equal(d.getTimezoneOffset(), 0)
     })
 
     it('should especially change the "hours" value', function () {

From b7f52171a389e72d2d3aa6eb1874201cbb4ea2de Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Fri, 4 Jan 2019 16:25:28 -0500
Subject: [PATCH 26/29] update appveyor windows testing to node 8-11

---
 appveyor.yml | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/appveyor.yml b/appveyor.yml
index 1f272e7..d317460 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -7,15 +7,10 @@ environment:
   # Test against these versions of Node.js and io.js
   matrix:
     # node.js
-    - nodejs_version: "0.10"
-    - nodejs_version: "0.12"
-    # io.js
-    - nodejs_version: "2"
-    - nodejs_version: "3.2"
-    - nodejs_version: "4"
-    - nodejs_version: "5"
-    - nodejs_version: "6"
-    - nodejs_version: "7"
+    - nodejs_version: "8"
+    - nodejs_version: "9"
+    - nodejs_version: "10"
+    - nodejs_version: "11"
 
 platform:
   - x86

From 3b06c853b71e683ce26700f1ff3843f0dc8906b1 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 15 Jan 2019 07:30:31 -0500
Subject: [PATCH 27/29] remove gypfile true from the package.json as the
 presence of binding.gyp serves this purpose now.

---
 package.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package.json b/package.json
index 75d8066..bce1fe4 100644
--- a/package.json
+++ b/package.json
@@ -37,6 +37,5 @@
   },
   "devDependencies": {
     "mocha": "*"
-  },
-  "gypfile": true
+  }
 }

From 95ec3ffe988552967bba9b1ae0c638facfa2c029 Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 15 Jan 2019 07:37:12 -0500
Subject: [PATCH 28/29] explicitly use node 11 and use 'node' to trigger a
 build against the very latest node ( currently 11.6.0 )

---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.travis.yml b/.travis.yml
index 5257f5a..6d5090a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -10,6 +10,7 @@ language: node_js
 node_js:
   - "8"
   - "10"
+  - "11"
   - "node"
 
 install:

From da83f48e5002c5c0f88958d5d76499c769287cfa Mon Sep 17 00:00:00 2001
From: Glenn Hinks <ghinks@yahoo.com>
Date: Tue, 15 Jan 2019 07:38:20 -0500
Subject: [PATCH 29/29] add comment on what travis mean by node version 'node'

---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.travis.yml b/.travis.yml
index 6d5090a..975666a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,6 +7,7 @@ sudo: false
 
 language: node_js
 
+# node version 'node' means the very latest point version
 node_js:
   - "8"
   - "10"