Infinite recursion in mnemonic_to_entropy_seed function in mnemonics.c

[quapka]

[PA193 Aller team here]

The function mnemonic_to_entropy_seed can be invoked in such a way, that it produces an infinite recursion.

While we've investigated the function further it seems, that the function mnemonic_to_seed should have probably be used instead of the recursive call to back to mnemonic_to_entropy_seed at this line.

The function mnemonic_to_entropy_seed is not mentioned in the README.md, however, it is exportable and documented in mnemonics.h, therefore anyone can get the feeling it can be used.

I'll add a new branch (in my fork) with a new test case, showing the bug (understandably, it leads to segmentation fault).

I'm not proposing any specific fix at the moment, because it can either be fixed or the function mnemonic_to_entropy_seed might get removed altogether (it does not add any functionality it just adds a bug now).

This issue is severe in the sense, that it can crash the whole application, that will call the function in question. The call to the function (as you can see in the branch, that will be linked soon) is not even improper one, it is called with valid arguments.

[quapka]

The branch fix-issue-29 contains the following commit, that triggers the infinite recursion.

[NimRo97]

Hey, thank you for the issue. It is a total bug I made because I did not bother to try those functions. As you said, those are completely redundant and we included them only because their combined functionality was in the assignment. Removing them altogether is the best fix. Good find :) I hope you find more :D

…

On Mon, Dec 9, 2019, 9:43 PM Jan Kvapil ***@***.***> wrote: The branch fix-issue-29 <https://github.com/quapka/PA193_mnemonic_BugsBunny/tree/fix-issue-29> contains the following commit <quapka@097149d>, that triggers the infinite recursion. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=AI5WNARCVLL3YOJOO52CEJLQX2UXPA5CNFSM4JYRVYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKUAFY#issuecomment-563429399>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI5WNAXJN2JDXGYE4RF3WTLQX2UXPANCNFSM4JYRVYHA> .

[quapka]

I've created a pull request to merge the fix into dev branch as them seems to be the way you work :)

[NimRo97]

Yep, that is the way. We wish a good luck on monday to your team :)

…

On Mon, Dec 9, 2019, 10:50 PM Jan Kvapil ***@***.***> wrote: I've created a pull request to merge the fix into dev branch as them seems to be the way you work :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=AI5WNAXEONEATRG72ICIHSLQX24QTA5CNFSM4JYRVYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGK2P7Q#issuecomment-563455998>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI5WNARVRO3MQR2UHX2R7XDQX24QTANCNFSM4JYRVYHA> .

[quapka]

Cool, thanks. Same to you guys!

[AlexInsa]

Thank you very much, and good luck for you and your team on monday too :)