Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in the SD3 Ultra Node should not stop the workflow #5

Open
EricRollei opened this issue Jul 21, 2024 · 0 comments
Open

errors in the SD3 Ultra Node should not stop the workflow #5

EricRollei opened this issue Jul 21, 2024 · 0 comments

Comments

@EricRollei
Copy link

EricRollei commented Jul 21, 2024

I often run a workflow with several branches using the same prompt to generate images based on the same prompt but different platforms - ie Dalle3, SDXL, SD3 Ultra, Pixart Sigma. SD3 Ultra has the most sensitive content violation parameters and quite often Dalle3 etc would continue to generate images however, SD3 Ultra node raises the error to a pop-up window instead of printing to the console, which halts the workflow. The SD3 Ultra node prints to the console a random generated image in base 64 (when ComfyUI is started with --verbose).

It would be so much better for the node to print the error to the console rather than raise a popup error window, and return an image (black, random, blurred) than halt the workflow. An enhanced version of the node would be one which also had a boolean output which could tell the workflow if an error had occurred.

Here's the error raised that halts the workflow below. SAI seems to be much more sensitive than Dalle3. I'm photobashing old classic paintings, and having OpenAI vision write prompts based on those. I'd say SAI triggers a content violation on 1/10 images where as Dalle3 hits it 1/50 but it never halts the workflow since it outputs a black image.

Error occurred when executing Stability Image Ultra:

Stability API Error: {'errors': ['Your request was flagged by our content moderation system, as a result your request was denied and you were not charged.'], 'id': 'ab2b9fdc35a7528e9a9cb3ba8fad7b3f', 'name': 'content_moderation'}

File "A:\Comfy_Dec\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "A:\Comfy_Dec\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "A:\Comfy_Dec\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "A:\Comfy_Dec\ComfyUI\custom_nodes\ComfyUI-SAI_API\stability_api.py", line 123, in call
raise Exception(f"Stability API Error: {error_info}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant