Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliders not working after update #28

Open
LoathingScreen opened this issue Jan 4, 2025 · 13 comments
Open

Sliders not working after update #28

LoathingScreen opened this issue Jan 4, 2025 · 13 comments

Comments

@LoathingScreen
Copy link

LoathingScreen commented Jan 4, 2025

Screenshot 2025-01-04 161654
Sliders are gone after updating comfy.
ComfyUI: v0.3.10-29-gd45ebb6 (2025-01-04)
Manager: V3.3.9
Also, that x next to the the output in the simple slider, can it be removed like it was before? it overlaps with the values and serves no purpose. Happy new year!

@anlin857
Copy link

anlin857 commented Jan 7, 2025

me to

@anlin857
Copy link

anlin857 commented Jan 7, 2025

Conflict with this plugin comfyui mixlab nodes

@annasophiachristianahahn

same issue

@annasophiachristianahahn

Conflict with this plugin comfyui mixlab nodes

getting rid of mixlab nodes fixes it?

@kakkkarot
Copy link

yes you can uninstall mix lab or disable it when using mx toolkit, that's what I did right now, I simply disabled it while working with mx tool kit, I will try downgrading mix lab to see if any of the versions can co exist in peace mx tool kit

@kakkkarot
Copy link

Conflict with this plugin comfyui mixlab nodes

getting rid of mixlab nodes fixes it?

yes you can uninstall mix lab or disable it when using mx toolkit, that's what I did right now, I simply disabled it while working with mx tool kit, I will try downgrading mix lab to see if any of the versions can co exist in peace mx tool kit

@SvetlanaReut
Copy link

Same problem. Disabling mixlab node really helps

@Smirnov75
Copy link
Owner

Hello everyone, thank you for pointing out the issue. Please send an example of simultaneous usage of the mxToolkit and mixlab nodes. I will take a look to see where the problem might be.

@sanebg
Copy link

sanebg commented Jan 18, 2025

same here, totally broken

@Smirnov75
Copy link
Owner

Smirnov75 commented Jan 20, 2025

In this case, the issue is definitely that mixlab overrides the onDrawForeground method of other nodes. I consider this unacceptable. Moreover, mixlab only uses this method if it is defined in the prototype. This results in display issues for other nodes that rely on this method.
To fix this problem, the line in ui_mixlab.js
https://github.com/shadowcz007/comfyui-mixlab-nodes/blob/67c974c96e6472316cb4bf4326281d9f86a25ae6/web/javascript/ui_mixlab.js#L2186C11-L2186C55
should be replaced with:
const orig = node.onDrawForeground ?? node.__proto__.onDrawForeground;
You can fix this yourself or pass this information on to the authors.

@mattymatty
Copy link

Thank you Smirnov75 that works like a perfect.

@ttboi123
Copy link

still having this issue, thank you for the Mixlab tip. Saved my workflow.

@Cyberstallker
Copy link

In this case, the issue is definitely that mixlab overrides the onDrawForeground method of other nodes. I consider this unacceptable. Moreover, mixlab only uses this method if it is defined in the prototype. This results in display issues for other nodes that rely on this method. To fix this problem, the line in ui_mixlab.js https://github.com/shadowcz007/comfyui-mixlab-nodes/blob/67c974c96e6472316cb4bf4326281d9f86a25ae6/web/javascript/ui_mixlab.js#L2186C11-L2186C55 should be replaced with: const orig = node.onDrawForeground ?? node.__proto__.onDrawForeground; You can fix this yourself or pass this information on to the authors.

Thanks! This solution really works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants