Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider UI appearance issue #21

Open
Spinaster opened this issue Sep 16, 2024 · 15 comments
Open

Slider UI appearance issue #21

Spinaster opened this issue Sep 16, 2024 · 15 comments

Comments

@Spinaster
Copy link

Hello, as you can see in the picture attached, the nodes UI it's completely different from the one showed in the examples.
Any suggestions?
Thank you.

Screenshot 2024-09-16 153622

@Smirnov75
Copy link
Owner

I have tested the nodes with the latest version of ComfyUI. Everything works correctly.
Which version of ComfyUI are you using, and how do you install the nodes?

@Spinaster
Copy link
Author

I'm using the latest version of Comfy and I installed via Manger.

@n0valis
Copy link

n0valis commented Sep 20, 2024

Same for me. ComfyUI v0.2.2 installed via Manager
And I do not see the reroute node.

@Atreia5710
Copy link

Do you have any messages in the browser console?
To launch ComfyUI, press "Ctrl+ Shift + J" to open the browser console, then create a "Slider" and "MxReroute" node. If you have any new messages/errors, please let us know.
If "Ctrl + Shift + J" does't work, press F12 and select "Console".

@n0valis
Copy link

n0valis commented Sep 20, 2024

I am not sure why I got this problem but after I checked on a fresh workspace I could not recreate the issue, so I guess I'm fine.
I got an error message though for a a slider, I'm not sure if it is of any concern I couldn't test it further. I connected a Slider to the steps value in KSampler. It says:
Uncaught TypeError: this.updateThisNodeGraph is not a function at MXSlider.node.onMouseMove (Slider.js:137:18) at __LGraphCanvas.processMouseMove (litegraph.es.js:5994:18) at LGraphCanvas.processMouseMove (simpleTouchSupport.ts:110:27) at LGraphCanvas.processMouseMove (app.ts:1240:9)

At last I want to mention that I still cannot find the reroute node in mxToolkit, there are only four nodes: Slider, Slider 2D, Stop and Seed. Where is the reroute supposed to be?

@Atreia5710
Copy link

At last I want to mention that I still cannot find the reroute node in mxToolkit, there are only four nodes: Slider, Slider 2D, Stop and Seed. Where is the reroute supposed to be?

RMB -> Add Node -> utils -> mxReroute

@PGCRT
Copy link

PGCRT commented Dec 5, 2024

ComfyUI: v0.3.7-1-g1e21f4c
(2024-12-05)
Manager: V2.55.3

2024-12-06 00_48_29-_CRT_FLUX SUPER (v2 10) (2) - ComfyUI

@Smirnov75
Copy link
Owner

It seems that your mxToolkit is not updated to the latest version - 0.9.7

@PGCRT
Copy link

PGCRT commented Dec 7, 2024

It is unfortunately, I also tried to uninstall and reinstall, didn't fix the issue, this is a very usefull node and I'm using it for a while sadly

@PGCRT
Copy link

PGCRT commented Dec 7, 2024

2024-12-07.02-44-29.mp4

@Smirnov75
Copy link
Owner

In the latest version of mxToolkit, the method for hiding these widgets has changed to align with updates in ComfyUI. Therefore, to ensure proper functionality, it is necessary to use the latest versions of both ComfyUI and mxToolkit.

Check the version directly by opening the file ComfyUI\custom_nodes\ComfyUI-mxToolkit\js\Slider.js
Also, take a look at this line:

for (let i=0; i<3; i++) this.node.widgets[i].hidden = true;

I just downloaded and performed a clean installation of the latest portable version of ComfyUI (0.3.7 windows), as well as installed mxToolkit via the Manager – everything is displaying correctly.

@PGCRT
Copy link

PGCRT commented Dec 7, 2024

I have this version
for (let i=0; i<3; i++) this.node.widgets[i].hidden = true;
this is up to date, as well as comfyUI

-ComfyUI: v0.3.7-4-g93477f8
(2024-12-06)
Manager: V2.55.4

I will try to reinstall eveything from the beginning

@PGCRT
Copy link

PGCRT commented Dec 7, 2024

So after reinstalling things seems to be fixed, still the same version of comfyUI with the same packages installed, so I can't explain what caused that unfortunately

Edit: after "update all" in comfyUI, the issue came back again

@Smirnov75
Copy link
Owner

Unfortunately, I was unable to reproduce this issue. Nevertheless, I have decided to use both the old and the new method for hiding widgets. I believe that using them simultaneously will not cause any problems.
The nodes have been updated to version 0.9.8.

@PGCRT
Copy link

PGCRT commented Dec 8, 2024

I updated, and yes this is properly displayed now, thank you
2024-12-08 18_29_31-_CRT_FLUX SUPER REDUX (v2 10) (2) - ComfyUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants