Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect remote bda and time_t bugs #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jasmaa
Copy link

@jasmaa jasmaa commented Feb 20, 2025

Notes

Library currently does not compile due to missing time_t type. It also connects briefly before disconnecting and does not receive any notifications.

This PR fixes both bugs. It:

  • Includes time.h header file in ble_notification.h
  • Passes in param->connect.remote_bda instead of incorrectly casted connectEventParam->remote_bda to ANCSBLEClient

It also whitespace autoformats all files and updates the minimal README example

Testing

Pulled my fork into Arduino/library and uploadedble_connection.ino example to ESP32. Connected to ESP32 in nRF app from iPhone and was able to successfully see push notifications in serial monitor:

Screenshot 2025-02-20 at 1 33 20 AM

@thanhbinh19395
Copy link

great, thank you very much for this, i used to stuck before, but i don't know much about C++ so i cannot fix it. Now it run smoothly with your fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants