Fix incorrect remote bda and time_t bugs #37
+620
−582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Library currently does not compile due to missing
time_t
type. It also connects briefly before disconnecting and does not receive any notifications.This PR fixes both bugs. It:
time.h
header file inble_notification.h
param->connect.remote_bda
instead of incorrectly castedconnectEventParam->remote_bda
to ANCSBLEClientIt also whitespace autoformats all files and updates the minimal README example
Testing
Pulled my fork into Arduino/library and uploaded
ble_connection.ino
example to ESP32. Connected to ESP32 in nRF app from iPhone and was able to successfully see push notifications in serial monitor: