Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Split file omitting logics #3

Closed
YooSunYoung opened this issue Mar 8, 2024 · 2 comments
Closed

[Refactoring] Split file omitting logics #3

YooSunYoung opened this issue Mar 8, 2024 · 2 comments
Assignees
@YooSunYoung
Milestone
Refactoring

Comments

@YooSunYoung
Copy link
Contributor

Granular issue of #2

We will start with splitting file omitting logics from ingestor.

Probably this part....??
https://github.com/SciCatProject/scicat-filewriter-ingest/blob/3c5c22ea4e606719e55b7999e407f18470b4e76c/ingestor_lib.py#L261-L279
@YooSunYoung YooSunYoung self-assigned this Mar 8, 2024
@YooSunYoung YooSunYoung added this to the Refactoring milestone Mar 11, 2024
@YooSunYoung YooSunYoung mentioned this issue Mar 12, 2024
Closed
1 task
@nitrosx
Copy link
Member

nitrosx commented Aug 1, 2024

@YooSunYoung should we close this issue?

@YooSunYoung
Copy link
Contributor Author

Fixed by #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YooSunYoung YooSunYoung

Labels
None yet
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
2 participants
@nitrosx @YooSunYoung