-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--disable-rpath has no effect on libsma.so #1162
Labels
Comments
I confirmed the bug --disable-rpath does not have any effect. There is no code in the configure script to handle this flag. |
markbrown314
added a commit
to markbrown314/SOS
that referenced
this issue
Feb 26, 2025
Issue Sandia-OpenSHMEM#1162 The build system relies on libtool to build libraries. libtool will insert a rpath into libraries unless you set hardcode_into_libs = no. Modified configury to set hardcode_into_libs if disable-rpath is set. Signed-off-by: Mark F. Brown <mark.f.brown@intel.com>
markbrown314
added a commit
to markbrown314/SOS
that referenced
this issue
Feb 26, 2025
Issue Sandia-OpenSHMEM#1162 The build system relies on libtool to build libraries. libtool will insert an rpath into libraries unless you set hardcode_into_libs = no. Modified configury to set hardcode_into_libs if disable-rpath is set. Signed-off-by: Mark F. Brown <mark.f.brown@intel.com>
This issue is caused by the generated libtool library setting the variable hardcode_into_libs to yes. |
@davidozog please validate whether PR #1188 resolves your issue and then I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On 5fb1d6e the
--disable-rpath
configure flag seems to have no effect on the linkage oflibsma.so
. However, it does seem to do the right thing (e.g., add-Wl,-rpath -Wl,/path/to/libfabric/lib -Wl,-rpath -Wl,/path/to/SOS/lib
) to the compiler wrappers (oshcc
and friends). I'm unsure if this is a regression.Thanks for the report @tmh97 and @bcernohous.
The text was updated successfully, but these errors were encountered: