chore: removed methods from the generated components' code

SAP · Feb 14, 2024 · ac7b8df · ac7b8df
1 parent 0031b49
commit ac7b8df
Show file tree

Hide file tree

Showing 4 changed files with 514 additions and 12,508 deletions.
diff --git a/libs/angular-generator/src/lib/ui5-webcomponents/component-file.ts b/libs/angular-generator/src/lib/ui5-webcomponents/component-file.ts
@@ -49,9 +49,6 @@ export class ComponentFile extends AngularGeneratedFile {
     if (this.componentData.inputs.length) {
       this.addImport(['ProxyInputs'], utilsFile.relativePathFrom);
     }
-    if (this.componentData.methods.length) {
-      this.addImport(['ProxyMethods'], utilsFile.relativePathFrom);
-    }
     if (this.componentData.formData.length > 0) {
       this.addImport(() => genericCva.className, genericCva.relativePathFrom);
     }
@@ -111,14 +108,6 @@ export class ComponentFile extends AngularGeneratedFile {
     ${i.name}${i.defaultValue ? '!' : '?'}: ${i.type}`).join(';\n');
   }
 
-  get methodsCode(): string {
-    return this.componentData.methods.map(m => `
-    /**
-     ${m.description}
-    */
-    ${m.name}!: ${this.componentData.baseName}['${m.name}']`).join(';\n');
-  }
-
   set cvaGetterCode(val: string) {
     this._cvaGetterCode = val;
   }
@@ -177,8 +166,6 @@ export class ComponentFile extends AngularGeneratedFile {
         this.cdr.detach();
         ${this.componentData.formData.length > 0 ? `this._cva.host = this;` : ''}
       }
-
-      ${this.methodsCode}
     }`;
   }
 
@@ -210,8 +197,7 @@ export class ComponentFile extends AngularGeneratedFile {
   private componentProxiesCode() {
     return [
       this.componentData.inputs.length ? `@ProxyInputs(${JSON.stringify(this.componentData.inputs.map(i => i.name))})` : '',
-      this.componentData.outputs.length ? `@ProxyOutputs(${JSON.stringify(this.componentData.outputs.map(i => `${i.name}: ${this.outputPublicName(i)}`))})` : '',
-      this.componentData.methods.length ? `@ProxyMethods(${JSON.stringify(this.componentData.methods.map(i => i.name))})` : '',
+      this.componentData.outputs.length ? `@ProxyOutputs(${JSON.stringify(this.componentData.outputs.map(i => `${i.name}: ${this.outputPublicName(i)}`))})` : ''
     ].join('\n');
   }
 }
diff --git a/libs/angular-generator/src/lib/ui5-webcomponents/utils.ts b/libs/angular-generator/src/lib/ui5-webcomponents/utils.ts
@@ -18,11 +18,6 @@ export class UtilsFile extends AngularGeneratedFile {
         exported: 'ProxyInputs',
         types: [ExportSpecifierType.Function]
       },
-      {
-        local: 'ProxyMethods',
-        exported: 'ProxyMethods',
-        types: [ExportSpecifierType.Function]
-      },
       {
         local: 'ProxyOutputs',
         exported: 'ProxyOutputs',
@@ -50,19 +45,6 @@ export class UtilsFile extends AngularGeneratedFile {
         }
       }
 
-      function ProxyMethods(methodNames: string[]) {
-        return (cls: any) => {
-          methodNames.forEach(methodName => {
-            cls.prototype[methodName] = function (...args: any[]) {
-              return this.zone.runOutsideAngular(() =>
-                // eslint-disable-next-line prefer-spread
-                this.element[methodName].apply(this.element, args)
-              );
-            };
-          });
-        }
-      }
-
       function ProxyOutputs(outputNames: string[]) {
         return (cls: any) => {
           outputNames.forEach((outputName) => {