New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End Date should be cloned in setter as well #31

Open

attiladonath opened this issue Jul 14, 2020 · 0 comments

attiladonath commented Jul 14, 2020

bat/src/Valuator/AbstractValuator.php

Line 75 in e69e314

$this->end_date = $end_date;

It is cloned in the constructor:

bat/src/Valuator/AbstractValuator.php

Line 52 in e69e314

$this->end_date = clone($end_date);

Start Date is cloned in the setter:

bat/src/Valuator/AbstractValuator.php

Line 61 in e69e314

$this->start_date = clone($start_date);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment