spherical to cartesian missing phi term. benign for analytical fields

RevathiJambunathan · RevathiJambunathan · commit f8a1f2f91920 · 2021-03-18T09:17:20.000-07:00
diff --git a/Source/Particles/PulsarParameters.H b/Source/Particles/PulsarParameters.H
@@ -169,7 +169,8 @@ namespace PulsarParm
              amrex::Real const phi, amrex::Real & F_x)
     {
         F_x = F_r     * std::sin(theta) * std::cos(phi)
-            + F_theta * std::cos(theta) * std::cos(phi);
+            + F_theta * std::cos(theta) * std::cos(phi)
+            - F_phi   * std::sin(phi);
     }
 
     AMREX_GPU_HOST_DEVICE AMREX_INLINE
@@ -179,7 +180,8 @@ namespace PulsarParm
              amrex::Real const phi, amrex::Real & F_y)
     {
         F_y = F_r     * std::sin(theta) * std::sin(phi)
-            + F_theta * std::cos(theta) * std::sin(phi);
+            + F_theta * std::cos(theta) * std::sin(phi)
+            + F_phi   * std::cos(phi);
     }
 
     AMREX_GPU_HOST_DEVICE AMREX_INLINE

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,8 @@ namespace PulsarParm`
`169`	`169`	`amrex::Real const phi, amrex::Real & F_x)`
`170`	`170`	`{`
`171`	`171`	`F_x = F_r * std::sin(theta) * std::cos(phi)`
`172`		`- + F_theta * std::cos(theta) * std::cos(phi);`
	`172`	`+ + F_theta * std::cos(theta) * std::cos(phi)`
	`173`	`+ - F_phi * std::sin(phi);`
`173`	`174`	`}`
`174`	`175`
`175`	`176`	`AMREX_GPU_HOST_DEVICE AMREX_INLINE`
`@@ -179,7 +180,8 @@ namespace PulsarParm`
`179`	`180`	`amrex::Real const phi, amrex::Real & F_y)`
`180`	`181`	`{`
`181`	`182`	`F_y = F_r * std::sin(theta) * std::sin(phi)`
`182`		`- + F_theta * std::cos(theta) * std::sin(phi);`
	`183`	`+ + F_theta * std::cos(theta) * std::sin(phi)`
	`184`	`+ + F_phi * std::cos(phi);`
`183`	`185`	`}`
`184`	`186`
`185`	`187`	`AMREX_GPU_HOST_DEVICE AMREX_INLINE`