Skip to content

Commit a9869a7

Browse files
authored
TEST-modin-project#6505: update python version for ASV benchmarks on HDK (modin-project#6504)
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
1 parent 29025b3 commit a9869a7

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/ci.yml

+4
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,10 @@ jobs:
265265
sed -i 's/def time_groupby_agg_nunique(self, \*args, \*\*kwargs):/# def time_groupby_agg_nunique(self, *args, **kwargs):/g' benchmarks/hdk/benchmarks.py
266266
sed -i 's/execute(self.df.groupby(by=self.groupby_columns).agg("nunique"))/# execute(self.df.groupby(by=self.groupby_columns).agg("nunique"))/g' benchmarks/hdk/benchmarks.py
267267
268+
# Otherwise, ASV considers that the environment has already been created, although ASV command is run for another config,
269+
# which requires the creation of a completely new environment. This step will be required after removing the manual environment setup step.
270+
rm -f -R .asv/env/
271+
268272
# TODO: Remove manual environment creation after fix https://github.com/airspeed-velocity/asv/issues/1310
269273
mamba env create -f ../requirements/env_hdk.yml
270274
conda activate modin_on_hdk

asv_bench/asv.conf.hdk.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
// The Pythons you'd like to test against. If not provided, defaults
3636
// to the current version of Python used to run `asv`.
37-
"pythons": ["3.7"],
37+
"pythons": ["3.8"],
3838

3939
// The list of conda channel names to be searched for benchmark
4040
// dependency packages in the specified order

asv_bench/asv.conf.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555

5656
// The Pythons you'd like to test against. If not provided, defaults
5757
// to the current version of Python used to run `asv`.
58-
// "pythons": ["3.7"],
58+
"pythons": ["3.8"],
5959

6060
// The list of conda channel names to be searched for benchmark
6161
// dependency packages in the specified order

0 commit comments

Comments
 (0)