Skip to content

Commit 8ad6ded

Browse files
authored
FIX-modin-project#6347: remove 'modin in the cloud' experimental feature (modin-project#6408)
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
1 parent d6eb589 commit 8ad6ded

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+19
-3569
lines changed

.github/workflows/ci-required.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
- run: python scripts/doc_checker.py scripts/doc_checker.py
9090
- run: |
9191
python scripts/doc_checker.py modin/experimental/pandas/io.py \
92-
modin/experimental/pandas/numpy_wrap.py modin/experimental/pandas/__init__.py
92+
modin/experimental/pandas/__init__.py
9393
- run: python scripts/doc_checker.py modin/core/storage_formats/base
9494
- run: python scripts/doc_checker.py modin/experimental/core/storage_formats/pyarrow
9595
- run: python scripts/doc_checker.py modin/core/storage_formats/pandas

.github/workflows/ci.yml

+2-33
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
with:
112112
environment-file: environment-dev.yml
113113
- name: Internals tests
114-
run: python -m pytest modin/core/execution/dispatching/factories/test/test_dispatcher.py modin/experimental/cloud/test/test_cloud.py
114+
run: python -m pytest modin/core/execution/dispatching/factories/test/test_dispatcher.py
115115
- run: python -m pytest modin/config/test
116116
- run: python -m pytest modin/test/test_envvar_catcher.py
117117
- run: python -m pytest modin/test/storage_formats/base/test_internals.py
@@ -651,37 +651,6 @@ jobs:
651651
- run: python -m pytest modin/pandas/test/test_io.py --verbose
652652
- uses: ./.github/actions/upload-coverage
653653

654-
test-cloud:
655-
needs: [lint-flake8, lint-black]
656-
runs-on: ubuntu-latest
657-
defaults:
658-
run:
659-
shell: bash -l {0}
660-
env:
661-
MODIN_ENGINE: "python"
662-
MODIN_EXPERIMENTAL: "True"
663-
name: test cloud
664-
services:
665-
moto:
666-
image: motoserver/moto
667-
ports:
668-
- 5000:5000
669-
env:
670-
AWS_ACCESS_KEY_ID: foobar_key
671-
AWS_SECRET_ACCESS_KEY: foobar_secret
672-
steps:
673-
- uses: actions/checkout@v3
674-
- uses: ./.github/actions/mamba-env
675-
with:
676-
environment-file: environment-dev.yml
677-
# TODO(https://github.com/modin-project/modin/issues/4004): Re-add
678-
# "python -m pytest --simulate-cloud=normal modin/pandas/test/test_io.py --verbose"
679-
# once that test stops crashing.
680-
- run: python -m pytest --simulate-cloud=normal modin/pandas/test/dataframe/test_default.py::test_kurt_kurtosis --verbose
681-
- # When running without parameters, some of the tests fail
682-
run: python -m pytest --simulate-cloud=normal modin/pandas/test/dataframe/test_binary.py::test_math_functions[add-rows-scalar]
683-
- uses: ./.github/actions/upload-coverage
684-
685654
test-pyarrow:
686655
needs: [lint-flake8, lint-black]
687656
runs-on: ubuntu-latest
@@ -735,7 +704,7 @@ jobs:
735704
- run: python -m pytest modin/experimental/spreadsheet/test/test_general.py
736705

737706
upload-coverage:
738-
needs: [test-internals, test-api-and-no-engine, test-defaults, test-hdk, test-all-unidist, test-all, test-experimental, test-cloud, test-sanity]
707+
needs: [test-internals, test-api-and-no-engine, test-defaults, test-hdk, test-all-unidist, test-all, test-experimental, test-sanity]
739708
if: always() # we need to run it regardless of some job being skipped, like in PR
740709
runs-on: ubuntu-latest
741710
defaults:

.github/workflows/codeql/codeql-config.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ name: "Modin CodeQL config"
22

33
paths:
44
- modin/**
5-
paths-ignore:
6-
- modin/experimental/cloud/** # TODO: fix module-level cyclic error, see #5228
5+
paths-ignore:
76
- modin/experimental/core/execution/native/implementations/hdk_on_native/test/** # TODO: fix unhashable list error, see #5227

MANIFEST.in

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
include versioneer.py
22
include modin/_version.py
3-
include modin/experimental/cloud/ray-autoscaler.yml
43
include modin/pandas/test/data/*.csv

docs/development/architecture.rst

-1
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,6 @@ details. The documentation covers most modules, with more docs being added every
338338
│ │ ├───dataframe
339339
│ │ │ └─── :doc:`pandas </flow/modin/distributed/dataframe/pandas>`
340340
│ ├─── :doc:`experimental </flow/modin/experimental/index>`
341-
│ │ ├───cloud
342341
│ │ ├───core
343342
│ │ │ ├───execution
344343
│ │ │ │ ├───native

docs/usage_guide/advanced_usage/index.rst

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Advanced Usage
1010
progress_bar
1111
modin_sql
1212
modin_xgboost
13-
modin_in_the_cloud
1413
modin_logging
1514
batch
1615

docs/usage_guide/advanced_usage/modin_in_the_cloud.rst

-78
This file was deleted.

docs/usage_guide/examples/index.rst

+1-6
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Modin Usage Examples
22
====================
33

44
This section shows Modin usage examples in different scenarios like Modin on a local/remote cluster,
5-
Modin in the cloud, the use of Modin spreadsheet.
5+
the use of Modin spreadsheet.
66

77
Tutorials
88
'''''''''
@@ -29,11 +29,6 @@ Data Science Benchmarks
2929
- Using Modin with the Census Dataset (coming soon...)
3030
- Using Modin with the Plasticc Dataset (coming soon...)
3131

32-
Modin in the Cloud
33-
''''''''''''''''''
34-
35-
- Using Experimental Modin in the cloud with the NYC Taxi Dataset on an AWS cluster [`Source <https://github.com/modin-project/modin/blob/master/examples/jupyter/NYC_Taxi_cloud.ipynb>`__]
36-
3732
Modin Spreadsheets
3833
''''''''''''''''''
3934

environment-dev.yml

+1-5
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,12 @@ dependencies:
4545
- xgboost>=1.7.1,<2.0.0
4646
- tqdm
4747

48-
## modin in the cloud dependencies
49-
- boto3
50-
- cloudpickle
51-
- rpyc==4.1.5
52-
5348
# dependencies for making release
5449
- pygithub>=v1.58.0
5550
- pygit2>=1.9.2
5651

5752
# test dependencies
53+
- boto3
5854
- coverage>=7.1.0
5955
- moto>=4.1.0
6056
- pytest>=7.2.1

examples/cloud/experimental_cloud.py

-35
This file was deleted.

examples/cloud/h2o-runner.py

-51
This file was deleted.

examples/cloud/taxi-runner.py

-77
This file was deleted.

0 commit comments

Comments
 (0)