Skip to content

Commit 5febff3

Browse files
authored
TEST-modin-project#4270: revert disabling time_groupby_agg_nunique ASV bench (modin-project#6564)
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
1 parent 5432da0 commit 5febff3

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/ci.yml

-5
Original file line numberDiff line numberDiff line change
@@ -257,11 +257,6 @@ jobs:
257257
MODIN_ASV_USE_IMPL=pandas asv run --quick --strict --show-stderr --launch-method=spawn \
258258
-b ^benchmarks -b ^io | tee benchmarks.log
259259
260-
# HDK: ERR_OUT_OF_CPU_MEM: Not enough host memory to execute the query (MODIN#4270)
261-
# just disable test for testing - it works well in a machine with more memory
262-
sed -i 's/def time_groupby_agg_nunique(self, \*args, \*\*kwargs):/# def time_groupby_agg_nunique(self, *args, **kwargs):/g' benchmarks/hdk/benchmarks.py
263-
sed -i 's/execute(self.df.groupby(by=self.groupby_columns).agg("nunique"))/# execute(self.df.groupby(by=self.groupby_columns).agg("nunique"))/g' benchmarks/hdk/benchmarks.py
264-
265260
# Otherwise, ASV considers that the environment has already been created, although ASV command is run for another config,
266261
# which requires the creation of a completely new environment. This step will be required after removing the manual environment setup step.
267262
rm -f -R .asv/env/

asv_bench/benchmarks/utils/data_shapes.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@
1919
from .compatibility import ASV_DATASET_SIZE, ASV_USE_STORAGE_FORMAT
2020

2121
RAND_LOW = 0
22-
RAND_HIGH = 1_000_000_000 if ASV_USE_STORAGE_FORMAT == "hdk" else 100
22+
# use a small number of unique values in Github actions to avoid OOM (mostly related to HDK)
23+
RAND_HIGH = (
24+
1_000_000_000
25+
if ASV_USE_STORAGE_FORMAT == "hdk" and ASV_DATASET_SIZE == "Big"
26+
else 100
27+
)
2328

2429
BINARY_OP_DATA_SIZE = {
2530
"big": [

0 commit comments

Comments
 (0)