Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Groovy #5

Open
th3morg opened this issue Oct 3, 2014 · 4 comments
Open

Incompatible with Groovy #5

th3morg opened this issue Oct 3, 2014 · 4 comments
Labels

Comments

@th3morg
Copy link

th3morg commented Oct 3, 2014

I really like your approach here and especially wanted to make use of your HAL Jackson serialization project. However, I'm using groovy and the "setProperty" method in your Resource/AbstractResource conflict with the GroovyObject. I get the following error:

The return type of com.strategicgains.hyperexpress.domain.Resource setProperty(java.lang.String, java.lang.Object) in com.strategicgains.hyperexpress.domain.AbstractResource is incompatible with void in groovy.lang.GroovyObject

If you could make the naming of methods more compatible with Groovy it would be of great benefit. Thank you!

@tfredrich
Copy link
Member

That is an interesting problem. I can work that in over time after deprecating the current methods for a bit. But it might be a while...

@th3morg
Copy link
Author

th3morg commented Nov 23, 2014

Todd, this is something that I might undertake if you are willing to have a look at a pull request.

On Nov 17, 2014, at 7:34 PM, Todd Fredrich notifications@github.com wrote:

That is an interesting problem. I can work that in over time after deprecating the current methods for a bit. But it might be a while...


Reply to this email directly or view it on GitHub.

@tfredrich
Copy link
Member

Pull-request away! :-)

@tfredrich
Copy link
Member

BTW, what should that method be named? If I call it 'property(Object)' and the corresponding 'Object property()' getter, will that work? Can I add those new methods or do I have to actually rename the old one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants