From ad123f2a7334dac8ea32d2886adcd5598bf196a4 Mon Sep 17 00:00:00 2001 From: HaiShaw Date: Tue, 18 Oct 2022 01:31:31 -0400 Subject: [PATCH] fix comment regarding the tbe dimensions supported --- fbgemm_gpu/codegen/embedding_forward_split_template.cu | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fbgemm_gpu/codegen/embedding_forward_split_template.cu b/fbgemm_gpu/codegen/embedding_forward_split_template.cu index 71d5343414..f07a6429c4 100644 --- a/fbgemm_gpu/codegen/embedding_forward_split_template.cu +++ b/fbgemm_gpu/codegen/embedding_forward_split_template.cu @@ -526,10 +526,9 @@ Tensor {{ "dense" if dense else "split" }}_embedding{{ "_nobag" if nobag else "" /* * current limitations 1. sparse, and bag - 2. embedding dims in [64, 128, 192, 256] - 3. yet to support mixed embedding dims (loosely guarded below) - 4. yet to support non-uniform table locations (all be on devs) - 5. yet to support duplicate tables from some cases in exact optim (fbgemm_gpu/split_embedding_configs.py) + 2. yet to support mixed embedding dims (loosely guarded below) + 3. yet to support non-uniform table locations (all be on devs) + 4. yet to support duplicate tables from some cases in exact optim (fbgemm_gpu/split_embedding_configs.py) */ {% if not nobag %} {% if not dense %}