Don't allow too many arguments to be sent to the map command (#673)

ASpoonPlaysGames · web-flow · commit e1eb2a6f4b85 · 2024-03-02T15:29:58.000+01:00
`map` should only take a single arg that specifies the map to load.
diff --git a/primedev/util/printmaps.cpp b/primedev/util/printmaps.cpp
@@ -200,7 +200,13 @@ AUTOHOOK(Host_Map_f, engine.dll + 0x15B340, void, __fastcall, (const CCommand& a
 {
 	RefreshMapList();
 
-	if (args.ArgC() > 1 &&
+	if (args.ArgC() > 2)
+	{
+		spdlog::warn("Map load failed: too many arguments provided");
+		return;
+	}
+	else if (
+		args.ArgC() == 2 &&
 		std::find_if(vMapList.begin(), vMapList.end(), [&](MapVPKInfo map) -> bool { return map.name == args.Arg(1); }) == vMapList.end())
 	{
 		spdlog::warn("Map load failed: {} not found or invalid", args.Arg(1));

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,13 @@ AUTOHOOK(Host_Map_f, engine.dll + 0x15B340, void, __fastcall, (const CCommand& a`
`200`	`200`	`{`
`201`	`201`	`RefreshMapList();`
`202`	`202`
`203`		`- if (args.ArgC() > 1 &&`
	`203`	`+ if (args.ArgC() > 2)`
	`204`	`+ {`
	`205`	`+ spdlog::warn("Map load failed: too many arguments provided");`
	`206`	`+ return;`
	`207`	`+ }`
	`208`	`+ else if (`
	`209`	`+ args.ArgC() == 2 &&`
`204`	`210`	`std::find_if(vMapList.begin(), vMapList.end(), [&](MapVPKInfo map) -> bool { return map.name == args.Arg(1); }) == vMapList.end())`
`205`	`211`	`{`
`206`	`212`	`spdlog::warn("Map load failed: {} not found or invalid", args.Arg(1));`