Imporve ONNX 1.14 compatibility (#134)

Author: cbourjau

CHANGELOG.rst

@@ -7,6 +7,14 @@
 Change log
 ==========
 
+0.10.1 (2023-02-07)
+-------------------
+
+**Other changes**
+
+- Spox's compatibility with older versions of onnx has been improved.
+
+
 0.10.0 (2023-02-02)
 -------------------
 

src/spox/_attributes.py

@@ -4,13 +4,15 @@
 
 import numpy as np
 import numpy.typing as npt
+import onnx
 from onnx import AttributeProto
 from onnx.helper import (
     make_attribute,
     make_optional_type_proto,
     make_sequence_type_proto,
     make_tensor_type_proto,
 )
+from packaging import version
 
 from spox import _type_system
 from spox._utils import dtype_to_tensor_type, from_array
@@ -210,9 +212,13 @@ def maybe(
         return cls(tuple(value), name) if value is not None else None
 
     def _to_onnx_deref(self) -> AttributeProto:
-        return make_attribute(
-            self._name, self.value, attr_type=self._attribute_proto_type
-        )
+        # 1.15 introduced attr_type which provides much better performance
+        if version.parse(onnx.__version__) >= version.parse("1.15"):
+            return make_attribute(
+                self._name, self.value, attr_type=self._attribute_proto_type
+            )
+        else:
+            return make_attribute(self._name, self.value)
 
 
 class AttrFloat32s(_AttrIterable[float]):

tests/type_inference/test_scaler.py

@@ -16,4 +16,4 @@ def test_scaler_inference():
 def test_scaler_inference_fails_mismatched_lengths():
     (x,) = arguments(x=Tensor(np.float64, ("N", 3)))
     with pytest.raises(InferenceError):
-        op_ml.scaler(x, offset=[0.0, 0.1], scale=[1])
+        op_ml.scaler(x, offset=[0.0, 0.1], scale=[1.0])