Bump actions/upload-artifact, fix wheel builds (#123)

Bumps
[actions/upload-artifact](https://github.com/actions/upload-artifact)
from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's
releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>The release of upload-artifact@v4 and download-artifact@v4 are major
changes to the backend architecture of Artifacts. They have numerous
performance and behavioral improvements.</p>
<p>For more information, see the <a
href="https://github.com/actions/toolkit/tree/main/packages/artifact"><code>@​actions/artifact</code></a>
documentation.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vmjoseph"><code>@​vmjoseph</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/upload-artifact/pull/464">actions/upload-artifact#464</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0">https://github.com/actions/upload-artifact/compare/v3...v4.0.0</a></p>
<h2>v3.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(github): remove trailing whitespaces by <a
href="https://github.com/ljmf00"><code>@​ljmf00</code></a> in <a
href="https://redirect.github.com/actions/upload-artifact/pull/313">actions/upload-artifact#313</a></li>
<li>Bump <code>@​actions/artifact</code> version to v1.1.2 by <a
href="https://github.com/bethanyj28"><code>@​bethanyj28</code></a> in <a
href="https://redirect.github.com/actions/upload-artifact/pull/436">actions/upload-artifact#436</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/upload-artifact/compare/v3...v3.1.3">https://github.com/actions/upload-artifact/compare/v3...v3.1.3</a></p>
<h2>v3.1.2</h2>
<ul>
<li>Update all <code>@actions/*</code> NPM packages to their latest
versions- <a
href="https://redirect.github.com/actions/upload-artifact/issues/374">#374</a></li>
<li>Update all dev dependencies to their most recent versions - <a
href="https://redirect.github.com/actions/upload-artifact/issues/375">#375</a></li>
</ul>
<h2>v3.1.1</h2>
<ul>
<li>Update actions/core package to latest version to remove
<code>set-output</code> deprecation warning <a
href="https://redirect.github.com/actions/upload-artifact/issues/351">#351</a></li>
</ul>
<h2>v3.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump <code>@​actions/artifact</code> to v1.1.0 (<a
href="https://redirect.github.com/actions/upload-artifact/pull/327">actions/upload-artifact#327</a>)
<ul>
<li>Adds checksum headers on artifact upload (<a
href="https://redirect.github.com/actions/toolkit/pull/1095">actions/toolkit#1095</a>)
(<a
href="https://redirect.github.com/actions/toolkit/pull/1063">actions/toolkit#1063</a>)</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/upload-artifact/commit/c7d193f32edcb7bfad88892161225aeda64e9392"><code>c7d193f</code></a>
Merge pull request <a
href="https://redirect.github.com/actions/upload-artifact/issues/466">#466</a>
from actions/v4-beta</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/13131bb095770b4070a7477c3cd2d96e1c16d9f4"><code>13131bb</code></a>
licensed cache</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/4a6c273b9834f66a1d05c170dc3f80f9cdb9def1"><code>4a6c273</code></a>
Merge branch 'main' into v4-beta</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/f391bb91a3d3118aeca171c365bb319ece276b37"><code>f391bb9</code></a>
Merge pull request <a
href="https://redirect.github.com/actions/upload-artifact/issues/465">#465</a>
from actions/robherley/v4-documentation</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/9653d03c4b74c32144e02dae644fea70e079d4b3"><code>9653d03</code></a>
Apply suggestions from code review</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/875b63076402f25ef9d52c294c86ba4f97810575"><code>875b630</code></a>
add limitations section</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/ecb21463e93740a6be75c3116242169bfdbcb15a"><code>ecb2146</code></a>
add compression example</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/5e7604f84a055838f64ed68bb9904751523081ae"><code>5e7604f</code></a>
trim some repeated info</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/d6437d07581fe318a364512e6cf6b1dca6b4f92c"><code>d6437d0</code></a>
naming</li>
<li><a
href="https://github.com/actions/upload-artifact/commit/1b561557037b4957d7d184e9aac02bec86c771eb"><code>1b56155</code></a>
s/v4-beta/v4/g</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/upload-artifact/compare/v3...v4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

> **Note**
> Automatic rebases have been disabled on this pull request as it has
been open for over 30 days.

---------

Co-authored-by: kklein <kevin.klein@quantco.com>
Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
Co-authored-by: Pavel Zwerschke <pavel.zwerschke@quantco.com>

Author: 3 people

.github/workflows/build_and_publish.yml

@@ -12,19 +12,24 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ ubuntu-20.04, windows-2019, macos-11 ]
+        # macos-13 is pre-ARM
+        os: [ ubuntu-24.04, windows-2019, macos-13, macos-latest ]
 
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: Build wheels
-        uses: pypa/cibuildwheel@v2.21.1
+        uses: pypa/cibuildwheel@7940a4c0e76eb2030e473a5f864f291f63ee879b # v2.21.3
+        env:
+          CIBW_SKIP: pp*
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
+          name: pytsql-wheel-${{ matrix.os }}
           path: ./wheelhouse/*.whl
+          if-no-files-found: error
 
   build_sdist:
     name: Build source distribution
@@ -37,22 +42,23 @@ jobs:
       - name: Build sdist
         run: pipx run build --sdist
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
+          name: pytsql-sdist
           path: dist/*.tar.gz
+          if-no-files-found: error
 
   upload_pypi:
     name: Upload to PyPI
     needs: [build_wheels, build_sdist]
+    environment: pypi
     runs-on: ubuntu-latest
     if: github.event_name == 'release' && github.event.action == 'published'
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: artifact
+          pattern: pytsql-*
+          merge-multiple: true
           path: dist
 
       - uses: pypa/gh-action-pypi-publish@v1.10.2
-        with:
-          user: __token__
-          password: ${{ secrets.PYPI_TOKEN }}

.github/workflows/ci.yaml

@@ -27,7 +27,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        PYTHON_VERSION: ['3.8', '3.9', '3.10', '3.11']
+        PYTHON_VERSION: ['3.9', '3.10', '3.11']
         OS: ['ubuntu-latest', 'windows-latest']
     steps:
       - name: Checkout branch
@@ -56,7 +56,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        PYTHON_VERSION: ['3.8', '3.9', '3.10', '3.11']
+        PYTHON_VERSION: ['3.9', '3.10', '3.11']
     services:
       DB:
         image: mcr.microsoft.com/mssql/server:2019-latest

environment.yml

@@ -3,7 +3,7 @@ channels:
   - conda-forge
   - nodefaults
 dependencies:
-  - python>=3.8
+  - python>=3.9
   - setuptools_scm
   - pre-commit
   - pytest
@@ -20,3 +20,4 @@ dependencies:
   - antlr4-python3-runtime==4.13.1 # keep `.github/workflows/update_grammar.yml` in sync
   - click
   - openjdk
+  - compilers

pyproject.toml

@@ -2,6 +2,10 @@
 requires = ['setuptools', 'setuptools-scm', 'wheel']
 build-backend = "setuptools.build_meta"
 
+[tool.setuptools_scm]
+version_scheme = "post-release"
+
+
 [project]
 name = "pytsql"
 description = "`Pytsql` allows to run mssql sripts, typically run via GUIs, via CLI."
@@ -25,7 +29,6 @@ classifiers = [
   "License :: OSI Approved :: BSD License",
   "Operating System :: OS Independent",
   "Programming Language :: Python :: 3",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
@@ -34,7 +37,7 @@ classifiers = [
 readme = "README.md"
 dynamic = ["version"]
 
-requires-python = ">=3.8.0"
+requires-python = ">=3.9"
 
 dependencies = [
     "sqlalchemy >=1.4",
@@ -70,8 +73,10 @@ module = "pytsql.grammar.*"
 follow_imports = "silent"
 
 [tool.ruff]
-ignore = ["E501", "N803", "N806"]
 line-length = 88
+
+[tool.ruff.lint]
+ignore = ["E501", "N803", "N806"]
 select = [
   # pyflakes
   "F",
@@ -84,8 +89,7 @@ select = [
   # pyupgrade
   "UP",
 ]
-target-version = "py38"
 exclude=["src/pytsql/grammar/**/*.py"]
 
-[tool.ruff.isort]
+[tool.ruff.lint.isort]
 known-first-party = ["pytsql"]

setup.py

@@ -1,22 +1,7 @@
 import glob
 import platform
-from time import time
 
 import setuptools
-from setuptools_scm.version import ScmVersion
-
-
-def get_dev_timestamp(version: ScmVersion) -> str:
-    """Return a new distribution version string.
-
-    Returns the version found in the git tag if currently checked out commit has a tag.
-    Otherwise, returns the version found in the most recent git tag, appended with
-    `dev` and the current timestamp in seconds.
-    """
-
-    if version.exact:
-        return version.format_with("{tag}")
-    return version.format_with(f"{{tag}}.dev{int(time())}")
 
 
 def get_platform() -> str:
@@ -61,10 +46,6 @@ def create_extension() -> setuptools.Extension:
 def run_setup():
     setuptools.setup(
         ext_modules=[create_extension()],
-        use_scm_version={
-            "version_scheme": get_dev_timestamp,
-            "local_scheme": "dirty-tag",
-        },
     )
 
 

src/pytsql/tsql.py

@@ -3,7 +3,7 @@
 import warnings
 from pathlib import Path
 from re import Match
-from typing import Any, Dict, List, Optional, Union
+from typing import Any, Optional, Union
 
 import antlr4.tree.Tree
 import sqlalchemy
@@ -28,7 +28,7 @@ def _code(path: Union[str, Path], encoding: str) -> str:
         return "\n".join(fh.readlines())
 
 
-def _process_replacement(line: str, parameters: Dict[str, Any]) -> str:
+def _process_replacement(line: str, parameters: dict[str, Any]) -> str:
     """Appropriately replace a single <replace> statement."""
     new_line = line.format(**parameters)
     if None in parameters.values():
@@ -42,7 +42,7 @@ def _process_replacement(line: str, parameters: Dict[str, Any]) -> str:
 
 def _parametrize(
     source: str,
-    parameters: Dict[str, Any],
+    parameters: dict[str, Any],
     start: str = _REPLACE_START,
     end: str = _REPLACE_END,
 ) -> str:
@@ -93,7 +93,7 @@ def __init__(self):
         # session information is lost after the execution of a batch.
         # We therefore need to manually prepend it to all following
         # batches.
-        self.dynamics: List[str] = []
+        self.dynamics: list[str] = []
 
     def visit(
         self, tree: TSqlParser.Sql_clausesContext, prepend_dynamics: bool = True
@@ -112,7 +112,7 @@ def visit(
 
         return " ".join(dynamics + chunks)
 
-    def visitChildren(self, node: antlr4.ParserRuleContext) -> List[str]:  # noqa: N802
+    def visitChildren(self, node: antlr4.ParserRuleContext) -> list[str]:  # noqa: N802
         if isinstance(node, TSqlParser.Print_statementContext):
             # Print statements are replaced by inserts into a temporary table so that they can be evaluated
             # at the right time and fetched afterwards.
@@ -129,15 +129,15 @@ def visitChildren(self, node: antlr4.ParserRuleContext) -> List[str]:  # noqa: N
 
         return result
 
-    def visitTerminal(self, node: antlr4.TerminalNode) -> List[str]:  # noqa: N802
+    def visitTerminal(self, node: antlr4.TerminalNode) -> list[str]:  # noqa: N802
         return [str(node)]
 
-    def defaultResult(self) -> List[str]:  # noqa: N802
+    def defaultResult(self) -> list[str]:  # noqa: N802
         return []
 
     def aggregateResult(  # noqa: N802
-        self, aggregate: List[str], next_result: List[str]
-    ) -> List[str]:
+        self, aggregate: list[str], next_result: list[str]
+    ) -> list[str]:
         return aggregate + next_result
 
 
@@ -158,7 +158,7 @@ def syntaxError(  # noqa: N802
         raise ValueError(f"Error parsing SQL script: {error_message}")
 
 
-def _split(code: str, isolate_top_level_statements: bool = True) -> List[str]:
+def _split(code: str, isolate_top_level_statements: bool = True) -> list[str]:
     if not USE_CPP_IMPLEMENTATION:
         warnings.warn(
             "Can not find C++ version of the parser, Python version will be used instead."
@@ -215,7 +215,7 @@ def _fetch_and_clear_prints(conn: Connection):
 def executes(
     code: str,
     engine: sqlalchemy.engine.Engine,
-    parameters: Optional[Dict[str, Any]] = None,
+    parameters: Optional[dict[str, Any]] = None,
     isolate_top_level_statements=True,
 ) -> None:
     """Execute a given sql string through a sqlalchemy.engine.Engine connection.
@@ -250,7 +250,7 @@ def executes(
 def execute(
     path: Union[str, Path],
     engine: sqlalchemy.engine.Engine,
-    parameters: Optional[Dict[str, Any]] = None,
+    parameters: Optional[dict[str, Any]] = None,
     isolate_top_level_statements=True,
     encoding: str = "utf-8",
 ) -> None:

tests/unit/test_py_vs_cpp.py

@@ -1,6 +1,5 @@
 import inspect
 import re
-from typing import List
 from unittest import mock
 
 import pytest
@@ -36,7 +35,7 @@ def seed():
 GROUP BY nr, short_nr;"""
 
 
-def get_rule_labels(context_cls: ParserRuleContext) -> List[str]:
+def get_rule_labels(context_cls: ParserRuleContext) -> list[str]:
     init_func = context_cls.__init__
 
     # Detect any context/token labels from the init function's assignments