🚑️ Fix corrupted Linear Release entries #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2025
Closed
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lrazovic
changed the title
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (03/04/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
lrazovic
force-pushed
the
03-03-fix_update_the_integration_tests
branch
from
890cc94 to
7f21caa
Compare
lrazovic
force-pushed
the
03-04-fix_corrupted_release_entries
branch
4 times, most recently
from
87f35dc to
6893689
Compare
lrazovic
force-pushed
the
03-03-fix_update_the_integration_tests
branch
from
7f21caa to
484326d
Compare
dastansam
reviewed
Mar 4, 2025
lrazovic
force-pushed
the
03-04-fix_corrupted_release_entries
branch
from
6893689 to
e6202a1
Compare
dastansam
approved these changes
Mar 5, 2025
Merge activity
|
lrazovic
changed the base branch from
03-03-fix_update_the_integration_tests
to
graphite-base/465
lrazovic
force-pushed
the
03-04-fix_corrupted_release_entries
branch
from
e6202a1 to
400b6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
During a previous runtime upgrade, we simplified the
RuntimeHoldReason, but we forgot to migrate theLinearRelease:Vestingkeys to reflect this change.Reasoning
I tried to
translatethe current entries, but the types were conflicting. Then I started todrainthe entries and add the new ones, but since I was operating on the same storage I had few non deterministic results. Since we only have 15 entries, I decided to perform a simple migration that removes the current corrupted entries, and create new ones, with the right key.Testing
Tested via
chopsticksand via thetry-runtime-cliNew Migration:
Vestinginruntimes/polimec/src/custom_migrations/linear_release.rs. (runtimes/polimec/src/custom_migrations/linear_release.rs- runtimes/polimec/src/custom_migrations/linear_release.rsR1-R110)mod.rsandlib.rsfiles of thepolimecruntime. (runtimes/polimec/src/custom_migrations/mod.rs- [1]runtimes/polimec/src/lib.rs- [2]Dependency Updates:
jwt-compactandsubstrate-fixeddependencies inCargo.tomlto use specific versions instead of git references. (Cargo.toml- Cargo.tomlL76-R84)Integration Tests Configuration:
stdarray inintegration-tests/Cargo.toml. (integration-tests/Cargo.toml- integration-tests/Cargo.tomlR152).gitignoreandpackage.jsonfiles to theintegration-tests/chopsticks/.papi/descriptorsdirectory. (integration-tests/chopsticks/.papi/descriptors/.gitignore- [1]integration-tests/chopsticks/.papi/descriptors/package.json- [2]polkadot-api.jsonconfiguration file for integration tests. (integration-tests/chopsticks/.papi/polkadot-api.json- integration-tests/chopsticks/.papi/polkadot-api.jsonR1-R24)