♻️ Fix weight annotations #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
JuaniRios
force-pushed
the
02-21-hydration_test
branch
from
155e373 to
50ead17
Compare
JuaniRios
force-pushed
the
02-26-fix_weight_annotations
branch
3 times, most recently
from
0c9ef9e to
457e2ee
Compare
lrazovic
force-pushed
the
02-26-fix_weight_annotations
branch
from
457e2ee to
a5385e6
Compare
lrazovic
force-pushed
the
02-21-hydration_test
branch
from
50ead17 to
1cd640f
Compare
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (02/28/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
lrazovic
approved these changes
Mar 3, 2025
This was referenced Mar 3, 2025
lrazovic
force-pushed
the
02-26-fix_weight_annotations
branch
from
a5385e6 to
9680c0c
Compare
lrazovic
force-pushed
the
graphite-base/461
branch
from
1cd640f to
129619f
Compare
lrazovic
changed the base branch from
graphite-base/461
to
02-20-replace_weth_with_eth
Merge activity
|
lrazovic
changed the base branch from
02-20-replace_weth_with_eth
to
graphite-base/461
lrazovic
force-pushed
the
02-26-fix_weight_annotations
branch
from
9680c0c to
57756e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request primarily involves renaming the
WETHidentifier toETHacross various files and making some adjustments to the auction bidding logic. The most important changes are summarized below:Identifier Renaming:
integration-tests/chopsticks/README.md: Updated references fromWETHtoETHin the TODO list.integration-tests/chopsticks/overrides/polimec.ts: ReplacedWETH_ADDRESSwithETH_ADDRESSand updated initial balances and supply references. [1] [2]integration-tests/chopsticks/src/constants.ts: RenamedWETHtoETHin initial balances and transfer amounts.integration-tests/chopsticks/src/transfers/BridgeToPolimec.ts: ChangedWETH_ADDRESStoETH_ADDRESS.integration-tests/src/constants.rs: Renamedwethtoethin thePricesandPricesBuilderstructs and related functions. [1] [2] [3] [4] [5] [6] [7] [8]Auction Bidding Logic:
pallets/funding/src/functions/3_auction.rs: Modified thedo_bidfunction to returnDispatchResultWithPostInfoand added weight calculation for bid calls. [1] [2] [3] [4] [5]Miscellaneous:
integration-tests/src/tests/defaults.rs: Added a sandbox test forWeightInfo::bid.pallets/funding/Cargo.toml: Removedpallet-xcmreferences from various sections. [1] [2] [3] [4]pallets/funding/src/benchmarking.rs: Updated references fromweth_pricetoeth_price.pallets/funding/src/instantiator/calculations.rs: ReplacedWETHwithETHin the list of accepted funding assets.These changes ensure consistency in naming conventions and improve the auction bidding process by incorporating weight calculations.