Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Replace WETH with Ethereum-native ETH #459

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Feb 20, 2025

What

This PR includes a series of changes to update the asset references from WETH to ETH across multiple files in the integration tests. The changes ensure consistency in naming and update the relevant asset locations, constants, and test cases.

Key changes include:

Asset Reference Updates:

  • Updated the weth_location to eth_location and modified its structure in integration-tests/chopsticks/overrides/polimec.ts.
  • Replaced weth_location with eth_location in the polimec_storage export in integration-tests/chopsticks/overrides/polimec.ts.
  • Updated the Metadata entry to use eth_location instead of weth_location in integration-tests/chopsticks/overrides/polimec.ts.

Constant and Enum Updates:

  • Changed WETH_AMOUNT to ETH_AMOUNT in integration-tests/chopsticks/src/constants.ts.
  • Updated the Asset enum to replace WETH with ETH in integration-tests/chopsticks/src/types.ts.

Manager and Transfer Updates:

  • Replaced WETH with ETH in various manager classes (BridgeHubManager, PolimecManager, PolkadotHubManager, PolkadotManager) in integration-tests/chopsticks/src/managers. [1] [2] [3] F4258a6L46R46)
  • Updated transfer test cases to use ETH instead of WETH in integration-tests/chopsticks/src/tests/bridge.test.ts and integration-tests/chopsticks/src/transfers/BridgeToPolimec.ts. [1] [2]

Additional Changes:

  • Removed outdated comments and adjusted vesting schedule blocks in integration-tests/src/tests/evaluator_slash_sideffects.rs. [1] [2]
  • Updated Oracle test cases to use ETH instead of WETH in integration-tests/src/tests/oracle.rs. [1] [2] [3] [4]

@JuaniRios JuaniRios force-pushed the 02-20-replace_weth_with_eth branch from 9815cee to cd1c753 Compare February 20, 2025 14:20
@JuaniRios JuaniRios force-pushed the 02-20-remove_contribution_remainder_leftovers branch from f560133 to 0394eca Compare February 21, 2025 12:54
@JuaniRios JuaniRios force-pushed the 02-20-replace_weth_with_eth branch from cd1c753 to cb3703e Compare February 21, 2025 12:54
@JuaniRios JuaniRios force-pushed the 02-20-replace_weth_with_eth branch from cb3703e to a9d222b Compare February 26, 2025 14:15
@lrazovic lrazovic force-pushed the 02-20-remove_contribution_remainder_leftovers branch from 0394eca to c121786 Compare February 27, 2025 13:14
@lrazovic lrazovic force-pushed the 02-20-replace_weth_with_eth branch from a9d222b to 129619f Compare February 27, 2025 13:14
@lrazovic lrazovic marked this pull request as ready for review February 28, 2025 15:02
Copy link

graphite-app bot commented Feb 28, 2025

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (02/28/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@lrazovic lrazovic changed the title Replace WETH with ETH ♻️ Replace WETH with Ethereum-native ETH Mar 4, 2025
Copy link
Member

lrazovic commented Mar 5, 2025

Merge activity

  • Mar 5, 4:29 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 4:30 AM EST: Graphite couldn't merge this pull request because a downstack PR 🔥 Funding Rounds Simplification #436 failed to merge.
  • Mar 5, 4:34 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 5:00 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 5, 5:02 AM EST: A user merged this pull request with Graphite.

@lrazovic lrazovic changed the base branch from 02-20-remove_contribution_remainder_leftovers to graphite-base/459 March 5, 2025 09:57
@lrazovic lrazovic changed the base branch from graphite-base/459 to main March 5, 2025 09:59
@lrazovic lrazovic force-pushed the 02-20-replace_weth_with_eth branch from 129619f to c14ed54 Compare March 5, 2025 10:00
@lrazovic lrazovic merged commit bf4c2f1 into main Mar 5, 2025
1 check passed
@lrazovic lrazovic deleted the 02-20-replace_weth_with_eth branch March 5, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants