Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Cleanup Credentials Serialization #440

Merged
merged 1 commit into from
Mar 5, 2025
Merged

🧹 Cleanup Credentials Serialization #440

merged 1 commit into from
Mar 5, 2025
+27 −43

Conversation

lrazovic
Copy link
Member

@lrazovic lrazovic commented Jan 27, 2025 •
edited
Loading

What?

Refactor the JWT serialization/deserialization to avoid unnecessary clone and/or conversions.

This was referenced Jan 27, 2025
Merged
Merged
@lrazovic Graphite App
Copy link
Member Author

lrazovic commented Jan 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lrazovic lrazovic mentioned this pull request Jan 27, 2025
Merged
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 9154851 to 4dbbc29 Compare January 27, 2025 10:38
@lrazovic lrazovic changed the base branch from 12-04-weth_integration_test to main January 27, 2025 10:38
@lrazovic lrazovic marked this pull request as ready for review January 27, 2025 10:40
@lrazovic lrazovic requested a review from JuaniRios January 27, 2025 10:40
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 4dbbc29 to 01918cb Compare January 27, 2025 10:42
@lrazovic lrazovic changed the base branch from main to 01-16-funding_rounds_simplification January 27, 2025 10:42
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 27, 2025

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (01/27/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 01918cb to 4ffa0d5 Compare January 27, 2025 10:45
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from fd15985 to 56153dd Compare January 28, 2025 13:44
This was referenced Jan 28, 2025
Closed
Closed
Closed
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 56153dd to 9e5b785 Compare February 3, 2025 08:25
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 4ffa0d5 to 5bd87f1 Compare February 3, 2025 08:25
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 9e5b785 to d2317e5 Compare February 3, 2025 09:27
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 5bd87f1 to 88ab03d Compare February 3, 2025 09:27
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from d2317e5 to afe14ff Compare February 4, 2025 12:46
This was referenced Feb 4, 2025
Closed
Closed
Merged
@JuaniRios JuaniRios force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 88ab03d to f61a62d Compare February 5, 2025 16:29
@JuaniRios JuaniRios changed the title refactor: cleanup credentials serialization 🧹 Cleanup Credentials Serialization Feb 5, 2025
This was referenced Feb 6, 2025
Merged
Merged
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from 8482103 to 2f5b7de Compare February 11, 2025 13:26
@JuaniRios JuaniRios force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 95583d0 to e3c2999 Compare February 11, 2025 13:27
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 2f5b7de to 55cf347 Compare February 11, 2025 14:37
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from e3c2999 to e46808c Compare February 11, 2025 14:37
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 55cf347 to 10e3d1c Compare February 11, 2025 14:39
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from e46808c to ecc1d3d Compare February 11, 2025 14:39
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from 10e3d1c to 6a43374 Compare February 12, 2025 12:15
@JuaniRios JuaniRios force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from ecc1d3d to 2139407 Compare February 12, 2025 12:15
This was referenced Feb 12, 2025
Closed
Closed
Merged
Merged
Merged
Closed
This was referenced Feb 20, 2025
Merged
Merged
Closed
Merged
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from 2139407 to ecc1d3d Compare February 27, 2025 13:14
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 6a43374 to 10e3d1c Compare February 27, 2025 13:14
This was referenced Feb 27, 2025
Merged
Merged
Merged
@lrazovic Graphite App
Copy link
Member Author

lrazovic commented Mar 5, 2025 •
edited
Loading

Merge activity

  • Mar 5, 4:29 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 4:30 AM EST: Graphite couldn't merge this pull request because a downstack PR 🔥 Funding Rounds Simplification #436 failed to merge.
  • Mar 5, 4:34 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 4:36 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 5, 4:38 AM EST: A user merged this pull request with Graphite.

@lrazovic lrazovic changed the base branch from 01-16-funding_rounds_simplification to graphite-base/440 March 5, 2025 09:30
@lrazovic lrazovic changed the base branch from graphite-base/440 to main March 5, 2025 09:35
@lrazovic lrazovic force-pushed the 01-27-refactor_cleanup_credentials_serialization branch from ecc1d3d to 38ca89e Compare March 5, 2025 09:36
@lrazovic lrazovic merged commit 7274aff into main Mar 5, 2025
1 check passed
@lrazovic lrazovic deleted the 01-27-refactor_cleanup_credentials_serialization branch March 5, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuaniRios JuaniRios JuaniRios approved these changes

Assignees

@lrazovic lrazovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrazovic @JuaniRios