Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Funding Rounds Simplification #436

Merged
merged 1 commit into from
Mar 5, 2025
Merged

🔥 Funding Rounds Simplification #436

merged 1 commit into from
Mar 5, 2025

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jan 16, 2025 •
edited
Loading

What?

  • Remove Community and Remainder rounds
  • Min ticket size is now 10 USD for all investor types
  • Extend auction round to occupy the time of the other rounds
  • Replace default test evaluations and bids with custom generators from the instantiator
  • Round finished after Auction

Why?

  • Makes for a simpler UX

Testing?

  • Re-test everything, and amend the e2e test
  • Contribution tests deleted
  • Some test related to contributions but not in that file also deleted

This was referenced Jan 16, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jan 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios mentioned this pull request Jan 16, 2025
Merged
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch from a59a348 to 0f3e3c3 Compare January 16, 2025 12:24
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from e4a4859 to a8d9bea Compare January 16, 2025 12:24
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch from 0f3e3c3 to 7f890ac Compare January 16, 2025 12:29
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from a8d9bea to e8d1a67 Compare January 16, 2025 12:29
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch from 7f890ac to f450e98 Compare January 16, 2025 13:29
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from e8d1a67 to 2f93325 Compare January 16, 2025 13:29
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch 2 times, most recently from 3bd6afa to c4a5ce5 Compare January 16, 2025 13:30
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from 2f93325 to a9fab64 Compare January 16, 2025 13:30
@JuaniRios JuaniRios self-assigned this Jan 16, 2025
@JuaniRios JuaniRios requested a review from lrazovic January 16, 2025 13:55
@lrazovic lrazovic force-pushed the 12-04-weth_integration_test branch from c4a5ce5 to 0357a95 Compare January 16, 2025 13:55
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from a9fab64 to c77c4be Compare January 16, 2025 13:57
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch from e353c5d to 5e31004 Compare January 16, 2025 14:25
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from c77c4be to e280079 Compare January 16, 2025 14:25
@JuaniRios JuaniRios mentioned this pull request Jan 16, 2025
Merged
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch from d6cd303 to 318f489 Compare January 16, 2025 15:32
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from e280079 to b4129b2 Compare January 16, 2025 15:33
@JuaniRios JuaniRios force-pushed the 12-04-weth_integration_test branch 2 times, most recently from 143e9a2 to 4bdc0df Compare January 16, 2025 15:37
@lrazovic lrazovic force-pushed the 12-04-weth_integration_test branch from a37d455 to 308bb6d Compare February 11, 2025 10:35
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from afe14ff to 8482103 Compare February 11, 2025 10:35
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from 8482103 to 2f5b7de Compare February 11, 2025 13:26
@lrazovic lrazovic force-pushed the 12-04-weth_integration_test branch from 308bb6d to 13693b4 Compare February 11, 2025 14:37
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 2f5b7de to 55cf347 Compare February 11, 2025 14:37
@lrazovic lrazovic force-pushed the 12-04-weth_integration_test branch from 13693b4 to e22194d Compare February 11, 2025 14:39
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 55cf347 to 10e3d1c Compare February 11, 2025 14:39
@JuaniRios JuaniRios force-pushed the 01-16-funding_rounds_simplification branch from 10e3d1c to 6a43374 Compare February 12, 2025 12:15
This was referenced Feb 12, 2025
Closed
Closed
Merged
Merged
Merged
Closed
This was referenced Feb 20, 2025
Merged
Merged
Closed
Merged
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 6a43374 to 10e3d1c Compare February 27, 2025 13:14
@lrazovic lrazovic mentioned this pull request Feb 27, 2025
Merged
This was referenced Mar 3, 2025
Merged
Merged
@lrazovic Graphite App
Copy link
Member

lrazovic commented Mar 5, 2025 •
edited
Loading

Merge activity

  • Mar 5, 4:29 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 4:30 AM EST: Graphite couldn't merge this PR because it failed for an unknown reason (Your push would publish a private email address. You can make your email public or disable this protection on GitHub).
  • Mar 5, 4:34 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 4:34 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 5, 4:35 AM EST: A user merged this pull request with Graphite.

@lrazovic lrazovic changed the base branch from 12-04-weth_integration_test to graphite-base/436 March 5, 2025 09:29
@lrazovic lrazovic changed the base branch from graphite-base/436 to main March 5, 2025 09:29
@lrazovic lrazovic force-pushed the 01-16-funding_rounds_simplification branch from 10e3d1c to 2d0d0f7 Compare March 5, 2025 09:34
@lrazovic lrazovic merged commit 4904ce6 into main Mar 5, 2025
1 check passed
@lrazovic lrazovic deleted the 01-16-funding_rounds_simplification branch March 5, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic