Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagine module - gate output behavior when read head over black color #12

Open
Loop-s opened this issue Oct 9, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@Loop-s
Copy link

Loop-s commented Oct 9, 2023

A possible issue with the gate output of your imagine module :

When loading a b&w image in your module and setting the mode to “vinyl”, I expected the gate output to always be 0v whenever the read head would be above the color black. But if you look between the 0:09 and 0:14 mark in this video (https://youtu.be/inIrWf5oIa8), sometimes the read head over black will output a constant 10v value instead.

If you could consider adding this more traditional behavior as an option for how the gate output work, it would be greatly appreciated.

Thanks,
Loops

@Paul-Dempsey
Copy link
Owner

This was my response on the community forum, to provide more context here:

The gate logic is not looking at levels in the conventional way. It’s not open on rising voltage and close on falling voltage. It’s a flip-flop at edges detected by max delta in a 9-sample window that exceeds the threshold. This algorithm doesn’t end up matching the natural intuition about the levels in the image.

Please open an issue, and I’ll look into adding an option for a different gate algorithm that is closer to intuition or the traditional rise/fall gates-from-audio method. I think it would be a nice addition.

@Paul-Dempsey Paul-Dempsey added the enhancement New feature or request label Nov 15, 2023
@Paul-Dempsey Paul-Dempsey self-assigned this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants