Skip to content

Commit f258c1f

Browse files
LocalIdentityLocalIdentity
and
LocalIdentity
authored
Fix Minion supports not scaling Siegebreaker ground DoT (#8552)
Skill gems should scale the damage from the ground DoT but were not as we did not add any skill tags to the effect Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent f6b5147 commit f258c1f

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

src/Data/Skills/minion.lua

+4-6
Original file line numberDiff line numberDiff line change
@@ -1561,11 +1561,10 @@ skills["SiegebreakerCausticGround"] = {
15611561
hidden = true,
15621562
color = 4,
15631563
baseFlags = {
1564-
cast = true,
15651564
area = true,
1566-
chaos = true,
1565+
duration = true,
15671566
},
1568-
skillTypes = { },
1567+
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Chaos] = true, [SkillType.AreaSpell] = true, },
15691568
baseMods = {
15701569
skill("ChaosDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerCausticGroundPercent" }),
15711570
skill("dotIsArea", true),
@@ -1584,11 +1583,10 @@ skills["ReplicaSiegebreakerBurningGround"] = {
15841583
hidden = true,
15851584
color = 4,
15861585
baseFlags = {
1587-
cast = true,
15881586
area = true,
1589-
fire = true,
1587+
duration = true,
15901588
},
1591-
skillTypes = { },
1589+
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Fire] = true, [SkillType.AreaSpell] = true, [SkillType.CausesBurning] = true, },
15921590
baseMods = {
15931591
skill("FireDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerBurningGroundPercent" }),
15941592
skill("dotIsArea", true),

src/Export/Skills/minion.txt

+6-8
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,12 @@ skills["SiegebreakerCausticGround"] = {
289289
hidden = true,
290290
color = 4,
291291
baseFlags = {
292-
cast = true,
293292
area = true,
294-
chaos = true,
293+
duration = true,
295294
},
296-
skillTypes = { },
295+
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Chaos] = true, [SkillType.AreaSpell] = true, },
297296
baseMods = {
298-
skill("ChaosDot", 1, { type = "PercentStat", stat = "Life", percentVar = "CausticGroundPercent" }),
297+
skill("ChaosDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerCausticGroundPercent" }),
299298
skill("dotIsArea", true),
300299
flag("dotIsCausticGround"),
301300
},
@@ -312,13 +311,12 @@ skills["ReplicaSiegebreakerBurningGround"] = {
312311
hidden = true,
313312
color = 4,
314313
baseFlags = {
315-
cast = true,
316314
area = true,
317-
fire = true,
315+
duration = true,
318316
},
319-
skillTypes = { },
317+
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Fire] = true, [SkillType.AreaSpell] = true, [SkillType.CausesBurning] = true, },
320318
baseMods = {
321-
skill("FireDot", 1, { type = "PercentStat", stat = "Life", percentVar = "BurningGroundPercent" }),
319+
skill("FireDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerBurningGroundPercent" }),
322320
skill("dotIsArea", true),
323321
flag("dotIsBurningGround"),
324322
},

0 commit comments

Comments
 (0)