Replies: 2 comments
-
Hmm i check a little the logic and looks like this.
If only need call the NMS method for calculate the mount of items maybe can make a PR for this and wait a few tests... |
Beta Was this translation helpful? Give feedback.
0 replies
-
Related to #8749 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Is your feature request related to a problem?
The
CraftItemEvent
does not allow you to see how many items the player actually crafted. It seems like the result acts more like a copy. It would be a lot more intuitive if the event offered the number of items the player actually crafted.Describe the solution you'd like.
Some way to access the final result of the craft event, like getFinalResult or just altering the current method that already exists to make it reflect the result of the event.
Describe alternatives you've considered.
Hacky & imperfect guessing logic to see how many items the player crafted based on their inventory.
Other
The original issue explains this pretty well: #7383. I am opening this issue because that one was closed due to being stale.
Also, IIRC the
PlayerTradeEvent
offers a proper result that tells you how many emeralds or other items the player received, and works when the item is shift-clicked into the player's inventory. Maybe theCraftItemEvent
could be updated to look more like that, if that's possible? Thank you for reading!Beta Was this translation helpful? Give feedback.
All reactions