From b98857da097d814b4030b744a21f464650f92d14 Mon Sep 17 00:00:00 2001 From: Uladzislau Hubar Date: Thu, 8 Feb 2024 14:34:48 +0100 Subject: [PATCH] Fixed linter warnings --- contracts/v2/CommitManagerV1.sol | 2 -- contracts/v2/constants/HashRingConstants.sol | 5 +++++ contracts/v2/scoring/LinearSum.sol | 3 +-- contracts/v2/storage/NodeOperatorFeeChangesStorage.sol | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) create mode 100644 contracts/v2/constants/HashRingConstants.sol diff --git a/contracts/v2/CommitManagerV1.sol b/contracts/v2/CommitManagerV1.sol index 93e74558..8fd19850 100644 --- a/contracts/v2/CommitManagerV1.sol +++ b/contracts/v2/CommitManagerV1.sol @@ -49,8 +49,6 @@ contract CommitManagerV2 is Named, Versioned, ContractStatus, Initializable { ShardingTableStorageV2 public shardingTableStorage; StakingStorage public stakingStorage; - uint256 constant HASH_RING_SIZE = type(uint256).max; - // solhint-disable-next-line no-empty-blocks constructor(address hubAddress) ContractStatus(hubAddress) {} diff --git a/contracts/v2/constants/HashRingConstants.sol b/contracts/v2/constants/HashRingConstants.sol new file mode 100644 index 00000000..233b2713 --- /dev/null +++ b/contracts/v2/constants/HashRingConstants.sol @@ -0,0 +1,5 @@ +// SPDX-License-Identifier: MIT + +pragma solidity ^0.8.16; + +uint256 constant HASH_RING_SIZE = type(uint256).max; diff --git a/contracts/v2/scoring/LinearSum.sol b/contracts/v2/scoring/LinearSum.sol index e9ad4b91..3b1ffe30 100644 --- a/contracts/v2/scoring/LinearSum.sol +++ b/contracts/v2/scoring/LinearSum.sol @@ -10,6 +10,7 @@ import {Initializable} from "../../v1/interface/Initializable.sol"; import {IProximityScoreFunctionsPair} from "../interface/IProximityScoreFunctionsPair.sol"; import {Named} from "../../v1/interface/Named.sol"; import {ScaleDownLib} from "../utils/ScaleDownLibrary.sol"; +import {HASH_RING_SIZE} from "../constants/HashRingConstants.sol"; contract LinearSum is IProximityScoreFunctionsPair, Indexable, Named, HubDependent, Initializable { event ParameterChanged(string parameterName, uint256 parameterValue); @@ -17,8 +18,6 @@ contract LinearSum is IProximityScoreFunctionsPair, Indexable, Named, HubDepende uint8 private constant _ID = 2; string private constant _NAME = "LinearSum"; - uint256 constant HASH_RING_SIZE = type(uint256).max; - HashingProxy public hashingProxy; ParametersStorage public parametersStorage; diff --git a/contracts/v2/storage/NodeOperatorFeeChangesStorage.sol b/contracts/v2/storage/NodeOperatorFeeChangesStorage.sol index 4aa83479..8e0e43a4 100644 --- a/contracts/v2/storage/NodeOperatorFeeChangesStorage.sol +++ b/contracts/v2/storage/NodeOperatorFeeChangesStorage.sol @@ -25,7 +25,7 @@ contract NodeOperatorFeeChangesStorage is Named, Versioned, HubDependent { constructor(address hubAddress) HubDependent(hubAddress) {} modifier onlyOnce() { - require(!_delayFreePeriodSet, "Function has already been executed."); + require(!_delayFreePeriodSet, "Fn has already been executed"); _; _delayFreePeriodSet = true; }