Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis standalone/replicated instances are not restarted on ConfigMap change #960

Open
alita1991 opened this issue May 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@alita1991
Copy link

What version of redis operator are you using?

kubectl logs <_redis-operator_pod_name> -n <namespace>

redis-operator version: 0.16.0

Does this issue reproduce with the latest release?
Yes

What operating system and processor architecture are you using (kubectl version)?

kubectl version Output
$ kubectl version
Client Version: v1.29.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

What did you do?

  1. Created a Redis Standalone instance via RedisStandalone CR with additional config
  2. Updated the ConfigMap, where the additional config is stored

What did you expect to see?
Redis instance should be restarted

What did you see instead?
Redis instance is not restarted to start with the new config

@alita1991 alita1991 added the bug Something isn't working label May 31, 2024
@Mlk777
Copy link

Mlk777 commented Jun 4, 2024

If I'm not wrong, in Kubernetes Pods and Configmap are decoupled so it's not related to the operator, it's default behavior. You'll need to find another way (watchers, kustomize or tools that will handle it for you)

@alita1991
Copy link
Author

I solved this problem with https://github.com/stakater/Reloader, but I'm seeking a solution to minimize additional steps. For example, if the Redis Operator can create the ConfigMap via CR, it should be enough to know when to trigger a RollingUpgrade, the easiest way is with an annotation that stores the hash value of ConfigMap data.

@drivebyer drivebyer added enhancement New feature or request and removed bug Something isn't working labels Jun 20, 2024
@jeremych1000
Copy link

I solved this problem with https://github.com/stakater/Reloader, but I'm seeking a solution to minimize additional steps. For example, if the Redis Operator can create the ConfigMap via CR, it should be enough to know when to trigger a RollingUpgrade, the easiest way is with an annotation that stores the hash value of ConfigMap data.

I'm using reloader with the operator and have found that they conflict with each other. Has anyone else had success with reloader?

As soon as I change the config, reloader executes the rollout restart command, but it only restarts one of my three pods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants