Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to configure annotations for leader-headless service only #1272

Open
arpan57 opened this issue Mar 11, 2025 · 1 comment
Open

Option to configure annotations for leader-headless service only #1272

arpan57 opened this issue Mar 11, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@arpan57
Copy link

arpan57 commented Mar 11, 2025

Is your feature request related to a problem? Please describe.
I am trying to use additional annotations in order to work with exernal-dns. Using the recent operator upgrade PR (#1219) we are able to configure additional annotations for headless services.
However, currently the operator adds annotations for both leader-headless and follower-headless services.

Describe the solution you'd like

We should have an option to choose if we want to enable additionalannotations for leader-headless or follower-headless or for both. We do not want to add these annotations for follower services.

Ideal solution would be to have separate service template like charts/redis-cluster/templates/leader-service.yaml and like charts/redis-cluster/templates/follower-service.yaml for leader-headless and follower-headless services. Where we have an option to configure headless services.

Describe alternatives you've considered

Patching k8sutils/labels.go file method - generateServiceAnots - add an if condition to check if its for leader or for follower. If for follower skip the additional annotations - well that's only for our usecase.
I also tried 'hacking' external service templates leader-service.yaml and follower-service.yaml - which creates additional services with ClusterIP - None

What version of redis-operator are you using?

redis-operator version: 0.19.1

Additional context

Additionally
Apart from this we would be happy to have one more option/flag to choose enable/disable creating
test-cluster-follower-headless
test-cluster-follower
services.

We might not want to create services for follower for example we might not want to create test-cluster-follower-headless, test-cluster-follower .

Thanks,
Arpan

@arpan57 arpan57 added the enhancement New feature or request label Mar 11, 2025
@shubham-cmyk
Copy link
Member

@arpan57
would you like to raise a PR on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants