Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if two covariate builders generate overlapping covariate IDs #168

Open
schuemie opened this issue Jun 7, 2022 · 0 comments

Comments

@schuemie
Copy link
Member

schuemie commented Jun 7, 2022

When calling getDbCovariateData() with a list of covariate settings, FeatureExtraction iterates over the builders, and appends the covariate data. It would be good if an error was thrown if two covariate builders create overlapping covariate IDs.

For speed it may be advisable to check overlap based on covariateRef rather than covariates itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant