Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop table COHORT_DEFINITION #725

Open
cgreich opened this issue Feb 14, 2025 · 3 comments
Open

Drop table COHORT_DEFINITION #725

cgreich opened this issue Feb 14, 2025 · 3 comments

Comments

@cgreich
Copy link
Contributor

cgreich commented Feb 14, 2025

This table was contrived as a way to define the content of a cohort. That was before ATLAS. There is no need anymore, as we have a different mechanism to achieve that goal.

@MelaniePhilofsky
Copy link
Collaborator

Some of us use this table because due to the limitations of Atlas. We create cohorts outside of Atlas and import them into the CDM during our ETL. Since it is being used by the community, we shouldn’t deprecate the table.

@cgreich
Copy link
Contributor Author

cgreich commented Feb 18, 2025

Want to shift it to CDM Expansion? Since there is no generally used purpose or definition?

@MelaniePhilofsky
Copy link
Collaborator

Possibly. BUT first we need to discuss and document what support the Expansion tables in the CDM receive. Do they have DDLs? Are there DQD checks for them? What about Atlas and other analytical tool support?

Once we decide on the requirements for Canonical vs Expansion, then we can review all current and proposed CDM tables and put them into a bucket. Also, we might need another level or designation for CDM tables. Canonical is the core CDM; Expansion is supported with DDLs, rules & requirements and Themis conventions; and then there are "other" tables which are more sandbox or experimental tables, which could be upgraded to Expansion or Canonical tables, but need more work. This is just an idea, but we need to start with the requirements for the Canonical CDM before adding or dropping any tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants