Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create translateJsonToCode.R #463

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Create translateJsonToCode.R #463

wants to merge 4 commits into from

Conversation

catalamarti
Copy link
Collaborator

closes #462

@catalamarti catalamarti marked this pull request as draft February 19, 2025 10:58
@catalamarti
Copy link
Collaborator Author

hi @edward-burn what do you think about the structure?

@edward-burn
Copy link
Collaborator

edward-burn commented Feb 19, 2025 •
edited
Loading

Sort of, but I was more thinking the exported function would instantiate the set of cohorts - what do you think? But I see providing the code is actually nice because easy to tweak and makes everything super transparent.

Maybe there would be two functions:

  • one to get the r code
  • one to just create the cohort using CohortConstructor as the engine ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

atlas json -> cohort constructor pipeline
2 participants
@catalamarti @edward-burn