[IMP] stock_storage_type: Rely on ORM in order to get locations per quantity

The current implementation was triggerring queries (read_group). Rely now
on ORM to get records as 'quant_ids' field exists on locations

Author: rousseldenis

stock_storage_type/models/stock_location.py

@@ -7,7 +7,7 @@
 
 from odoo import api, fields, models
 from odoo.fields import Command
-from odoo.tools import float_compare, index_exists
+from odoo.tools import float_compare, groupby, index_exists
 
 _logger = logging.getLogger(__name__)
 OUT_MOVE_LINE_DOMAIN = [
@@ -703,18 +703,18 @@ def _order_allowed_locations(self, valid_locations):
         valid_no_mix = valid_locations.filtered("do_not_mix_products")
         loc_ordered_by_qty = []
         if valid_no_mix:
-            StockQuant = self.env["stock.quant"]
-            domain_quant = [("location_id", "in", valid_no_mix.ids)]
-            loc_ordered_by_qty = [
-                item["location_id"][0]
-                for item in StockQuant.read_group(
-                    domain_quant,
-                    ["location_id", "quantity"],
-                    ["location_id"],
-                    orderby="quantity",
+            for location, items in groupby(
+                valid_no_mix.quant_ids.sorted("quantity"),
+                lambda quant: quant.location_id,
+            ):
+                loc_ordered_by_qty.extend(
+                    [
+                        location.id
+                        for item in items
+                        if (float_compare(item["quantity"], 0, precision_digits=2) > 0)
+                    ]
                 )
-                if (float_compare(item["quantity"], 0, precision_digits=2) > 0)
-            ]
+
         valid_location_ids = set(valid_locations.ids) - set(loc_ordered_by_qty)
         ordered_valid_location_ids = loc_ordered_by_qty + [
             id_ for id_ in self.ids if id_ in valid_location_ids

stock_storage_type/tests/test_storage_type_putaway_strategy.py

@@ -921,3 +921,17 @@ def test_storage_strategy_same_ordered_locations_pallets_reapply(self):
             int_picking.move_line_ids[0].mapped("location_dest_id"),
             self.pallets_bin_3_location,
         )
+
+        self.env["stock.quant"].with_context(inventory_mode=True).create(
+            {
+                "product_id": self.product.id,
+                "location_id": self.pallets_bin_3_location.id,
+                "inventory_quantity": 10.0,
+            }
+        )._apply_inventory()
+
+        int_picking.move_line_ids._apply_putaway_strategy()
+        self.assertEqual(
+            int_picking.move_line_ids[0].mapped("location_dest_id"),
+            self.pallets_bin_3_location,
+        )